Thu, 22 May 2014 15:52:41 -0400
8037816: Fix for 8036122 breaks build with Xcode5/clang
8043029: Change 8037816 breaks HS build with older GCC versions which don't support diagnostic pragmas
8043164: Format warning in traceStream.hpp
Summary: Backport of main fix + two corrections, enables clang compilation, turns on format attributes, corrects/mutes warnings
Reviewed-by: kvn, coleenp, iveresov, twisti
duke@435 | 1 | /* |
drchase@6680 | 2 | * Copyright (c) 2003, 2014, Oracle and/or its affiliates. All rights reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
trims@1907 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
trims@1907 | 20 | * or visit www.oracle.com if you need additional information or have any |
trims@1907 | 21 | * questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
stefank@2314 | 25 | #include "precompiled.hpp" |
twisti@4318 | 26 | #include "asm/macroAssembler.hpp" |
stefank@2314 | 27 | #include "code/vtableStubs.hpp" |
roland@5987 | 28 | #include "interp_masm_x86.hpp" |
stefank@2314 | 29 | #include "memory/resourceArea.hpp" |
stefank@2314 | 30 | #include "oops/instanceKlass.hpp" |
stefank@2314 | 31 | #include "oops/klassVtable.hpp" |
stefank@2314 | 32 | #include "runtime/sharedRuntime.hpp" |
stefank@2314 | 33 | #include "vmreg_x86.inline.hpp" |
stefank@2314 | 34 | #ifdef COMPILER2 |
stefank@2314 | 35 | #include "opto/runtime.hpp" |
stefank@2314 | 36 | #endif |
duke@435 | 37 | |
drchase@6680 | 38 | PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC |
drchase@6680 | 39 | |
duke@435 | 40 | // machine-dependent part of VtableStubs: create VtableStub of correct size and |
duke@435 | 41 | // initialize its code |
duke@435 | 42 | |
duke@435 | 43 | #define __ masm-> |
duke@435 | 44 | |
duke@435 | 45 | #ifndef PRODUCT |
duke@435 | 46 | extern "C" void bad_compiled_vtable_index(JavaThread* thread, |
duke@435 | 47 | oop receiver, |
duke@435 | 48 | int index); |
duke@435 | 49 | #endif |
duke@435 | 50 | |
duke@435 | 51 | VtableStub* VtableStubs::create_vtable_stub(int vtable_index) { |
duke@435 | 52 | const int amd64_code_length = VtableStub::pd_code_size_limit(true); |
duke@435 | 53 | VtableStub* s = new(amd64_code_length) VtableStub(true, vtable_index); |
anoll@5762 | 54 | // Can be NULL if there is no free space in the code cache. |
anoll@5762 | 55 | if (s == NULL) { |
anoll@5762 | 56 | return NULL; |
anoll@5762 | 57 | } |
anoll@5762 | 58 | |
duke@435 | 59 | ResourceMark rm; |
duke@435 | 60 | CodeBuffer cb(s->entry_point(), amd64_code_length); |
duke@435 | 61 | MacroAssembler* masm = new MacroAssembler(&cb); |
duke@435 | 62 | |
duke@435 | 63 | #ifndef PRODUCT |
duke@435 | 64 | if (CountCompiledCalls) { |
duke@435 | 65 | __ incrementl(ExternalAddress((address) SharedRuntime::nof_megamorphic_calls_addr())); |
duke@435 | 66 | } |
duke@435 | 67 | #endif |
duke@435 | 68 | |
duke@435 | 69 | // get receiver (need to skip return address on top of stack) |
duke@435 | 70 | assert(VtableStub::receiver_location() == j_rarg0->as_VMReg(), "receiver expected in j_rarg0"); |
duke@435 | 71 | |
duke@435 | 72 | // Free registers (non-args) are rax, rbx |
duke@435 | 73 | |
duke@435 | 74 | // get receiver klass |
duke@435 | 75 | address npe_addr = __ pc(); |
coleenp@548 | 76 | __ load_klass(rax, j_rarg0); |
duke@435 | 77 | |
duke@435 | 78 | #ifndef PRODUCT |
duke@435 | 79 | if (DebugVtables) { |
duke@435 | 80 | Label L; |
duke@435 | 81 | // check offset vs vtable length |
coleenp@4037 | 82 | __ cmpl(Address(rax, InstanceKlass::vtable_length_offset() * wordSize), |
duke@435 | 83 | vtable_index * vtableEntry::size()); |
duke@435 | 84 | __ jcc(Assembler::greater, L); |
duke@435 | 85 | __ movl(rbx, vtable_index); |
duke@435 | 86 | __ call_VM(noreg, |
duke@435 | 87 | CAST_FROM_FN_PTR(address, bad_compiled_vtable_index), j_rarg0, rbx); |
duke@435 | 88 | __ bind(L); |
duke@435 | 89 | } |
duke@435 | 90 | #endif // PRODUCT |
duke@435 | 91 | |
coleenp@4037 | 92 | // load Method* and target address |
duke@435 | 93 | const Register method = rbx; |
duke@435 | 94 | |
twisti@3969 | 95 | __ lookup_virtual_method(rax, vtable_index, method); |
twisti@3969 | 96 | |
duke@435 | 97 | if (DebugVtables) { |
duke@435 | 98 | Label L; |
never@739 | 99 | __ cmpptr(method, (int32_t)NULL_WORD); |
duke@435 | 100 | __ jcc(Assembler::equal, L); |
coleenp@4037 | 101 | __ cmpptr(Address(method, Method::from_compiled_offset()), (int32_t)NULL_WORD); |
duke@435 | 102 | __ jcc(Assembler::notZero, L); |
duke@435 | 103 | __ stop("Vtable entry is NULL"); |
duke@435 | 104 | __ bind(L); |
duke@435 | 105 | } |
duke@435 | 106 | // rax: receiver klass |
coleenp@4037 | 107 | // rbx: Method* |
duke@435 | 108 | // rcx: receiver |
duke@435 | 109 | address ame_addr = __ pc(); |
coleenp@4037 | 110 | __ jmp( Address(rbx, Method::from_compiled_offset())); |
duke@435 | 111 | |
duke@435 | 112 | __ flush(); |
jrose@1058 | 113 | |
jrose@1058 | 114 | if (PrintMiscellaneous && (WizardMode || Verbose)) { |
jrose@1058 | 115 | tty->print_cr("vtable #%d at "PTR_FORMAT"[%d] left over: %d", |
jrose@1058 | 116 | vtable_index, s->entry_point(), |
jrose@1058 | 117 | (int)(s->code_end() - s->entry_point()), |
jrose@1058 | 118 | (int)(s->code_end() - __ pc())); |
jrose@1058 | 119 | } |
jrose@1058 | 120 | guarantee(__ pc() <= s->code_end(), "overflowed buffer"); |
jrose@1144 | 121 | // shut the door on sizing bugs |
jrose@1144 | 122 | int slop = 3; // 32-bit offset is this much larger than an 8-bit one |
jrose@1144 | 123 | assert(vtable_index > 10 || __ pc() + slop <= s->code_end(), "room for 32-bit offset"); |
jrose@1058 | 124 | |
duke@435 | 125 | s->set_exception_points(npe_addr, ame_addr); |
duke@435 | 126 | return s; |
duke@435 | 127 | } |
duke@435 | 128 | |
duke@435 | 129 | |
jrose@1058 | 130 | VtableStub* VtableStubs::create_itable_stub(int itable_index) { |
duke@435 | 131 | // Note well: pd_code_size_limit is the absolute minimum we can get |
duke@435 | 132 | // away with. If you add code here, bump the code stub size |
duke@435 | 133 | // returned by pd_code_size_limit! |
duke@435 | 134 | const int amd64_code_length = VtableStub::pd_code_size_limit(false); |
jrose@1058 | 135 | VtableStub* s = new(amd64_code_length) VtableStub(false, itable_index); |
anoll@5762 | 136 | // Can be NULL if there is no free space in the code cache. |
anoll@5762 | 137 | if (s == NULL) { |
anoll@5762 | 138 | return NULL; |
anoll@5762 | 139 | } |
anoll@5762 | 140 | |
duke@435 | 141 | ResourceMark rm; |
duke@435 | 142 | CodeBuffer cb(s->entry_point(), amd64_code_length); |
duke@435 | 143 | MacroAssembler* masm = new MacroAssembler(&cb); |
duke@435 | 144 | |
duke@435 | 145 | #ifndef PRODUCT |
duke@435 | 146 | if (CountCompiledCalls) { |
duke@435 | 147 | __ incrementl(ExternalAddress((address) SharedRuntime::nof_megamorphic_calls_addr())); |
duke@435 | 148 | } |
duke@435 | 149 | #endif |
duke@435 | 150 | |
duke@435 | 151 | // Entry arguments: |
duke@435 | 152 | // rax: Interface |
duke@435 | 153 | // j_rarg0: Receiver |
duke@435 | 154 | |
duke@435 | 155 | // Free registers (non-args) are rax (interface), rbx |
duke@435 | 156 | |
duke@435 | 157 | // get receiver (need to skip return address on top of stack) |
duke@435 | 158 | |
duke@435 | 159 | assert(VtableStub::receiver_location() == j_rarg0->as_VMReg(), "receiver expected in j_rarg0"); |
duke@435 | 160 | // get receiver klass (also an implicit null-check) |
duke@435 | 161 | address npe_addr = __ pc(); |
duke@435 | 162 | |
jrose@1058 | 163 | // Most registers are in use; we'll use rax, rbx, r10, r11 |
jrose@1058 | 164 | // (various calling sequences use r[cd]x, r[sd]i, r[89]; stay away from them) |
jrose@1058 | 165 | __ load_klass(r10, j_rarg0); |
duke@435 | 166 | |
duke@435 | 167 | // If we take a trap while this arg is on the stack we will not |
duke@435 | 168 | // be able to walk the stack properly. This is not an issue except |
duke@435 | 169 | // when there are mistakes in this assembly code that could generate |
duke@435 | 170 | // a spurious fault. Ask me how I know... |
duke@435 | 171 | |
jrose@1058 | 172 | const Register method = rbx; |
jrose@1058 | 173 | Label throw_icce; |
duke@435 | 174 | |
coleenp@4037 | 175 | // Get Method* and entrypoint for compiler |
jrose@1058 | 176 | __ lookup_interface_method(// inputs: rec. class, interface, itable index |
jrose@1058 | 177 | r10, rax, itable_index, |
jrose@1058 | 178 | // outputs: method, scan temp. reg |
jrose@1058 | 179 | method, r11, |
jrose@1058 | 180 | throw_icce); |
duke@435 | 181 | |
coleenp@4037 | 182 | // method (rbx): Method* |
duke@435 | 183 | // j_rarg0: receiver |
duke@435 | 184 | |
duke@435 | 185 | #ifdef ASSERT |
dcubed@451 | 186 | if (DebugVtables) { |
dcubed@451 | 187 | Label L2; |
never@739 | 188 | __ cmpptr(method, (int32_t)NULL_WORD); |
dcubed@451 | 189 | __ jcc(Assembler::equal, L2); |
coleenp@4037 | 190 | __ cmpptr(Address(method, Method::from_compiled_offset()), (int32_t)NULL_WORD); |
dcubed@451 | 191 | __ jcc(Assembler::notZero, L2); |
dcubed@451 | 192 | __ stop("compiler entrypoint is null"); |
dcubed@451 | 193 | __ bind(L2); |
dcubed@451 | 194 | } |
duke@435 | 195 | #endif // ASSERT |
duke@435 | 196 | |
coleenp@4037 | 197 | // rbx: Method* |
dcubed@451 | 198 | // j_rarg0: receiver |
dcubed@451 | 199 | address ame_addr = __ pc(); |
coleenp@4037 | 200 | __ jmp(Address(method, Method::from_compiled_offset())); |
dcubed@451 | 201 | |
dcubed@451 | 202 | __ bind(throw_icce); |
dcubed@451 | 203 | __ jump(RuntimeAddress(StubRoutines::throw_IncompatibleClassChangeError_entry())); |
duke@435 | 204 | |
duke@435 | 205 | __ flush(); |
dcubed@451 | 206 | |
jrose@1058 | 207 | if (PrintMiscellaneous && (WizardMode || Verbose)) { |
jrose@1058 | 208 | tty->print_cr("itable #%d at "PTR_FORMAT"[%d] left over: %d", |
jrose@1058 | 209 | itable_index, s->entry_point(), |
jrose@1058 | 210 | (int)(s->code_end() - s->entry_point()), |
jrose@1058 | 211 | (int)(s->code_end() - __ pc())); |
jrose@1058 | 212 | } |
dcubed@451 | 213 | guarantee(__ pc() <= s->code_end(), "overflowed buffer"); |
jrose@1144 | 214 | // shut the door on sizing bugs |
jrose@1144 | 215 | int slop = 3; // 32-bit offset is this much larger than an 8-bit one |
jrose@1144 | 216 | assert(itable_index > 10 || __ pc() + slop <= s->code_end(), "room for 32-bit offset"); |
dcubed@451 | 217 | |
duke@435 | 218 | s->set_exception_points(npe_addr, ame_addr); |
duke@435 | 219 | return s; |
duke@435 | 220 | } |
duke@435 | 221 | |
duke@435 | 222 | int VtableStub::pd_code_size_limit(bool is_vtable_stub) { |
duke@435 | 223 | if (is_vtable_stub) { |
duke@435 | 224 | // Vtable stub size |
coleenp@548 | 225 | return (DebugVtables ? 512 : 24) + (CountCompiledCalls ? 13 : 0) + |
ehelin@5694 | 226 | (UseCompressedClassPointers ? MacroAssembler::instr_size_for_decode_klass_not_null() : 0); |
duke@435 | 227 | } else { |
duke@435 | 228 | // Itable stub size |
iveresov@2138 | 229 | return (DebugVtables ? 512 : 74) + (CountCompiledCalls ? 13 : 0) + |
ehelin@5694 | 230 | (UseCompressedClassPointers ? MacroAssembler::instr_size_for_decode_klass_not_null() : 0); |
duke@435 | 231 | } |
jrose@1144 | 232 | // In order to tune these parameters, run the JVM with VM options |
jrose@1144 | 233 | // +PrintMiscellaneous and +WizardMode to see information about |
jrose@1144 | 234 | // actual itable stubs. Look for lines like this: |
jrose@1144 | 235 | // itable #1 at 0x5551212[71] left over: 3 |
jrose@1144 | 236 | // Reduce the constants so that the "left over" number is >=3 |
jrose@1144 | 237 | // for the common cases. |
jrose@1144 | 238 | // Do not aim at a left-over number of zero, because a |
jrose@1144 | 239 | // large vtable or itable index (>= 32) will require a 32-bit |
jrose@1144 | 240 | // immediate displacement instead of an 8-bit one. |
jrose@1144 | 241 | // |
jrose@1144 | 242 | // The JVM98 app. _202_jess has a megamorphic interface call. |
jrose@1144 | 243 | // The itable code looks like this: |
jrose@1144 | 244 | // Decoding VtableStub itbl[1]@12 |
jrose@1144 | 245 | // mov 0x8(%rsi),%r10 |
jrose@1144 | 246 | // mov 0x198(%r10),%r11d |
jrose@1144 | 247 | // lea 0x218(%r10,%r11,8),%r11 |
jrose@1144 | 248 | // lea 0x8(%r10),%r10 |
jrose@1144 | 249 | // mov (%r11),%rbx |
jrose@1144 | 250 | // cmp %rbx,%rax |
jrose@1144 | 251 | // je success |
jrose@1144 | 252 | // loop: |
jrose@1144 | 253 | // test %rbx,%rbx |
jrose@1144 | 254 | // je throw_icce |
jrose@1144 | 255 | // add $0x10,%r11 |
jrose@1144 | 256 | // mov (%r11),%rbx |
jrose@1144 | 257 | // cmp %rbx,%rax |
jrose@1144 | 258 | // jne loop |
jrose@1144 | 259 | // success: |
jrose@1144 | 260 | // mov 0x8(%r11),%r11d |
jrose@1144 | 261 | // mov (%r10,%r11,1),%rbx |
jrose@1144 | 262 | // jmpq *0x60(%rbx) |
jrose@1144 | 263 | // throw_icce: |
jrose@1144 | 264 | // jmpq throw_ICCE_entry |
duke@435 | 265 | } |
duke@435 | 266 | |
duke@435 | 267 | int VtableStub::pd_code_alignment() { |
duke@435 | 268 | return wordSize; |
duke@435 | 269 | } |