Sat, 19 Jul 2008 17:38:22 -0400
6716785: implicit null checks not triggering with CompressedOops
Summary: allocate alignment-sized page(s) below java heap so that memory accesses at heap_base+1page give signal and cause an implicit null check
Reviewed-by: kvn, jmasa, phh, jcoomes
duke@435 | 1 | /* |
xdono@631 | 2 | * Copyright 2005-2008 Sun Microsystems, Inc. All Rights Reserved. |
duke@435 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@435 | 4 | * |
duke@435 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@435 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@435 | 7 | * published by the Free Software Foundation. |
duke@435 | 8 | * |
duke@435 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@435 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@435 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@435 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@435 | 13 | * accompanied this code). |
duke@435 | 14 | * |
duke@435 | 15 | * You should have received a copy of the GNU General Public License version |
duke@435 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@435 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@435 | 18 | * |
duke@435 | 19 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
duke@435 | 20 | * CA 95054 USA or visit www.sun.com if you need additional information or |
duke@435 | 21 | * have any questions. |
duke@435 | 22 | * |
duke@435 | 23 | */ |
duke@435 | 24 | |
duke@435 | 25 | # include "incls/_precompiled.incl" |
duke@435 | 26 | # include "incls/_parMarkBitMap.cpp.incl" |
duke@435 | 27 | |
duke@435 | 28 | bool |
duke@435 | 29 | ParMarkBitMap::initialize(MemRegion covered_region) |
duke@435 | 30 | { |
duke@435 | 31 | const idx_t bits = bits_required(covered_region); |
duke@435 | 32 | // The bits will be divided evenly between two bitmaps; each of them should be |
duke@435 | 33 | // an integral number of words. |
duke@435 | 34 | assert(bits % (BitsPerWord * 2) == 0, "region size unaligned"); |
duke@435 | 35 | |
duke@435 | 36 | const size_t words = bits / BitsPerWord; |
duke@435 | 37 | const size_t raw_bytes = words * sizeof(idx_t); |
duke@435 | 38 | const size_t page_sz = os::page_size_for_region(raw_bytes, raw_bytes, 10); |
duke@435 | 39 | const size_t granularity = os::vm_allocation_granularity(); |
duke@435 | 40 | const size_t bytes = align_size_up(raw_bytes, MAX2(page_sz, granularity)); |
duke@435 | 41 | |
duke@435 | 42 | const size_t rs_align = page_sz == (size_t) os::vm_page_size() ? 0 : |
duke@435 | 43 | MAX2(page_sz, granularity); |
jcoomes@514 | 44 | ReservedSpace rs(bytes, rs_align, rs_align > 0); |
duke@435 | 45 | os::trace_page_sizes("par bitmap", raw_bytes, raw_bytes, page_sz, |
duke@435 | 46 | rs.base(), rs.size()); |
duke@435 | 47 | _virtual_space = new PSVirtualSpace(rs, page_sz); |
duke@435 | 48 | if (_virtual_space != NULL && _virtual_space->expand_by(bytes)) { |
duke@435 | 49 | _region_start = covered_region.start(); |
duke@435 | 50 | _region_size = covered_region.word_size(); |
duke@435 | 51 | idx_t* map = (idx_t*)_virtual_space->reserved_low_addr(); |
duke@435 | 52 | _beg_bits.set_map(map); |
duke@435 | 53 | _beg_bits.set_size(bits / 2); |
duke@435 | 54 | _end_bits.set_map(map + words / 2); |
duke@435 | 55 | _end_bits.set_size(bits / 2); |
duke@435 | 56 | return true; |
duke@435 | 57 | } |
duke@435 | 58 | |
duke@435 | 59 | _region_start = 0; |
duke@435 | 60 | _region_size = 0; |
duke@435 | 61 | if (_virtual_space != NULL) { |
duke@435 | 62 | delete _virtual_space; |
duke@435 | 63 | _virtual_space = NULL; |
coleenp@672 | 64 | // Release memory reserved in the space. |
coleenp@672 | 65 | rs.release(); |
duke@435 | 66 | } |
duke@435 | 67 | return false; |
duke@435 | 68 | } |
duke@435 | 69 | |
duke@435 | 70 | #ifdef ASSERT |
duke@435 | 71 | extern size_t mark_bitmap_count; |
duke@435 | 72 | extern size_t mark_bitmap_size; |
duke@435 | 73 | #endif // #ifdef ASSERT |
duke@435 | 74 | |
duke@435 | 75 | bool |
duke@435 | 76 | ParMarkBitMap::mark_obj(HeapWord* addr, size_t size) |
duke@435 | 77 | { |
duke@435 | 78 | const idx_t beg_bit = addr_to_bit(addr); |
duke@435 | 79 | if (_beg_bits.par_set_bit(beg_bit)) { |
duke@435 | 80 | const idx_t end_bit = addr_to_bit(addr + size - 1); |
duke@435 | 81 | bool end_bit_ok = _end_bits.par_set_bit(end_bit); |
duke@435 | 82 | assert(end_bit_ok, "concurrency problem"); |
duke@435 | 83 | DEBUG_ONLY(Atomic::inc_ptr(&mark_bitmap_count)); |
duke@435 | 84 | DEBUG_ONLY(Atomic::add_ptr(size, &mark_bitmap_size)); |
duke@435 | 85 | return true; |
duke@435 | 86 | } |
duke@435 | 87 | return false; |
duke@435 | 88 | } |
duke@435 | 89 | |
duke@435 | 90 | size_t |
duke@435 | 91 | ParMarkBitMap::live_words_in_range(HeapWord* beg_addr, HeapWord* end_addr) const |
duke@435 | 92 | { |
duke@435 | 93 | assert(beg_addr <= end_addr, "bad range"); |
duke@435 | 94 | |
duke@435 | 95 | idx_t live_bits = 0; |
duke@435 | 96 | |
duke@435 | 97 | // The bitmap routines require the right boundary to be word-aligned. |
duke@435 | 98 | const idx_t end_bit = addr_to_bit(end_addr); |
duke@435 | 99 | const idx_t range_end = BitMap::word_align_up(end_bit); |
duke@435 | 100 | |
duke@435 | 101 | idx_t beg_bit = find_obj_beg(addr_to_bit(beg_addr), range_end); |
duke@435 | 102 | while (beg_bit < end_bit) { |
duke@435 | 103 | idx_t tmp_end = find_obj_end(beg_bit, range_end); |
duke@435 | 104 | if (tmp_end < end_bit) { |
duke@435 | 105 | live_bits += tmp_end - beg_bit + 1; |
duke@435 | 106 | beg_bit = find_obj_beg(tmp_end + 1, range_end); |
duke@435 | 107 | } else { |
duke@435 | 108 | live_bits += end_bit - beg_bit; // No + 1 here; end_bit is not counted. |
duke@435 | 109 | return bits_to_words(live_bits); |
duke@435 | 110 | } |
duke@435 | 111 | } |
duke@435 | 112 | return bits_to_words(live_bits); |
duke@435 | 113 | } |
duke@435 | 114 | |
duke@435 | 115 | size_t ParMarkBitMap::live_words_in_range(HeapWord* beg_addr, oop end_obj) const |
duke@435 | 116 | { |
duke@435 | 117 | assert(beg_addr <= (HeapWord*)end_obj, "bad range"); |
duke@435 | 118 | assert(is_marked(end_obj), "end_obj must be live"); |
duke@435 | 119 | |
duke@435 | 120 | idx_t live_bits = 0; |
duke@435 | 121 | |
duke@435 | 122 | // The bitmap routines require the right boundary to be word-aligned. |
duke@435 | 123 | const idx_t end_bit = addr_to_bit((HeapWord*)end_obj); |
duke@435 | 124 | const idx_t range_end = BitMap::word_align_up(end_bit); |
duke@435 | 125 | |
duke@435 | 126 | idx_t beg_bit = find_obj_beg(addr_to_bit(beg_addr), range_end); |
duke@435 | 127 | while (beg_bit < end_bit) { |
duke@435 | 128 | idx_t tmp_end = find_obj_end(beg_bit, range_end); |
duke@435 | 129 | assert(tmp_end < end_bit, "missing end bit"); |
duke@435 | 130 | live_bits += tmp_end - beg_bit + 1; |
duke@435 | 131 | beg_bit = find_obj_beg(tmp_end + 1, range_end); |
duke@435 | 132 | } |
duke@435 | 133 | return bits_to_words(live_bits); |
duke@435 | 134 | } |
duke@435 | 135 | |
duke@435 | 136 | ParMarkBitMap::IterationStatus |
duke@435 | 137 | ParMarkBitMap::iterate(ParMarkBitMapClosure* live_closure, |
duke@435 | 138 | idx_t range_beg, idx_t range_end) const |
duke@435 | 139 | { |
duke@435 | 140 | DEBUG_ONLY(verify_bit(range_beg);) |
duke@435 | 141 | DEBUG_ONLY(verify_bit(range_end);) |
duke@435 | 142 | assert(range_beg <= range_end, "live range invalid"); |
duke@435 | 143 | |
duke@435 | 144 | // The bitmap routines require the right boundary to be word-aligned. |
duke@435 | 145 | const idx_t search_end = BitMap::word_align_up(range_end); |
duke@435 | 146 | |
duke@435 | 147 | idx_t cur_beg = find_obj_beg(range_beg, search_end); |
duke@435 | 148 | while (cur_beg < range_end) { |
duke@435 | 149 | const idx_t cur_end = find_obj_end(cur_beg, search_end); |
duke@435 | 150 | if (cur_end >= range_end) { |
duke@435 | 151 | // The obj ends outside the range. |
duke@435 | 152 | live_closure->set_source(bit_to_addr(cur_beg)); |
duke@435 | 153 | return incomplete; |
duke@435 | 154 | } |
duke@435 | 155 | |
duke@435 | 156 | const size_t size = obj_size(cur_beg, cur_end); |
duke@435 | 157 | IterationStatus status = live_closure->do_addr(bit_to_addr(cur_beg), size); |
duke@435 | 158 | if (status != incomplete) { |
duke@435 | 159 | assert(status == would_overflow || status == full, "sanity"); |
duke@435 | 160 | return status; |
duke@435 | 161 | } |
duke@435 | 162 | |
duke@435 | 163 | // Successfully processed the object; look for the next object. |
duke@435 | 164 | cur_beg = find_obj_beg(cur_end + 1, search_end); |
duke@435 | 165 | } |
duke@435 | 166 | |
duke@435 | 167 | live_closure->set_source(bit_to_addr(range_end)); |
duke@435 | 168 | return complete; |
duke@435 | 169 | } |
duke@435 | 170 | |
duke@435 | 171 | ParMarkBitMap::IterationStatus |
duke@435 | 172 | ParMarkBitMap::iterate(ParMarkBitMapClosure* live_closure, |
duke@435 | 173 | ParMarkBitMapClosure* dead_closure, |
duke@435 | 174 | idx_t range_beg, idx_t range_end, |
duke@435 | 175 | idx_t dead_range_end) const |
duke@435 | 176 | { |
duke@435 | 177 | DEBUG_ONLY(verify_bit(range_beg);) |
duke@435 | 178 | DEBUG_ONLY(verify_bit(range_end);) |
duke@435 | 179 | DEBUG_ONLY(verify_bit(dead_range_end);) |
duke@435 | 180 | assert(range_beg <= range_end, "live range invalid"); |
duke@435 | 181 | assert(range_end <= dead_range_end, "dead range invalid"); |
duke@435 | 182 | |
duke@435 | 183 | // The bitmap routines require the right boundary to be word-aligned. |
duke@435 | 184 | const idx_t live_search_end = BitMap::word_align_up(range_end); |
duke@435 | 185 | const idx_t dead_search_end = BitMap::word_align_up(dead_range_end); |
duke@435 | 186 | |
duke@435 | 187 | idx_t cur_beg = range_beg; |
duke@435 | 188 | if (range_beg < range_end && is_unmarked(range_beg)) { |
duke@435 | 189 | // The range starts with dead space. Look for the next object, then fill. |
duke@435 | 190 | cur_beg = find_obj_beg(range_beg + 1, dead_search_end); |
duke@435 | 191 | const idx_t dead_space_end = MIN2(cur_beg - 1, dead_range_end - 1); |
duke@435 | 192 | const size_t size = obj_size(range_beg, dead_space_end); |
duke@435 | 193 | dead_closure->do_addr(bit_to_addr(range_beg), size); |
duke@435 | 194 | } |
duke@435 | 195 | |
duke@435 | 196 | while (cur_beg < range_end) { |
duke@435 | 197 | const idx_t cur_end = find_obj_end(cur_beg, live_search_end); |
duke@435 | 198 | if (cur_end >= range_end) { |
duke@435 | 199 | // The obj ends outside the range. |
duke@435 | 200 | live_closure->set_source(bit_to_addr(cur_beg)); |
duke@435 | 201 | return incomplete; |
duke@435 | 202 | } |
duke@435 | 203 | |
duke@435 | 204 | const size_t size = obj_size(cur_beg, cur_end); |
duke@435 | 205 | IterationStatus status = live_closure->do_addr(bit_to_addr(cur_beg), size); |
duke@435 | 206 | if (status != incomplete) { |
duke@435 | 207 | assert(status == would_overflow || status == full, "sanity"); |
duke@435 | 208 | return status; |
duke@435 | 209 | } |
duke@435 | 210 | |
duke@435 | 211 | // Look for the start of the next object. |
duke@435 | 212 | const idx_t dead_space_beg = cur_end + 1; |
duke@435 | 213 | cur_beg = find_obj_beg(dead_space_beg, dead_search_end); |
duke@435 | 214 | if (cur_beg > dead_space_beg) { |
duke@435 | 215 | // Found dead space; compute the size and invoke the dead closure. |
duke@435 | 216 | const idx_t dead_space_end = MIN2(cur_beg - 1, dead_range_end - 1); |
duke@435 | 217 | const size_t size = obj_size(dead_space_beg, dead_space_end); |
duke@435 | 218 | dead_closure->do_addr(bit_to_addr(dead_space_beg), size); |
duke@435 | 219 | } |
duke@435 | 220 | } |
duke@435 | 221 | |
duke@435 | 222 | live_closure->set_source(bit_to_addr(range_end)); |
duke@435 | 223 | return complete; |
duke@435 | 224 | } |
duke@435 | 225 | |
duke@435 | 226 | #ifndef PRODUCT |
duke@435 | 227 | void ParMarkBitMap::reset_counters() |
duke@435 | 228 | { |
duke@435 | 229 | _cas_tries = _cas_retries = _cas_by_another = 0; |
duke@435 | 230 | } |
duke@435 | 231 | #endif // #ifndef PRODUCT |
duke@435 | 232 | |
duke@435 | 233 | #ifdef ASSERT |
duke@435 | 234 | void ParMarkBitMap::verify_clear() const |
duke@435 | 235 | { |
duke@435 | 236 | const idx_t* const beg = (const idx_t*)_virtual_space->committed_low_addr(); |
duke@435 | 237 | const idx_t* const end = (const idx_t*)_virtual_space->committed_high_addr(); |
duke@435 | 238 | for (const idx_t* p = beg; p < end; ++p) { |
duke@435 | 239 | assert(*p == 0, "bitmap not clear"); |
duke@435 | 240 | } |
duke@435 | 241 | } |
duke@435 | 242 | #endif // #ifdef ASSERT |