src/share/vm/interpreter/rewriter.cpp

Sat, 29 May 2010 19:22:32 -0700

author
jrose
date
Sat, 29 May 2010 19:22:32 -0700
changeset 1929
1eb493f33423
parent 1920
ab102d5d923e
child 1934
e9ff18c4ace7
permissions
-rw-r--r--

6957080: MethodComparator needs stress testing
Summary: Add a stress-test flag for running MethodComparator over many inputs. Fix bugs that crop up.
Reviewed-by: kvn

duke@435 1 /*
jrose@1920 2 * Copyright 1998-2010 Sun Microsystems, Inc. All Rights Reserved.
duke@435 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
duke@435 4 *
duke@435 5 * This code is free software; you can redistribute it and/or modify it
duke@435 6 * under the terms of the GNU General Public License version 2 only, as
duke@435 7 * published by the Free Software Foundation.
duke@435 8 *
duke@435 9 * This code is distributed in the hope that it will be useful, but WITHOUT
duke@435 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
duke@435 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
duke@435 12 * version 2 for more details (a copy is included in the LICENSE file that
duke@435 13 * accompanied this code).
duke@435 14 *
duke@435 15 * You should have received a copy of the GNU General Public License version
duke@435 16 * 2 along with this work; if not, write to the Free Software Foundation,
duke@435 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
duke@435 18 *
duke@435 19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
duke@435 20 * CA 95054 USA or visit www.sun.com if you need additional information or
duke@435 21 * have any questions.
duke@435 22 *
duke@435 23 */
duke@435 24
duke@435 25 # include "incls/_precompiled.incl"
duke@435 26 # include "incls/_rewriter.cpp.incl"
duke@435 27
jrose@1161 28 // Computes a CPC map (new_index -> original_index) for constant pool entries
duke@435 29 // that are referred to by the interpreter at runtime via the constant pool cache.
jrose@1161 30 // Also computes a CP map (original_index -> new_index).
jrose@1161 31 // Marks entries in CP which require additional processing.
jrose@1161 32 void Rewriter::compute_index_maps() {
jrose@1161 33 const int length = _pool->length();
jrose@1161 34 init_cp_map(length);
duke@435 35 for (int i = 0; i < length; i++) {
jrose@1161 36 int tag = _pool->tag_at(i).value();
jrose@1161 37 switch (tag) {
jrose@1161 38 case JVM_CONSTANT_InterfaceMethodref:
duke@435 39 case JVM_CONSTANT_Fieldref : // fall through
duke@435 40 case JVM_CONSTANT_Methodref : // fall through
jrose@1161 41 add_cp_cache_entry(i);
jrose@1161 42 break;
duke@435 43 }
duke@435 44 }
jrose@1161 45
jrose@1161 46 guarantee((int)_cp_cache_map.length()-1 <= (int)((u2)-1),
jrose@1161 47 "all cp cache indexes fit in a u2");
duke@435 48 }
duke@435 49
duke@435 50
jrose@1161 51 // Creates a constant pool cache given a CPC map
jmasa@977 52 // This creates the constant pool cache initially in a state
jmasa@977 53 // that is unsafe for concurrent GC processing but sets it to
jmasa@977 54 // a safe mode before the constant pool cache is returned.
jrose@1161 55 void Rewriter::make_constant_pool_cache(TRAPS) {
jrose@1161 56 const int length = _cp_cache_map.length();
jrose@1161 57 constantPoolCacheOop cache =
jrose@1161 58 oopFactory::new_constantPoolCache(length, methodOopDesc::IsUnsafeConc, CHECK);
jrose@1161 59 cache->initialize(_cp_cache_map);
jrose@1161 60 _pool->set_cache(cache);
jrose@1161 61 cache->set_constant_pool(_pool());
duke@435 62 }
duke@435 63
duke@435 64
duke@435 65
duke@435 66 // The new finalization semantics says that registration of
duke@435 67 // finalizable objects must be performed on successful return from the
duke@435 68 // Object.<init> constructor. We could implement this trivially if
duke@435 69 // <init> were never rewritten but since JVMTI allows this to occur, a
duke@435 70 // more complicated solution is required. A special return bytecode
duke@435 71 // is used only by Object.<init> to signal the finalization
duke@435 72 // registration point. Additionally local 0 must be preserved so it's
duke@435 73 // available to pass to the registration function. For simplicty we
duke@435 74 // require that local 0 is never overwritten so it's available as an
duke@435 75 // argument for registration.
duke@435 76
duke@435 77 void Rewriter::rewrite_Object_init(methodHandle method, TRAPS) {
duke@435 78 RawBytecodeStream bcs(method);
duke@435 79 while (!bcs.is_last_bytecode()) {
duke@435 80 Bytecodes::Code opcode = bcs.raw_next();
duke@435 81 switch (opcode) {
duke@435 82 case Bytecodes::_return: *bcs.bcp() = Bytecodes::_return_register_finalizer; break;
duke@435 83
duke@435 84 case Bytecodes::_istore:
duke@435 85 case Bytecodes::_lstore:
duke@435 86 case Bytecodes::_fstore:
duke@435 87 case Bytecodes::_dstore:
duke@435 88 case Bytecodes::_astore:
duke@435 89 if (bcs.get_index() != 0) continue;
duke@435 90
duke@435 91 // fall through
duke@435 92 case Bytecodes::_istore_0:
duke@435 93 case Bytecodes::_lstore_0:
duke@435 94 case Bytecodes::_fstore_0:
duke@435 95 case Bytecodes::_dstore_0:
duke@435 96 case Bytecodes::_astore_0:
duke@435 97 THROW_MSG(vmSymbols::java_lang_IncompatibleClassChangeError(),
duke@435 98 "can't overwrite local 0 in Object.<init>");
duke@435 99 break;
duke@435 100 }
duke@435 101 }
duke@435 102 }
duke@435 103
duke@435 104
jrose@1161 105 // Rewrite a classfile-order CP index into a native-order CPC index.
jrose@1920 106 void Rewriter::rewrite_member_reference(address bcp, int offset) {
jrose@1161 107 address p = bcp + offset;
jrose@1161 108 int cp_index = Bytes::get_Java_u2(p);
jrose@1161 109 int cache_index = cp_entry_to_cp_cache(cp_index);
jrose@1161 110 Bytes::put_native_u2(p, cache_index);
jrose@1161 111 }
jrose@1161 112
jrose@1161 113
jrose@1920 114 void Rewriter::rewrite_invokedynamic(address bcp, int offset) {
jrose@1161 115 address p = bcp + offset;
jrose@1161 116 assert(p[-1] == Bytecodes::_invokedynamic, "");
jrose@1161 117 int cp_index = Bytes::get_Java_u2(p);
jrose@1161 118 int cpc = maybe_add_cp_cache_entry(cp_index); // add lazily
jrose@1494 119 int cpc2 = add_secondary_cp_cache_entry(cpc);
jrose@1161 120
jrose@1161 121 // Replace the trailing four bytes with a CPC index for the dynamic
jrose@1161 122 // call site. Unlike other CPC entries, there is one per bytecode,
jrose@1161 123 // not just one per distinct CP entry. In other words, the
jrose@1161 124 // CPC-to-CP relation is many-to-one for invokedynamic entries.
jrose@1161 125 // This means we must use a larger index size than u2 to address
jrose@1161 126 // all these entries. That is the main reason invokedynamic
jrose@1161 127 // must have a five-byte instruction format. (Of course, other JVM
jrose@1161 128 // implementations can use the bytes for other purposes.)
jrose@1494 129 Bytes::put_native_u4(p, constantPoolCacheOopDesc::encode_secondary_index(cpc2));
jrose@1161 130 // Note: We use native_u4 format exclusively for 4-byte indexes.
jrose@1161 131 }
jrose@1161 132
jrose@1161 133
duke@435 134 // Rewrites a method given the index_map information
jrose@1161 135 void Rewriter::scan_method(methodOop method) {
duke@435 136
duke@435 137 int nof_jsrs = 0;
duke@435 138 bool has_monitor_bytecodes = false;
duke@435 139
duke@435 140 {
duke@435 141 // We cannot tolerate a GC in this block, because we've
duke@435 142 // cached the bytecodes in 'code_base'. If the methodOop
duke@435 143 // moves, the bytecodes will also move.
duke@435 144 No_Safepoint_Verifier nsv;
duke@435 145 Bytecodes::Code c;
duke@435 146
duke@435 147 // Bytecodes and their length
duke@435 148 const address code_base = method->code_base();
duke@435 149 const int code_length = method->code_size();
duke@435 150
duke@435 151 int bc_length;
duke@435 152 for (int bci = 0; bci < code_length; bci += bc_length) {
duke@435 153 address bcp = code_base + bci;
jrose@1161 154 int prefix_length = 0;
duke@435 155 c = (Bytecodes::Code)(*bcp);
duke@435 156
duke@435 157 // Since we have the code, see if we can get the length
duke@435 158 // directly. Some more complicated bytecodes will report
duke@435 159 // a length of zero, meaning we need to make another method
duke@435 160 // call to calculate the length.
duke@435 161 bc_length = Bytecodes::length_for(c);
duke@435 162 if (bc_length == 0) {
duke@435 163 bc_length = Bytecodes::length_at(bcp);
duke@435 164
duke@435 165 // length_at will put us at the bytecode after the one modified
duke@435 166 // by 'wide'. We don't currently examine any of the bytecodes
duke@435 167 // modified by wide, but in case we do in the future...
duke@435 168 if (c == Bytecodes::_wide) {
jrose@1161 169 prefix_length = 1;
duke@435 170 c = (Bytecodes::Code)bcp[1];
duke@435 171 }
duke@435 172 }
duke@435 173
duke@435 174 assert(bc_length != 0, "impossible bytecode length");
duke@435 175
duke@435 176 switch (c) {
duke@435 177 case Bytecodes::_lookupswitch : {
duke@435 178 #ifndef CC_INTERP
duke@435 179 Bytecode_lookupswitch* bc = Bytecode_lookupswitch_at(bcp);
jrose@1920 180 (*bcp) = (
duke@435 181 bc->number_of_pairs() < BinarySwitchThreshold
duke@435 182 ? Bytecodes::_fast_linearswitch
duke@435 183 : Bytecodes::_fast_binaryswitch
duke@435 184 );
duke@435 185 #endif
duke@435 186 break;
duke@435 187 }
duke@435 188 case Bytecodes::_getstatic : // fall through
duke@435 189 case Bytecodes::_putstatic : // fall through
duke@435 190 case Bytecodes::_getfield : // fall through
duke@435 191 case Bytecodes::_putfield : // fall through
duke@435 192 case Bytecodes::_invokevirtual : // fall through
duke@435 193 case Bytecodes::_invokespecial : // fall through
jrose@1161 194 case Bytecodes::_invokestatic :
jrose@1161 195 case Bytecodes::_invokeinterface:
jrose@1161 196 rewrite_member_reference(bcp, prefix_length+1);
duke@435 197 break;
jrose@1161 198 case Bytecodes::_invokedynamic:
jrose@1920 199 rewrite_invokedynamic(bcp, prefix_length+1);
jrose@1161 200 break;
duke@435 201 case Bytecodes::_jsr : // fall through
duke@435 202 case Bytecodes::_jsr_w : nof_jsrs++; break;
duke@435 203 case Bytecodes::_monitorenter : // fall through
duke@435 204 case Bytecodes::_monitorexit : has_monitor_bytecodes = true; break;
duke@435 205 }
duke@435 206 }
duke@435 207 }
duke@435 208
duke@435 209 // Update access flags
duke@435 210 if (has_monitor_bytecodes) {
duke@435 211 method->set_has_monitor_bytecodes();
duke@435 212 }
duke@435 213
duke@435 214 // The present of a jsr bytecode implies that the method might potentially
duke@435 215 // have to be rewritten, so we run the oopMapGenerator on the method
duke@435 216 if (nof_jsrs > 0) {
duke@435 217 method->set_has_jsrs();
jrose@1161 218 // Second pass will revisit this method.
jrose@1161 219 assert(method->has_jsrs(), "");
jrose@1161 220 }
jrose@1161 221 }
duke@435 222
jrose@1161 223 // After constant pool is created, revisit methods containing jsrs.
jrose@1161 224 methodHandle Rewriter::rewrite_jsrs(methodHandle method, TRAPS) {
jrose@1161 225 ResolveOopMapConflicts romc(method);
jrose@1161 226 methodHandle original_method = method;
jrose@1161 227 method = romc.do_potential_rewrite(CHECK_(methodHandle()));
jrose@1161 228 if (method() != original_method()) {
jrose@1161 229 // Insert invalid bytecode into original methodOop and set
jrose@1161 230 // interpreter entrypoint, so that a executing this method
jrose@1161 231 // will manifest itself in an easy recognizable form.
jrose@1161 232 address bcp = original_method->bcp_from(0);
jrose@1161 233 *bcp = (u1)Bytecodes::_shouldnotreachhere;
jrose@1161 234 int kind = Interpreter::method_kind(original_method);
jrose@1161 235 original_method->set_interpreter_kind(kind);
duke@435 236 }
duke@435 237
jrose@1161 238 // Update monitor matching info.
jrose@1161 239 if (romc.monitor_safe()) {
jrose@1161 240 method->set_guaranteed_monitor_matching();
jrose@1161 241 }
duke@435 242
duke@435 243 return method;
duke@435 244 }
duke@435 245
duke@435 246
duke@435 247 void Rewriter::rewrite(instanceKlassHandle klass, TRAPS) {
duke@435 248 ResourceMark rm(THREAD);
twisti@1573 249 Rewriter rw(klass, klass->constants(), klass->methods(), CHECK);
jrose@1161 250 // (That's all, folks.)
jrose@1161 251 }
jrose@1161 252
twisti@1573 253
twisti@1573 254 void Rewriter::rewrite(instanceKlassHandle klass, constantPoolHandle cpool, objArrayHandle methods, TRAPS) {
twisti@1573 255 ResourceMark rm(THREAD);
twisti@1573 256 Rewriter rw(klass, cpool, methods, CHECK);
twisti@1573 257 // (That's all, folks.)
twisti@1573 258 }
twisti@1573 259
twisti@1573 260
twisti@1573 261 Rewriter::Rewriter(instanceKlassHandle klass, constantPoolHandle cpool, objArrayHandle methods, TRAPS)
jrose@1161 262 : _klass(klass),
twisti@1573 263 _pool(cpool),
twisti@1573 264 _methods(methods)
jrose@1161 265 {
jrose@1161 266 assert(_pool->cache() == NULL, "constant pool cache must not be set yet");
duke@435 267
duke@435 268 // determine index maps for methodOop rewriting
jrose@1161 269 compute_index_maps();
duke@435 270
jrose@1161 271 if (RegisterFinalizersAtInit && _klass->name() == vmSymbols::java_lang_Object()) {
jrose@1291 272 bool did_rewrite = false;
jrose@1161 273 int i = _methods->length();
duke@435 274 while (i-- > 0) {
jrose@1161 275 methodOop method = (methodOop)_methods->obj_at(i);
duke@435 276 if (method->intrinsic_id() == vmIntrinsics::_Object_init) {
duke@435 277 // rewrite the return bytecodes of Object.<init> to register the
duke@435 278 // object for finalization if needed.
duke@435 279 methodHandle m(THREAD, method);
duke@435 280 rewrite_Object_init(m, CHECK);
jrose@1291 281 did_rewrite = true;
duke@435 282 break;
duke@435 283 }
duke@435 284 }
jrose@1291 285 assert(did_rewrite, "must find Object::<init> to rewrite it");
duke@435 286 }
duke@435 287
jrose@1161 288 // rewrite methods, in two passes
jrose@1161 289 int i, len = _methods->length();
jrose@1161 290
jrose@1161 291 for (i = len; --i >= 0; ) {
jrose@1161 292 methodOop method = (methodOop)_methods->obj_at(i);
jrose@1161 293 scan_method(method);
jrose@1161 294 }
jrose@1161 295
jrose@1161 296 // allocate constant pool cache, now that we've seen all the bytecodes
jrose@1161 297 make_constant_pool_cache(CHECK);
jrose@1161 298
jrose@1161 299 for (i = len; --i >= 0; ) {
jrose@1161 300 methodHandle m(THREAD, (methodOop)_methods->obj_at(i));
jrose@1161 301
jrose@1161 302 if (m->has_jsrs()) {
jrose@1161 303 m = rewrite_jsrs(m, CHECK);
duke@435 304 // Method might have gotten rewritten.
jrose@1161 305 _methods->obj_at_put(i, m());
duke@435 306 }
jrose@1161 307
jrose@1161 308 // Set up method entry points for compiler and interpreter.
jrose@1161 309 m->link_method(m, CHECK);
jrose@1929 310
jrose@1929 311 #ifdef ASSERT
jrose@1929 312 if (StressMethodComparator) {
jrose@1929 313 static int nmc = 0;
jrose@1929 314 for (int j = i; j >= 0 && j >= i-4; j--) {
jrose@1929 315 if ((++nmc % 1000) == 0) tty->print_cr("Have run MethodComparator %d times...", nmc);
jrose@1929 316 bool z = MethodComparator::methods_EMCP(m(), (methodOop)_methods->obj_at(j));
jrose@1929 317 if (j == i && !z) {
jrose@1929 318 tty->print("MethodComparator FAIL: "); m->print(); m->print_codes();
jrose@1929 319 assert(z, "method must compare equal to itself");
jrose@1929 320 }
jrose@1929 321 }
jrose@1929 322 }
jrose@1929 323 #endif //ASSERT
duke@435 324 }
duke@435 325 }

mercurial