# HG changeset patch # User erikj # Date 1377850405 -7200 # Node ID 92facce22941c9421baca3fa2924b4e4bda647c4 # Parent 21198f51bc7e1087f74243d6f71aaea09d92dd96 8023957: Lock down version of autoconf Reviewed-by: chegar, dsamersoff, tbell, dholmes diff -r 21198f51bc7e -r 92facce22941 README-builds.html --- a/README-builds.html Thu Aug 29 15:47:55 2013 +0200 +++ b/README-builds.html Fri Aug 30 10:13:25 2013 +0200 @@ -1210,19 +1210,18 @@

- Q: The configure file looks horrible! + Q: The generated-configure.sh file looks horrible! How are you going to edit it?
- A: The configure file is generated (think + A: The generated-configure.sh file is generated (think "compiled") by the autoconf tools. The source code is - in configure.ac various .m4 files in common/autoconf, - which are - much more readable. + in configure.ac and various .m4 files in common/autoconf, + which are much more readable.

Q: - Why is the configure file checked in, + Why is the generated-configure.sh file checked in, if it is generated?
A: @@ -1237,13 +1236,29 @@

Q: Do you require a specific version of autoconf for regenerating - configure? + generated-configure.sh?
A: - Currently, no, but this will likely be the case when things have - settled down a bit more. (The reason for this is to avoid - large spurious changes in configure - in commits that made small changes to configure.ac). + Yes, version 2.69 is required and should be easy + enough to aquire on all supported operating + systems. The reason for this is to avoid + large spurious changes in generated-configure.sh. +

+ +

+ Q: + How do you regenerate generated-configure.sh + after making changes to the input files? +
+ A: + Regnerating generated-configure.sh + should always be done using the + script common/autoconf/autogen.sh to + ensure that the correct files get updated. This + script should also be run after mercurial tries to + merge generated-configure.sh as a + merge of the generated file is not guaranteed to + be correct.

diff -r 21198f51bc7e -r 92facce22941 common/autoconf/autogen.sh --- a/common/autoconf/autogen.sh Thu Aug 29 15:47:55 2013 +0200 +++ b/common/autoconf/autogen.sh Fri Aug 30 10:13:25 2013 +0200 @@ -44,10 +44,8 @@ custom_hook=$custom_script_dir/custom-hook.m4 AUTOCONF="`which autoconf 2> /dev/null | grep -v '^no autoconf in'`" -AUTOCONF_267="`which autoconf-2.67 2> /dev/null | grep -v '^no autoconf-2.67 in'`" echo "Autoconf found: ${AUTOCONF}" -echo "Autoconf-2.67 found: ${AUTOCONF_267}" if test "x${AUTOCONF}" = x; then echo You need autoconf installed to be able to regenerate the configure script @@ -55,10 +53,6 @@ exit 1 fi -if test "x${AUTOCONF_267}" != x; then - AUTOCONF=${AUTOCONF_267}; -fi - echo Generating generated-configure.sh with ${AUTOCONF} cat $script_dir/configure.ac | sed -e "s|@DATE_WHEN_GENERATED@|$TIMESTAMP|" | ${AUTOCONF} -W all -I$script_dir - > $script_dir/generated-configure.sh rm -rf autom4te.cache diff -r 21198f51bc7e -r 92facce22941 common/autoconf/configure.ac --- a/common/autoconf/configure.ac Thu Aug 29 15:47:55 2013 +0200 +++ b/common/autoconf/configure.ac Fri Aug 30 10:13:25 2013 +0200 @@ -30,7 +30,7 @@ ############################################################################### -AC_PREREQ([2.61]) +AC_PREREQ([2.69]) AC_INIT(OpenJDK, jdk8, build-dev@openjdk.java.net,,http://openjdk.java.net) AC_CONFIG_AUX_DIR([build-aux]) diff -r 21198f51bc7e -r 92facce22941 common/autoconf/generated-configure.sh --- a/common/autoconf/generated-configure.sh Thu Aug 29 15:47:55 2013 +0200 +++ b/common/autoconf/generated-configure.sh Fri Aug 30 10:13:25 2013 +0200 @@ -3818,7 +3818,7 @@ #CUSTOM_AUTOCONF_INCLUDE # Do not change or remove the following line, it is needed for consistency checks: -DATE_WHEN_GENERATED=1377784024 +DATE_WHEN_GENERATED=1377850299 ############################################################################### #