Thu, 19 Sep 2013 13:34:01 +0530
8025048: true as case label results in ClassCastException
Reviewed-by: lagergren
1.1 --- a/src/jdk/nashorn/internal/codegen/Attr.java Wed Sep 18 16:36:25 2013 +0530 1.2 +++ b/src/jdk/nashorn/internal/codegen/Attr.java Thu Sep 19 13:34:01 2013 +0530 1.3 @@ -807,9 +807,11 @@ 1.4 type = Type.OBJECT; 1.5 } 1.6 1.7 - type = Type.widest(type, newCaseNode.getTest().getType()); 1.8 - if (type.isBoolean()) { 1.9 + final Type newCaseType = newCaseNode.getTest().getType(); 1.10 + if (newCaseType.isBoolean()) { 1.11 type = Type.OBJECT; //booleans and integers aren't assignment compatible 1.12 + } else { 1.13 + type = Type.widest(type, newCaseType); 1.14 } 1.15 } 1.16
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/script/basic/JDK-8025048-2.js Thu Sep 19 13:34:01 2013 +0530 2.3 @@ -0,0 +1,36 @@ 2.4 +/* 2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 +/** 2.28 + * JDK-8025048: true as case label results in ClassCastException 2.29 + * 2.30 + * @test 2.31 + * @run 2.32 + */ 2.33 + 2.34 +function func(x) { 2.35 + switch(x) { 2.36 + case 8: break; case false: 2.37 + } 2.38 +} 2.39 +
3.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 3.2 +++ b/test/script/basic/JDK-8025048.js Thu Sep 19 13:34:01 2013 +0530 3.3 @@ -0,0 +1,36 @@ 3.4 +/* 3.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. 3.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 3.7 + * 3.8 + * This code is free software; you can redistribute it and/or modify it 3.9 + * under the terms of the GNU General Public License version 2 only, as 3.10 + * published by the Free Software Foundation. 3.11 + * 3.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 3.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 3.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 3.15 + * version 2 for more details (a copy is included in the LICENSE file that 3.16 + * accompanied this code). 3.17 + * 3.18 + * You should have received a copy of the GNU General Public License version 3.19 + * 2 along with this work; if not, write to the Free Software Foundation, 3.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 3.21 + * 3.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 3.23 + * or visit www.oracle.com if you need additional information or have any 3.24 + * questions. 3.25 + */ 3.26 + 3.27 +/** 3.28 + * JDK-8025048: true as case label results in ClassCastException 3.29 + * 3.30 + * @test 3.31 + * @run 3.32 + */ 3.33 + 3.34 +function func(x) { 3.35 + switch(x) { 3.36 + case 8: break; case true: 3.37 + } 3.38 +} 3.39 +