Thu, 20 Jun 2013 13:45:38 +0530
8017046: Cannot assign undefined to a function argument if the function uses arguments object
Reviewed-by: hannesw
src/jdk/nashorn/internal/objects/NativeArguments.java | file | annotate | diff | comparison | revisions | |
test/script/basic/JDK-8017046.js | file | annotate | diff | comparison | revisions |
1.1 --- a/src/jdk/nashorn/internal/objects/NativeArguments.java Wed Jun 19 21:07:59 2013 +0530 1.2 +++ b/src/jdk/nashorn/internal/objects/NativeArguments.java Thu Jun 20 13:45:38 2013 +0530 1.3 @@ -125,7 +125,7 @@ 1.4 @Override 1.5 public void setArgument(final int key, final Object value) { 1.6 if (namedArgs.has(key)) { 1.7 - namedArgs.set(key, value, false); 1.8 + namedArgs = namedArgs.set(key, value, false); 1.9 } 1.10 } 1.11
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/script/basic/JDK-8017046.js Thu Jun 20 13:45:38 2013 +0530 2.3 @@ -0,0 +1,46 @@ 2.4 +/* 2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 +/** 2.28 + * JDK-8017046: Cannot assign undefined to a function argument if the function uses arguments object 2.29 + * 2.30 + * @test 2.31 + * @run 2.32 + */ 2.33 + 2.34 +function assert(value, msg) { 2.35 + if (! value) { 2.36 + fail(msg); 2.37 + } 2.38 +} 2.39 + 2.40 +function func(a) { 2.41 + assert(a === arguments[0], "a !== arguments[0]"); 2.42 + assert(a === "hello", "a !== 'hello'"); 2.43 + a = undefined; 2.44 + assert(a === arguments[0], "a !== arguments[0]"); 2.45 + assert(a === undefined, "a !== undefined"); 2.46 + assert(typeof(a) === 'undefined', "typeof(a) is not 'undefined'"); 2.47 +} 2.48 + 2.49 +func("hello");