Thu, 05 Sep 2013 21:17:06 +0530
8024255: When a keyword is used as object property name, the property can not be deleted
Reviewed-by: jlaskey, lagergren
src/jdk/nashorn/internal/parser/Parser.java | file | annotate | diff | comparison | revisions | |
test/script/basic/JDK-8024255.js | file | annotate | diff | comparison | revisions |
1.1 --- a/src/jdk/nashorn/internal/parser/Parser.java Wed Sep 04 19:58:16 2013 +0530 1.2 +++ b/src/jdk/nashorn/internal/parser/Parser.java Thu Sep 05 21:17:06 2013 +0530 1.3 @@ -2060,7 +2060,7 @@ 1.4 case FLOATING: 1.5 return getLiteral(); 1.6 default: 1.7 - return getIdentifierName(); 1.8 + return getIdentifierName().setIsPropertyName(); 1.9 } 1.10 } 1.11
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/script/basic/JDK-8024255.js Thu Sep 05 21:17:06 2013 +0530 2.3 @@ -0,0 +1,51 @@ 2.4 +/* 2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 +/** 2.28 + * JDK-8024255: When a keyword is used as object property name, the property can not be deleted 2.29 + * 2.30 + * @test 2.31 + * @run 2.32 + */ 2.33 + 2.34 +function check(obj, name) { 2.35 + var desc = Object.getOwnPropertyDescriptor(obj, name); 2.36 + if (! desc.configurable) { 2.37 + fail("Property " + name + " is not configurable"); 2.38 + } 2.39 + 2.40 + if (! (delete obj[name])) { 2.41 + fail("Property " + name + " can not be deleted"); 2.42 + } 2.43 +} 2.44 + 2.45 +var obj = { 2.46 + default: 344, 2.47 + in: 'hello', 2.48 + if: false, 2.49 + class: 4.223 2.50 +} 2.51 + 2.52 +for (var p in obj) { 2.53 + check(obj, p); 2.54 +}