Tue, 12 Mar 2013 21:17:47 +0530
8009868: For loop with "true" as condition results in AssertionError in codegen
Reviewed-by: jlaskey, hannesw, lagergren
src/jdk/nashorn/internal/codegen/Lower.java | file | annotate | diff | comparison | revisions | |
test/script/basic/JDK-8009868.js | file | annotate | diff | comparison | revisions |
1.1 --- a/src/jdk/nashorn/internal/codegen/Lower.java Tue Mar 12 15:30:53 2013 +0100 1.2 +++ b/src/jdk/nashorn/internal/codegen/Lower.java Tue Mar 12 21:17:47 2013 +0530 1.3 @@ -237,6 +237,7 @@ 1.4 1.5 if (!forNode.isForIn() && conservativeAlwaysTrue(test)) { 1.6 forNode.setTest(null); 1.7 + setHasGoto(forNode); 1.8 setTerminal(forNode, !escapes); 1.9 } 1.10
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/script/basic/JDK-8009868.js Tue Mar 12 21:17:47 2013 +0530 2.3 @@ -0,0 +1,35 @@ 2.4 +/* 2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 + 2.28 +/** 2.29 + * JDK-8009868: For loop with "true" as condition results in AssertionError in codegen 2.30 + * 2.31 + * @test 2.32 + * @run 2.33 + */ 2.34 + 2.35 +// This used to crash with AssertionError in codegen 2.36 +for(; true;) { 2.37 + break; 2.38 +}