8009553: Object.create(Array.prototype) doesn't respect reset length

Wed, 06 Mar 2013 22:38:18 +0530

author
sundar
date
Wed, 06 Mar 2013 22:38:18 +0530
changeset 132
3d57f57acd9c
parent 131
fe5211fc3114
child 133
5759f600fcf7

8009553: Object.create(Array.prototype) doesn't respect reset length
Reviewed-by: jlaskey, lagergren

src/jdk/nashorn/internal/objects/Global.java file | annotate | diff | comparison | revisions
test/script/basic/JDK-8009553.js file | annotate | diff | comparison | revisions
     1.1 --- a/src/jdk/nashorn/internal/objects/Global.java	Mon Mar 04 11:01:26 2013 -0400
     1.2 +++ b/src/jdk/nashorn/internal/objects/Global.java	Wed Mar 06 22:38:18 2013 +0530
     1.3 @@ -1385,7 +1385,7 @@
     1.4  
     1.5          // add Array.prototype.length
     1.6          final ScriptObject arrayPrototype = getArrayPrototype();
     1.7 -        arrayPrototype.addOwnProperty("length", Attribute.NON_ENUMERABLE_CONSTANT, 0.0);
     1.8 +        arrayPrototype.addOwnProperty("length", Attribute.NOT_ENUMERABLE|Attribute.NOT_CONFIGURABLE, 0.0);
     1.9  
    1.10          this.DEFAULT_DATE = new NativeDate(Double.NaN);
    1.11  
     2.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     2.2 +++ b/test/script/basic/JDK-8009553.js	Wed Mar 06 22:38:18 2013 +0530
     2.3 @@ -0,0 +1,56 @@
     2.4 +/*
     2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
     2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.7 + * 
     2.8 + * This code is free software; you can redistribute it and/or modify it
     2.9 + * under the terms of the GNU General Public License version 2 only, as
    2.10 + * published by the Free Software Foundation.
    2.11 + * 
    2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT
    2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    2.14 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    2.15 + * version 2 for more details (a copy is included in the LICENSE file that
    2.16 + * accompanied this code).
    2.17 + * 
    2.18 + * You should have received a copy of the GNU General Public License version
    2.19 + * 2 along with this work; if not, write to the Free Software Foundation,
    2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    2.21 + * 
    2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    2.23 + * or visit www.oracle.com if you need additional information or have any
    2.24 + * questions.
    2.25 + */
    2.26 +
    2.27 +/**
    2.28 + * JDK-8009553: Object.create(Array.prototype) doesn't respect reset length
    2.29 + *
    2.30 + * @test
    2.31 + * @run
    2.32 + */
    2.33 +
    2.34 +var desc = Object.getOwnPropertyDescriptor(Array.prototype, "length");
    2.35 +if (! desc.writable) {
    2.36 +    fail("Array.prototype.length is not writable");
    2.37 +}
    2.38 +
    2.39 +if (desc.value != 0) {
    2.40 +    fail("Array.prototype.length != 0");
    2.41 +}
    2.42 +
    2.43 +var array = Object.create(Array.prototype);
    2.44 +if (array.hasOwnProperty("length")) {
    2.45 +    fail("array has 'length'");
    2.46 +}
    2.47 +
    2.48 +if (array.length != 0) {
    2.49 +    fail("array.length != 0");
    2.50 +}
    2.51 +
    2.52 +array.length = 4;
    2.53 +if (! array.hasOwnProperty("length")) {
    2.54 +    fail("array does not have 'length'");
    2.55 +}
    2.56 +
    2.57 +if (array.length != 4) {
    2.58 +    fail("array.length != 4");
    2.59 +}

mercurial