8024972: for (LeftHandSideExpression in Expression) crashes the compiler

Wed, 18 Sep 2013 13:06:17 +0530

author
sundar
date
Wed, 18 Sep 2013 13:06:17 +0530
changeset 559
1971c2d770ae
parent 555
f1fd5f0bc84c
child 560
a62172fe5bae

8024972: for (LeftHandSideExpression in Expression) crashes the compiler
Reviewed-by: lagergren, hannesw

src/jdk/nashorn/internal/codegen/CodeGenerator.java file | annotate | diff | comparison | revisions
test/script/basic/JDK-8024972.js file | annotate | diff | comparison | revisions
test/script/basic/JDK-8024972.js.EXPECTED file | annotate | diff | comparison | revisions
     1.1 --- a/src/jdk/nashorn/internal/codegen/CodeGenerator.java	Mon Sep 16 14:44:20 2013 +0200
     1.2 +++ b/src/jdk/nashorn/internal/codegen/CodeGenerator.java	Wed Sep 18 13:06:17 2013 +0530
     1.3 @@ -852,7 +852,6 @@
     1.4          final Label  loopLabel = new Label("loop");
     1.5  
     1.6          final Expression init = forNode.getInit();
     1.7 -        assert init instanceof IdentNode;
     1.8  
     1.9          load(modify);
    1.10          assert modify.getType().isObject();
     2.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     2.2 +++ b/test/script/basic/JDK-8024972.js	Wed Sep 18 13:06:17 2013 +0530
     2.3 @@ -0,0 +1,43 @@
     2.4 +/*
     2.5 + * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
     2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.7 + * 
     2.8 + * This code is free software; you can redistribute it and/or modify it
     2.9 + * under the terms of the GNU General Public License version 2 only, as
    2.10 + * published by the Free Software Foundation.
    2.11 + * 
    2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT
    2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    2.14 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    2.15 + * version 2 for more details (a copy is included in the LICENSE file that
    2.16 + * accompanied this code).
    2.17 + * 
    2.18 + * You should have received a copy of the GNU General Public License version
    2.19 + * 2 along with this work; if not, write to the Free Software Foundation,
    2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    2.21 + * 
    2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    2.23 + * or visit www.oracle.com if you need additional information or have any
    2.24 + * questions.
    2.25 + */
    2.26 +
    2.27 +/**
    2.28 + * JDK-8024972: for (LeftHandSideExpression in Expression) crashes the compiler
    2.29 + *
    2.30 + * @test
    2.31 + * @run
    2.32 + */
    2.33 +
    2.34 +var obj = {};
    2.35 +
    2.36 +var arr = [2, 45, -1, 445];
    2.37 +for (obj.x in arr) {
    2.38 +    print(obj.x + "->"+ arr[obj.x]);
    2.39 +}
    2.40 +
    2.41 +var abc = { foo: 'bar', hello: 'world' };
    2.42 +for (obj.x in abc) {
    2.43 +    print(obj.x + "->" + abc[obj.x]);
    2.44 +}
    2.45 +
    2.46 +for (obj.x in 0) {}
     3.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     3.2 +++ b/test/script/basic/JDK-8024972.js.EXPECTED	Wed Sep 18 13:06:17 2013 +0530
     3.3 @@ -0,0 +1,6 @@
     3.4 +0->2
     3.5 +1->45
     3.6 +2->-1
     3.7 +3->445
     3.8 +foo->bar
     3.9 +hello->world

mercurial