Fri, 05 Jun 2015 14:46:52 +0530
8081809: Missing final modifier in method parameters (nashorn code convention)
Reviewed-by: attila, lagergren
1.1 --- a/src/jdk/nashorn/internal/codegen/CompilationPhase.java Wed Jun 03 18:08:57 2015 +0200 1.2 +++ b/src/jdk/nashorn/internal/codegen/CompilationPhase.java Fri Jun 05 14:46:52 2015 +0530 1.3 @@ -363,7 +363,7 @@ 1.4 //partial code generation 1.5 final FunctionNode newFunctionNode = transformFunction(fn, new ReplaceCompileUnits() { 1.6 @Override 1.7 - CompileUnit getReplacement(CompileUnit original) { 1.8 + CompileUnit getReplacement(final CompileUnit original) { 1.9 return map.get(original); 1.10 } 1.11
2.1 --- a/src/jdk/nashorn/internal/codegen/SplitIntoFunctions.java Wed Jun 03 18:08:57 2015 +0200 2.2 +++ b/src/jdk/nashorn/internal/codegen/SplitIntoFunctions.java Fri Jun 05 14:46:52 2015 +0530 2.3 @@ -101,7 +101,7 @@ 2.4 public SplitIntoFunctions(final Compiler compiler) { 2.5 super(new BlockLexicalContext() { 2.6 @Override 2.7 - protected Block afterSetStatements(Block block) { 2.8 + protected Block afterSetStatements(final Block block) { 2.9 for(Statement stmt: block.getStatements()) { 2.10 assert !(stmt instanceof SplitNode); 2.11 } 2.12 @@ -301,7 +301,7 @@ 2.13 } 2.14 2.15 @Override 2.16 - public boolean enterVarNode(VarNode varNode) { 2.17 + public boolean enterVarNode(final VarNode varNode) { 2.18 if (!inSplitNode()) { 2.19 return super.enterVarNode(varNode); 2.20 }
3.1 --- a/src/jdk/nashorn/internal/ir/SplitReturn.java Wed Jun 03 18:08:57 2015 +0200 3.2 +++ b/src/jdk/nashorn/internal/ir/SplitReturn.java Fri Jun 05 14:46:52 2015 +0530 3.3 @@ -54,7 +54,7 @@ 3.4 } 3.5 3.6 @Override 3.7 - public void toString(StringBuilder sb, boolean printType) { 3.8 + public void toString(final StringBuilder sb, final boolean printType) { 3.9 sb.append(":splitreturn;"); 3.10 } 3.11
4.1 --- a/src/jdk/nashorn/internal/ir/TryNode.java Wed Jun 03 18:08:57 2015 +0200 4.2 +++ b/src/jdk/nashorn/internal/ir/TryNode.java Fri Jun 05 14:46:52 2015 +0530 4.3 @@ -122,7 +122,7 @@ 4.4 * @param visitor IR navigating visitor. 4.5 */ 4.6 @Override 4.7 - public Node accept(final LexicalContext lc, NodeVisitor<? extends LexicalContext> visitor) { 4.8 + public Node accept(final LexicalContext lc, final NodeVisitor<? extends LexicalContext> visitor) { 4.9 if (visitor.enterTryNode(this)) { 4.10 // Need to do finallybody first for termination analysis. TODO still necessary? 4.11 final Block newFinallyBody = finallyBody == null ? null : (Block)finallyBody.accept(visitor);
5.1 --- a/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java Wed Jun 03 18:08:57 2015 +0200 5.2 +++ b/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java Fri Jun 05 14:46:52 2015 +0530 5.3 @@ -246,7 +246,7 @@ 5.4 } 5.5 5.6 @Override 5.7 - public MethodHandle filterInternalObjects(MethodHandle target) { 5.8 + public MethodHandle filterInternalObjects(final MethodHandle target) { 5.9 return linkerServices.filterInternalObjects(target); 5.10 } 5.11 }