Mon, 14 Apr 2014 17:45:05 +0200
8030200: Wrong result for Number.prototype.toString() for certain radix/inputs
Reviewed-by: sundar, jlaskey, lagergren
1.1 --- a/src/jdk/nashorn/internal/runtime/JSType.java Mon Apr 14 17:43:38 2014 +0200 1.2 +++ b/src/jdk/nashorn/internal/runtime/JSType.java Mon Apr 14 17:45:05 2014 +0200 1.3 @@ -438,7 +438,9 @@ 1.4 1.5 // encode integer part from least significant digit, then reverse 1.6 do { 1.7 - sb.append(chars.charAt((int) (intPart % radix))); 1.8 + final double remainder = intPart % radix; 1.9 + sb.append(chars.charAt((int) remainder)); 1.10 + intPart -= remainder; 1.11 intPart /= radix; 1.12 } while (intPart >= 1.0); 1.13
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/script/basic/JDK-8030200.js Mon Apr 14 17:45:05 2014 +0200 2.3 @@ -0,0 +1,36 @@ 2.4 +/* 2.5 + * Copyright (c) 2010, 2014, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 +/** 2.28 + * JDK-8030200: Wrong result for Number.prototype.toString() for certain radix/inputs 2.29 + * 2.30 + * @test 2.31 + * @run 2.32 + */ 2.33 + 2.34 +var n = 0x8000000000000800; 2.35 +print(n); 2.36 +var s = n.toString(5); 2.37 +var m = parseInt(s, 5); 2.38 +print(m === n); 2.39 +print(n);
3.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 3.2 +++ b/test/script/basic/JDK-8030200.js.EXPECTED Mon Apr 14 17:45:05 2014 +0200 3.3 @@ -0,0 +1,3 @@ 3.4 +9223372036854778000 3.5 +true 3.6 +9223372036854778000
4.1 --- a/test/script/basic/NASHORN-173.js.EXPECTED Mon Apr 14 17:43:38 2014 +0200 4.2 +++ b/test/script/basic/NASHORN-173.js.EXPECTED Mon Apr 14 17:45:05 2014 +0200 4.3 @@ -132,7 +132,7 @@ 4.4 2.3423446609034533e+21 4.5 2.3423446609034533e+21 4.6 11111101111101010001111111010101101000101011011001001000000000000000000 4.7 -2224143002343343220233144213324 4.8 +2224143002343343220233044213324 4.9 375752177255053311000000 4.10 73b92b9962990aa44400 4.11 7efa8fead15b240000