# HG changeset patch # User sundar # Date 1410946362 -19800 # Node ID e83ceda86582100f2934d5ad2f1e703dd89f39a1 # Parent 432e074f1eace1caeabbd164443b77e565355bc2 8058615: Overload resolution ambiguity involving ConsString Reviewed-by: lagergren, hannesw diff -r 432e074f1eac -r e83ceda86582 src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java --- a/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java Tue Sep 16 14:15:47 2014 -0700 +++ b/src/jdk/nashorn/internal/runtime/linker/NashornBeansLinker.java Wed Sep 17 15:02:42 2014 +0530 @@ -125,6 +125,15 @@ @Override public Comparison compareConversion(final Class sourceType, final Class targetType1, final Class targetType2) { + if (sourceType == ConsString.class) { + if (String.class == targetType1 || CharSequence.class == targetType1) { + return Comparison.TYPE_1_BETTER; + } + + if (String.class == targetType2 || CharSequence.class == targetType2) { + return Comparison.TYPE_2_BETTER; + } + } return linkerServices.compareConversion(sourceType, targetType1, targetType2); } } diff -r 432e074f1eac -r e83ceda86582 test/script/basic/JDK-8058615.js --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/basic/JDK-8058615.js Wed Sep 17 15:02:42 2014 +0530 @@ -0,0 +1,36 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8058615: Overload resolution ambiguity involving ConsString + * + * @test + * @run + */ + +var strw = new java.io.StringWriter(); +var bufw = new java.io.BufferedWriter(strw); +var s = "hello "; +bufw.write(s + "world"); +bufw.close(); +print(strw.toString()); diff -r 432e074f1eac -r e83ceda86582 test/script/basic/JDK-8058615.js.EXPECTED --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/basic/JDK-8058615.js.EXPECTED Wed Sep 17 15:02:42 2014 +0530 @@ -0,0 +1,1 @@ +hello world