# HG changeset patch # User mhaupt # Date 1455008402 -3600 # Node ID 29603fdf59a857fbe179fdf59b7b6e29a8d1587e # Parent 1e1f65348706b3bf6cb64191ab840985faf49981 8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements Reviewed-by: jlaskey, sundar diff -r 1e1f65348706 -r 29603fdf59a8 src/jdk/nashorn/internal/runtime/arrays/ArrayData.java --- a/src/jdk/nashorn/internal/runtime/arrays/ArrayData.java Fri Feb 05 13:54:03 2016 +0000 +++ b/src/jdk/nashorn/internal/runtime/arrays/ArrayData.java Tue Feb 09 10:00:02 2016 +0100 @@ -81,14 +81,11 @@ } private ArrayData toRealArrayData() { - return toRealArrayData(0); + return new IntArrayData(0); } private ArrayData toRealArrayData(final int index) { final IntArrayData newData = new IntArrayData(index + 1); - if (index == 0) { - return newData; - } return new DeletedRangeArrayFilter(newData, 0, index); } @@ -122,7 +119,7 @@ @Override public ArrayData convert(final Class type) { - return toRealArrayData(0).convert(type); + return toRealArrayData().convert(type); } @Override diff -r 1e1f65348706 -r 29603fdf59a8 test/script/nosecurity/JDK-8149334.js --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/nosecurity/JDK-8149334.js Tue Feb 09 10:00:02 2016 +0100 @@ -0,0 +1,41 @@ +/* + * Copyright (c) 2016, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * JDK-8149334: JSON.parse(JSON.stringify([])).push(10) creates an array containing two elements + * + * @test + * @run + */ + +var a = JSON.parse(JSON.stringify([])) +print(a.length) +a.push(10) +print(a.length) +print(a) + +var b = JSON.parse(JSON.stringify([])) +print(b.length) +b.push('ieps') +print(b.length) +print(b) diff -r 1e1f65348706 -r 29603fdf59a8 test/script/nosecurity/JDK-8149334.js.EXPECTED --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/script/nosecurity/JDK-8149334.js.EXPECTED Tue Feb 09 10:00:02 2016 +0100 @@ -0,0 +1,6 @@ +0 +1 +10 +0 +1 +ieps