jlaskey@3: /* jlaskey@7: * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. jlaskey@3: * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. jlaskey@3: * jlaskey@3: * This code is free software; you can redistribute it and/or modify it jlaskey@3: * under the terms of the GNU General Public License version 2 only, as jlaskey@3: * published by the Free Software Foundation. jlaskey@3: * jlaskey@3: * This code is distributed in the hope that it will be useful, but WITHOUT jlaskey@3: * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or jlaskey@3: * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License jlaskey@3: * version 2 for more details (a copy is included in the LICENSE file that jlaskey@3: * accompanied this code). jlaskey@3: * jlaskey@3: * You should have received a copy of the GNU General Public License version jlaskey@3: * 2 along with this work; if not, write to the Free Software Foundation, jlaskey@3: * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. jlaskey@3: * jlaskey@3: * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA jlaskey@3: * or visit www.oracle.com if you need additional information or have any jlaskey@3: * questions. jlaskey@3: */ jlaskey@3: jlaskey@3: /** jlaskey@3: * NASHORN-111 : ClassCastException from JSON.stringify jlaskey@3: * jlaskey@3: * @test jlaskey@3: * @run jlaskey@3: */ jlaskey@3: // problem 1 jlaskey@3: // the conversions in TernaryNode are not necessary, but they should not cause problems. They did jlaskey@3: // this was because the result of Global.allocate(Object[])Object which returns a NativeObject. jlaskey@3: // was tracked as an object type on our stack. The type system did not recognize this as an array. jlaskey@3: // Then the explicit conversions became "convert NativeArray->Object[]" which is a checkccast Object[] jlaskey@3: // which naturally failed. jlaskey@3: jlaskey@3: // I pushed the appropriate arraytype on the stack for Global.allocate. jlaskey@3: jlaskey@3: // I also removed the conversions in CodeGen, all conversions should be done in Lower, as jlaskey@3: // NASHORN-706 states. jlaskey@3: jlaskey@3: var silent = false; jlaskey@3: var stdio = silent ? ['pipe', 'pipe', 'pipe', 'ipc'] : [0, 1, 2, 'ipc']; jlaskey@3: jlaskey@3: // This made the test pass, but it's still not correct to pick widest types for array jlaskey@3: // and primitives. Widest(Object[], int) gave us Object[] which makes no sense. This is used jlaskey@3: // by lower to type the conversions, so function b below also failed until I made a change jlaskey@3: // ty type widest to actually return the widest common denominator, if both aren't arrays jlaskey@3: jlaskey@3: function b() { jlaskey@3: var silent2 = false; jlaskey@3: var stdio2 = silent2 ? [1,2,3] : 17; jlaskey@3: } jlaskey@3: