• file
• revisions
• annotate
• diff
• comparison
• raw

test/script/basic/JDK-8006529-b.js@f7825c1a11d3 (annotated)

test/script/basic/JDK-8006529-b.js

Thu, 31 Jan 2013 18:34:42 +0100

author

attila

date

Thu, 31 Jan 2013 18:34:42 +0100

changeset 62

f7825c1a11d3

parent 0

b1a7da25b547

child 962

ac62e33a99b0

permissions

-rw-r--r--

8006529: Methods always get callee - it should be conditional
Summary: This commit streamlines the bytecode function signatures, prologue, local variable use, scope creation, and invocation. It started out quite innocently when we noticed that we always emit __callee__ parameters for all functions even when they are not needed, but it turned out to be quite a deep rabbit hole. In the end, I identified exact conditions when functions need to have a callee parameter, when they need to receive parent scope, when they need to create their own scope, when they need to have variable arity signature, and when they need to have an "arguments" object, and made sure that callee parameters in signatures only show up when they are needed, that parent function's scope is only passed to a child function when it is needed, that the function only creates its own scope when it is needed. In crypto.js, the number of scopes dropped from 446 to 244, and the number of callees dropped from 315 to 145.
Reviewed-by: jlaskey, lagergren

aoqi@0	1	/*
aoqi@0	2	* Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
aoqi@0	3	* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
aoqi@0	4	*
aoqi@0	5	* This code is free software; you can redistribute it and/or modify it
aoqi@0	6	* under the terms of the GNU General Public License version 2 only, as
aoqi@0	7	* published by the Free Software Foundation.
aoqi@0	8	*
aoqi@0	9	* This code is distributed in the hope that it will be useful, but WITHOUT
aoqi@0	10	* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
aoqi@0	11	* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
aoqi@0	12	* version 2 for more details (a copy is included in the LICENSE file that
aoqi@0	13	* accompanied this code).
aoqi@0	14	*
aoqi@0	15	* You should have received a copy of the GNU General Public License version
aoqi@0	16	* 2 along with this work; if not, write to the Free Software Foundation,
aoqi@0	17	* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
aoqi@0	18	*
aoqi@0	19	* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
aoqi@0	20	* or visit www.oracle.com if you need additional information or have any
aoqi@0	21	* questions.
aoqi@0	22	*/
aoqi@0	23
aoqi@0	24	/**
aoqi@0	25	* JDK-8006529 : Constructor functions that don't need callees must not get
aoqi@0	26	* linked with a MethodHandle boud to a specific function instance.
aoqi@0	27	* @test
aoqi@0	28	* @run
aoqi@0	29	*/
aoqi@0	30
aoqi@0	31	Object.defineProperty(Object.prototype, "extends", {
aoqi@0	32	value: function (superConstructor) {
aoqi@0	33	function ProtoBridge() { }
aoqi@0	34	ProtoBridge.prototype = superConstructor.prototype;
aoqi@0	35	this.prototype = new ProtoBridge();
aoqi@0	36	this.superConstructor = superConstructor;
aoqi@0	37	}
aoqi@0	38	});
aoqi@0	39
aoqi@0	40	function A() {
aoqi@0	41	}
aoqi@0	42	A.prototype.f = function () {
aoqi@0	43	this.g();
aoqi@0	44	}
aoqi@0	45
aoqi@0	46	function B() {
aoqi@0	47	B.superConstructor.call(this);
aoqi@0	48	this.f();
aoqi@0	49	}
aoqi@0	50	B.extends(A);
aoqi@0	51
aoqi@0	52	B.prototype.g = function () {
aoqi@0	53	print("It worked!")
aoqi@0	54	}
aoqi@0	55
aoqi@0	56	function C() {
aoqi@0	57	C.superConstructor.call(this);
aoqi@0	58	}
aoqi@0	59	C.extends(B);
aoqi@0	60
aoqi@0	61	var x = [B, C]
aoqi@0	62	for(var i in x) {
aoqi@0	63	print("Doing " + i)
aoqi@0	64	new x[i]()
aoqi@0	65	}