Wed, 18 Jun 2014 12:35:42 -0700
Added tag jdk8u20-b19 for changeset b047df215de4
jlaskey@3 | 1 | /* |
jlaskey@7 | 2 | * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved. |
jlaskey@3 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
jlaskey@3 | 4 | * |
jlaskey@3 | 5 | * This code is free software; you can redistribute it and/or modify it |
jlaskey@3 | 6 | * under the terms of the GNU General Public License version 2 only, as |
jlaskey@3 | 7 | * published by the Free Software Foundation. |
jlaskey@3 | 8 | * |
jlaskey@3 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
jlaskey@3 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
jlaskey@3 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
jlaskey@3 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
jlaskey@3 | 13 | * accompanied this code). |
jlaskey@3 | 14 | * |
jlaskey@3 | 15 | * You should have received a copy of the GNU General Public License version |
jlaskey@3 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
jlaskey@3 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
jlaskey@3 | 18 | * |
jlaskey@3 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
jlaskey@3 | 20 | * or visit www.oracle.com if you need additional information or have any |
jlaskey@3 | 21 | * questions. |
jlaskey@3 | 22 | */ |
jlaskey@3 | 23 | |
jlaskey@3 | 24 | /** |
jlaskey@3 | 25 | * NASHORN-111 : ClassCastException from JSON.stringify |
jlaskey@3 | 26 | * |
jlaskey@3 | 27 | * @test |
jlaskey@3 | 28 | * @run |
jlaskey@3 | 29 | */ |
jlaskey@3 | 30 | // problem 1 |
jlaskey@3 | 31 | // the conversions in TernaryNode are not necessary, but they should not cause problems. They did |
jlaskey@3 | 32 | // this was because the result of Global.allocate(Object[])Object which returns a NativeObject. |
jlaskey@3 | 33 | // was tracked as an object type on our stack. The type system did not recognize this as an array. |
jlaskey@3 | 34 | // Then the explicit conversions became "convert NativeArray->Object[]" which is a checkccast Object[] |
jlaskey@3 | 35 | // which naturally failed. |
jlaskey@3 | 36 | |
jlaskey@3 | 37 | // I pushed the appropriate arraytype on the stack for Global.allocate. |
jlaskey@3 | 38 | |
jlaskey@3 | 39 | // I also removed the conversions in CodeGen, all conversions should be done in Lower, as |
jlaskey@3 | 40 | // NASHORN-706 states. |
jlaskey@3 | 41 | |
jlaskey@3 | 42 | var silent = false; |
jlaskey@3 | 43 | var stdio = silent ? ['pipe', 'pipe', 'pipe', 'ipc'] : [0, 1, 2, 'ipc']; |
jlaskey@3 | 44 | |
jlaskey@3 | 45 | // This made the test pass, but it's still not correct to pick widest types for array |
jlaskey@3 | 46 | // and primitives. Widest(Object[], int) gave us Object[] which makes no sense. This is used |
jlaskey@3 | 47 | // by lower to type the conversions, so function b below also failed until I made a change |
jlaskey@3 | 48 | // ty type widest to actually return the widest common denominator, if both aren't arrays |
jlaskey@3 | 49 | |
jlaskey@3 | 50 | function b() { |
jlaskey@3 | 51 | var silent2 = false; |
jlaskey@3 | 52 | var stdio2 = silent2 ? [1,2,3] : 17; |
jlaskey@3 | 53 | } |
jlaskey@3 | 54 |