test/script/basic/NASHORN-760.js

Thu, 12 Oct 2017 19:52:15 +0800

author
aoqi
date
Thu, 12 Oct 2017 19:52:15 +0800
changeset 1205
4112748288bb
parent 962
ac62e33a99b0
parent 952
6d5471a497fb
permissions
-rw-r--r--

merge

aoqi@0 1 /*
aoqi@0 2 * Copyright (c) 2010, 2013, Oracle and/or its affiliates. All rights reserved.
aoqi@0 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
attila@962 4 *
aoqi@0 5 * This code is free software; you can redistribute it and/or modify it
aoqi@0 6 * under the terms of the GNU General Public License version 2 only, as
aoqi@0 7 * published by the Free Software Foundation.
attila@962 8 *
aoqi@0 9 * This code is distributed in the hope that it will be useful, but WITHOUT
aoqi@0 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
aoqi@0 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
aoqi@0 12 * version 2 for more details (a copy is included in the LICENSE file that
aoqi@0 13 * accompanied this code).
attila@962 14 *
aoqi@0 15 * You should have received a copy of the GNU General Public License version
aoqi@0 16 * 2 along with this work; if not, write to the Free Software Foundation,
aoqi@0 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
attila@962 18 *
aoqi@0 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
aoqi@0 20 * or visit www.oracle.com if you need additional information or have any
aoqi@0 21 * questions.
aoqi@0 22 */
aoqi@0 23
aoqi@0 24 /**
aoqi@0 25 * NASHORN-111 : ClassCastException from JSON.stringify
aoqi@0 26 *
aoqi@0 27 * @test
aoqi@0 28 * @run
aoqi@0 29 */
aoqi@0 30 // problem 1
aoqi@0 31 // the conversions in TernaryNode are not necessary, but they should not cause problems. They did
attila@962 32 // this was because the result of Global.allocate(Object[])Object which returns a NativeObject.
attila@962 33 // was tracked as an object type on our stack. The type system did not recognize this as an array.
aoqi@0 34 // Then the explicit conversions became "convert NativeArray->Object[]" which is a checkccast Object[]
aoqi@0 35 // which naturally failed.
aoqi@0 36
aoqi@0 37 // I pushed the appropriate arraytype on the stack for Global.allocate.
aoqi@0 38
aoqi@0 39 // I also removed the conversions in CodeGen, all conversions should be done in Lower, as
aoqi@0 40 // NASHORN-706 states.
aoqi@0 41
aoqi@0 42 var silent = false;
aoqi@0 43 var stdio = silent ? ['pipe', 'pipe', 'pipe', 'ipc'] : [0, 1, 2, 'ipc'];
aoqi@0 44
aoqi@0 45 // This made the test pass, but it's still not correct to pick widest types for array
aoqi@0 46 // and primitives. Widest(Object[], int) gave us Object[] which makes no sense. This is used
aoqi@0 47 // by lower to type the conversions, so function b below also failed until I made a change
aoqi@0 48 // ty type widest to actually return the widest common denominator, if both aren't arrays
aoqi@0 49
aoqi@0 50 function b() {
aoqi@0 51 var silent2 = false;
aoqi@0 52 var stdio2 = silent2 ? [1,2,3] : 17;
aoqi@0 53 }
aoqi@0 54

mercurial