8005183: Missing accessor for constructor reference pointing to private inner class ctor

Thu, 21 Feb 2013 15:23:48 +0000

author
mcimadamore
date
Thu, 21 Feb 2013 15:23:48 +0000
changeset 1597
f4fdd53f8b3e
parent 1596
3a39d123d33a
child 1598
7ac9242d2ca6

8005183: Missing accessor for constructor reference pointing to private inner class ctor
Summary: Compiler should add bridges when translating private constructor reference
Reviewed-by: jjg

src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java file | annotate | diff | comparison | revisions
test/tools/javac/lambda/MethodReference63.java file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java	Thu Feb 21 15:21:38 2013 +0000
     1.2 +++ b/src/share/classes/com/sun/tools/javac/comp/LambdaToMethod.java	Thu Feb 21 15:23:48 2013 +0000
     1.3 @@ -1702,12 +1702,17 @@
     1.4                  return tree.sym.owner == syms.arrayClass;
     1.5              }
     1.6  
     1.7 +            boolean isPrivateConstructor() {
     1.8 +                return tree.sym.name == names.init &&
     1.9 +                        (tree.sym.flags() & PRIVATE) != 0;
    1.10 +            }
    1.11 +
    1.12              /**
    1.13               * Does this reference needs a bridge (i.e. var args need to be
    1.14               * expanded or "super" is used)
    1.15               */
    1.16              final boolean needsBridge() {
    1.17 -                return isSuper || needsVarArgsConversion() || isArrayOp();
    1.18 +                return isSuper || needsVarArgsConversion() || isArrayOp() || isPrivateConstructor();
    1.19              }
    1.20  
    1.21              Type generatedRefSig() {
     2.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     2.2 +++ b/test/tools/javac/lambda/MethodReference63.java	Thu Feb 21 15:23:48 2013 +0000
     2.3 @@ -0,0 +1,43 @@
     2.4 +/*
     2.5 + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
     2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.7 + *
     2.8 + * This code is free software; you can redistribute it and/or modify it
     2.9 + * under the terms of the GNU General Public License version 2 only, as
    2.10 + * published by the Free Software Foundation.
    2.11 + *
    2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT
    2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    2.14 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    2.15 + * version 2 for more details (a copy is included in the LICENSE file that
    2.16 + * accompanied this code).
    2.17 + *
    2.18 + * You should have received a copy of the GNU General Public License version
    2.19 + * 2 along with this work; if not, write to the Free Software Foundation,
    2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    2.21 + *
    2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    2.23 + * or visit www.oracle.com if you need additional information or have any
    2.24 + * questions.
    2.25 + */
    2.26 +
    2.27 +/*
    2.28 + * @test
    2.29 + * @bug 8005183
    2.30 + * @summary Missing accessor for constructor reference pointing to private inner class ctor
    2.31 + */
    2.32 +public class MethodReference63 {
    2.33 +
    2.34 +    interface SAM {
    2.35 +        void m();
    2.36 +    }
    2.37 +
    2.38 +    static class Foo {
    2.39 +        private Foo() { }
    2.40 +    }
    2.41 +
    2.42 +    public static void main(String[] args) {
    2.43 +        SAM s = Foo::new;
    2.44 +        s.m();
    2.45 +    }
    2.46 +}

mercurial