Fri, 28 Jun 2013 14:36:06 +0100
8005552: c.s.t.javap.AttributeWriter.visitLocalVariableTable() uses incorrect format string
Reviewed-by: mcimadamore
src/share/classes/com/sun/tools/javap/AttributeWriter.java | file | annotate | diff | comparison | revisions |
1.1 --- a/src/share/classes/com/sun/tools/javap/AttributeWriter.java Fri Jun 28 13:20:44 2013 +0100 1.2 +++ b/src/share/classes/com/sun/tools/javap/AttributeWriter.java Fri Jun 28 14:36:06 2013 +0100 1.3 @@ -365,8 +365,7 @@ 1.4 indent(+1); 1.5 println("Start Length Slot Name Signature"); 1.6 for (LocalVariableTable_attribute.Entry entry : attr.local_variable_table) { 1.7 - Formatter formatter = new Formatter(); 1.8 - println(formatter.format("%8d %7d %5d %5s %s", 1.9 + println(String.format("%5d %7d %5d %5s %s", 1.10 entry.start_pc, entry.length, entry.index, 1.11 constantWriter.stringValue(entry.name_index), 1.12 constantWriter.stringValue(entry.descriptor_index))); 1.13 @@ -609,7 +608,8 @@ 1.14 public Void visit_append_frame(StackMapTable_attribute.append_frame frame, Void p) { 1.15 printHeader(frame); 1.16 println(" /* append */"); 1.17 - println(" offset_delta = " + frame.offset_delta); 1.18 + indent(+1); 1.19 + println("offset_delta = " + frame.offset_delta); 1.20 printMap("locals", frame.locals); 1.21 return null; 1.22 }