Fri, 01 Apr 2011 12:30:13 +0100
7032633: javac -Xlint:all warns about flush() within try on an auto-closeable resource
Summary: missing name check before calling MethodSymbol.overrides causes wrong warnings to be issued
Reviewed-by: jjg
src/share/classes/com/sun/tools/javac/comp/Attr.java | file | annotate | diff | comparison | revisions | |
test/tools/javac/TryWithResources/T7032633.java | file | annotate | diff | comparison | revisions |
1.1 --- a/src/share/classes/com/sun/tools/javac/comp/Attr.java Wed Mar 30 18:32:16 2011 -0700 1.2 +++ b/src/share/classes/com/sun/tools/javac/comp/Attr.java Fri Apr 01 12:30:13 2011 +0100 1.3 @@ -2289,6 +2289,7 @@ 1.4 sitesym.kind == VAR && 1.5 ((VarSymbol)sitesym).isResourceVariable() && 1.6 sym.kind == MTH && 1.7 + sym.name.equals(names.close) && 1.8 sym.overrides(syms.autoCloseableClose, sitesym.type.tsym, types, true) && 1.9 env.info.lint.isEnabled(LintCategory.TRY)) { 1.10 log.warning(LintCategory.TRY, tree, "try.explicit.close.call");
2.1 --- /dev/null Thu Jan 01 00:00:00 1970 +0000 2.2 +++ b/test/tools/javac/TryWithResources/T7032633.java Fri Apr 01 12:30:13 2011 +0100 2.3 @@ -0,0 +1,40 @@ 2.4 +/* 2.5 + * Copyright (c) 2011, Oracle and/or its affiliates. All rights reserved. 2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. 2.7 + * 2.8 + * This code is free software; you can redistribute it and/or modify it 2.9 + * under the terms of the GNU General Public License version 2 only, as 2.10 + * published by the Free Software Foundation. 2.11 + * 2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT 2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or 2.14 + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License 2.15 + * version 2 for more details (a copy is included in the LICENSE file that 2.16 + * accompanied this code). 2.17 + * 2.18 + * You should have received a copy of the GNU General Public License version 2.19 + * 2 along with this work; if not, write to the Free Software Foundation, 2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. 2.21 + * 2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA 2.23 + * or visit www.oracle.com if you need additional information or have any 2.24 + * questions. 2.25 + */ 2.26 + 2.27 +/* 2.28 + * @test 2.29 + * @bug 7032633 2.30 + * @summary javac -Xlint:all warns about flush() within try on an auto-closeable resource 2.31 + * @compile -Xlint:try -Werror T7032633.java 2.32 + */ 2.33 + 2.34 +import java.io.IOException; 2.35 +import java.io.OutputStream; 2.36 + 2.37 +public class T7032633 { 2.38 + void test() throws IOException { 2.39 + try (OutputStream out = System.out) { 2.40 + out.flush(); 2.41 + } 2.42 + } 2.43 +}