7071377: Exception when javac -processor is given a class name with invalid postfix

Mon, 19 Aug 2013 07:47:10 -0700

author
ksrini
date
Mon, 19 Aug 2013 07:47:10 -0700
changeset 1958
389eaf6ed973
parent 1957
4300c2f5fb1b
child 1959
55da6b3a6940

7071377: Exception when javac -processor is given a class name with invalid postfix
Reviewed-by: jjg, vromero

src/share/classes/com/sun/tools/javac/comp/Attr.java file | annotate | diff | comparison | revisions
test/tools/javac/processing/errors/TestClassNames.java file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/classes/com/sun/tools/javac/comp/Attr.java	Fri Aug 16 16:00:12 2013 +0200
     1.2 +++ b/src/share/classes/com/sun/tools/javac/comp/Attr.java	Mon Aug 19 07:47:10 2013 -0700
     1.3 @@ -398,7 +398,7 @@
     1.4              @Override
     1.5              public Symbol visitMemberSelect(MemberSelectTree node, Env<AttrContext> env) {
     1.6                  Symbol site = visit(node.getExpression(), env);
     1.7 -                if (site.kind == ERR)
     1.8 +                if (site.kind == ERR || site.kind == ABSENT_TYP)
     1.9                      return site;
    1.10                  Name name = (Name)node.getIdentifier();
    1.11                  if (site.kind == PCK) {
     2.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     2.2 +++ b/test/tools/javac/processing/errors/TestClassNames.java	Mon Aug 19 07:47:10 2013 -0700
     2.3 @@ -0,0 +1,47 @@
     2.4 +/*
     2.5 + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved.
     2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.7 + *
     2.8 + * This code is free software; you can redistribute it and/or modify it
     2.9 + * under the terms of the GNU General Public License version 2 only, as
    2.10 + * published by the Free Software Foundation.
    2.11 + *
    2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT
    2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    2.14 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    2.15 + * version 2 for more details (a copy is included in the LICENSE file that
    2.16 + * accompanied this code).
    2.17 + *
    2.18 + * You should have received a copy of the GNU General Public License version
    2.19 + * 2 along with this work; if not, write to the Free Software Foundation,
    2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    2.21 + *
    2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    2.23 + * or visit www.oracle.com if you need additional information or have any
    2.24 + * questions.
    2.25 + */
    2.26 +
    2.27 +/*
    2.28 + * @test
    2.29 + * @bug 7071377
    2.30 + * @summary verify if erroneous class names are rejected
    2.31 + * @library /tools/javac/lib
    2.32 + * @build TestClassNames JavacTestingAbstractProcessor CompileFail
    2.33 + * @run main CompileFail ERROR  -processor TestClassNames TestClassNames.x.y
    2.34 + * @run main CompileFail ERROR  -processor TestClassNames x.y.TestClassNames
    2.35 + * @run main CompileFail ERROR  -processor NoClass NoClass.x.y
    2.36 + */
    2.37 +
    2.38 +import java.util.Set;
    2.39 +import javax.annotation.processing.*;
    2.40 +import javax.lang.model.element.*;
    2.41 +
    2.42 +/**
    2.43 + * No-op processor; should not be run.
    2.44 + */
    2.45 +public class TestClassNames extends JavacTestingAbstractProcessor {
    2.46 +    public boolean process(Set<? extends TypeElement> annotations,
    2.47 +                           RoundEnvironment roundEnvironment) {
    2.48 +        return true;
    2.49 +    }
    2.50 +}

mercurial