# HG changeset patch # User vromero # Date 1415059417 28800 # Node ID 8dcde670aed33a318635699a59ef0d8ff2318fdd # Parent 88ce114c6adc387dc7fc5831b8263f152f0412fb 8057800: Method reference with generic type creates NPE when compiling Reviewed-by: mcimadamore diff -r 88ce114c6adc -r 8dcde670aed3 src/share/classes/com/sun/tools/javac/code/Types.java --- a/src/share/classes/com/sun/tools/javac/code/Types.java Fri Oct 31 20:19:04 2014 -0700 +++ b/src/share/classes/com/sun/tools/javac/code/Types.java Mon Nov 03 16:03:37 2014 -0800 @@ -3624,7 +3624,8 @@ for (Type erasedSupertype : mec) { List lci = List.of(asSuper(ts[startIdx], erasedSupertype.tsym)); for (int i = startIdx + 1 ; i < ts.length ; i++) { - lci = intersect(lci, List.of(asSuper(ts[i], erasedSupertype.tsym))); + Type superType = asSuper(ts[i], erasedSupertype.tsym); + lci = intersect(lci, superType != null ? List.of(superType) : List.nil()); } candidates = candidates.appendList(lci); } diff -r 88ce114c6adc -r 8dcde670aed3 src/share/classes/com/sun/tools/javac/comp/Infer.java --- a/src/share/classes/com/sun/tools/javac/comp/Infer.java Fri Oct 31 20:19:04 2014 -0700 +++ b/src/share/classes/com/sun/tools/javac/comp/Infer.java Mon Nov 03 16:03:37 2014 -0800 @@ -784,7 +784,10 @@ while (tmpTail.nonEmpty()) { Type b1 = boundList.head; Type b2 = tmpTail.head; - if (b1 != b2) { + /* This wildcard check is temporary workaround. This code may need to be + * revisited once spec bug JDK-7034922 is fixed. + */ + if (b1 != b2 && !b1.hasTag(WILDCARD) && !b2.hasTag(WILDCARD)) { Pair commonSupers = infer.getParameterizedSupers(b1, b2); if (commonSupers != null) { List allParamsSuperBound1 = commonSupers.fst.allparams(); diff -r 88ce114c6adc -r 8dcde670aed3 test/tools/javac/lambda/T8057800/NPEMethodReferenceAndGenericsTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/lambda/T8057800/NPEMethodReferenceAndGenericsTest.java Mon Nov 03 16:03:37 2014 -0800 @@ -0,0 +1,39 @@ +/* + * Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. Oracle designates this + * particular file as subject to the "Classpath" exception as provided + * by Oracle in the LICENSE file that accompanied this code. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/** + * @test + * @bug 8057800 + * @summary Method reference with generic type creates NPE when compiling + * @compile NPEMethodReferenceAndGenericsTest.java + */ + +public class NPEMethodReferenceAndGenericsTest { + public void foo(java.util.Comparator comparator) {} + + public > void foo() { + foo(C::compareTo); + } +}