# HG changeset patch # User emc # Date 1374626574 14400 # Node ID 558fe98d1ac011f3e2ed947c6f57dcd966ac3d4b # Parent 12975101806104bef5ff9b984384e07314e03b92 8016880: 42 tests in annot102* fail with compile-time errors. Summary: Fixes error in type equality when bounds of type variables have annotations. Reviewed-by: jjg, mcimadamore diff -r 129751018061 -r 558fe98d1ac0 src/share/classes/com/sun/tools/javac/code/Types.java --- a/src/share/classes/com/sun/tools/javac/code/Types.java Tue Jul 23 16:06:11 2013 -0700 +++ b/src/share/classes/com/sun/tools/javac/code/Types.java Tue Jul 23 20:42:54 2013 -0400 @@ -134,7 +134,7 @@ * @return the upper bound of the given type */ public Type upperBound(Type t) { - return upperBound.visit(t); + return upperBound.visit(t).unannotatedType(); } // where private final MapVisitor upperBound = new MapVisitor() { @@ -1130,9 +1130,9 @@ HashSet set = new HashSet(); for (Type x : interfaces(t)) - set.add(new UniqueType(x, Types.this)); + set.add(new UniqueType(x.unannotatedType(), Types.this)); for (Type x : interfaces(s)) { - if (!set.remove(new UniqueType(x, Types.this))) + if (!set.remove(new UniqueType(x.unannotatedType(), Types.this))) return false; } return (set.isEmpty()); diff -r 129751018061 -r 558fe98d1ac0 test/tools/javac/annotations/typeAnnotations/ErasureTest.java --- /dev/null Thu Jan 01 00:00:00 1970 +0000 +++ b/test/tools/javac/annotations/typeAnnotations/ErasureTest.java Tue Jul 23 20:42:54 2013 -0400 @@ -0,0 +1,51 @@ +/* + * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. + * + * This code is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License version 2 only, as + * published by the Free Software Foundation. + * + * This code is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License + * version 2 for more details (a copy is included in the LICENSE file that + * accompanied this code). + * + * You should have received a copy of the GNU General Public License version + * 2 along with this work; if not, write to the Free Software Foundation, + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. + * + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA + * or visit www.oracle.com if you need additional information or have any + * questions. + */ + +/* + * @test + * @bug 8016013 + * @summary Compiler incorrectly treats annotated and unannotated type variable bounds as different types + * @compile -doe ErasureTest.java + */ + +import java.lang.annotation.ElementType; +import java.lang.annotation.Target; + +@Target({ElementType.TYPE_USE, ElementType.TYPE_PARAMETER }) +@interface Advanced {} + +class U {} +interface I {} + +class ErasureTest { + void TestMethod(T arg1) { } + public static void main(String argv[]) { + ErasureTest t1 = new ErasureTest(){ + public void TestMethod(T arg1) { } + }; + + ErasureTest t2 = new ErasureTest(){ + public void TestMethod(T arg1) { } + }; + } +}