Tue, 14 May 2013 11:11:09 -0700
8012556: Implement lambda methods on interfaces as static
8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface
Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore.
Reviewed-by: mcimadamore
1 /*
2 * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation. Oracle designates this
8 * particular file as subject to the "Classpath" exception as provided
9 * by Oracle in the LICENSE file that accompanied this code.
10 *
11 * This code is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14 * version 2 for more details (a copy is included in the LICENSE file that
15 * accompanied this code).
16 *
17 * You should have received a copy of the GNU General Public License version
18 * 2 along with this work; if not, write to the Free Software Foundation,
19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20 *
21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22 * or visit www.oracle.com if you need additional information or have any
23 * questions.
24 */
26 /**
27 * @test
28 * @bug 8003639
29 * @summary convert lambda testng tests to jtreg and add them
30 * @run testng MethodReferenceTestVarArgsThis
31 */
33 import org.testng.annotations.Test;
34 import java.lang.reflect.Array;
36 import static org.testng.Assert.assertEquals;
38 /**
39 * @author Robert Field
40 */
42 interface NsII { String m(Integer a, Integer b); }
44 interface Nsiii { String m(int a, int b, int c); }
46 interface Nsi { String m(int a); }
48 interface NsaO { String m(Object[] a); }
50 interface Nsai { String m(int[] a); }
52 interface Nsvi { String m(int... va); }
54 @Test
55 public class MethodReferenceTestVarArgsThis {
57 // These should be processed as var args
59 String xvI(Integer... vi) {
60 StringBuilder sb = new StringBuilder("xvI:");
61 for (Integer i : vi) {
62 sb.append(i);
63 sb.append("-");
64 }
65 return sb.toString();
66 }
68 String xIvI(Integer f, Integer... vi) {
69 StringBuilder sb = new StringBuilder("xIvI:");
70 sb.append(f);
71 for (Integer i : vi) {
72 sb.append(i);
73 sb.append("-");
74 }
75 return sb.toString();
76 }
78 String xvi(int... vi) {
79 int sum = 0;
80 for (int i : vi) {
81 sum += i;
82 }
83 return "xvi:" + sum;
84 }
86 String xIvi(Integer f, int... vi) {
87 int sum = 0;
88 for (int i : vi) {
89 sum += i;
90 }
91 return "xIvi:(" + f + ")" + sum;
92 }
94 String xvO(Object... vi) {
95 StringBuilder sb = new StringBuilder("xvO:");
96 for (Object i : vi) {
97 if (i.getClass().isArray()) {
98 sb.append("[");
99 int len = Array.getLength(i);
100 for (int x = 0; x < len; ++x) {
101 sb.append(Array.get(i, x));
102 sb.append(",");
103 }
104 sb.append("]");
106 } else {
107 sb.append(i);
108 }
109 sb.append("*");
110 }
111 return sb.toString();
112 }
114 public void testVarArgsNsSuperclass() {
115 NsII q;
117 q = this::xvO;
118 assertEquals(q.m(55,66), "xvO:55*66*");
119 }
121 public void testVarArgsNsArray() {
122 Nsai q;
124 q = this::xvO;
125 assertEquals(q.m(new int[] { 55,66 } ), "xvO:[55,66,]*");
126 }
128 public void testVarArgsNsII() {
129 NsII q;
131 q = this::xvI;
132 assertEquals(q.m(33,7), "xvI:33-7-");
134 q = this::xIvI;
135 assertEquals(q.m(50,40), "xIvI:5040-");
137 q = this::xvi;
138 assertEquals(q.m(100,23), "xvi:123");
140 q = this::xIvi;
141 assertEquals(q.m(9,21), "xIvi:(9)21");
142 }
144 public void testVarArgsNsiii() {
145 Nsiii q;
147 q = this::xvI;
148 assertEquals(q.m(3, 2, 1), "xvI:3-2-1-");
150 q = this::xIvI;
151 assertEquals(q.m(888, 99, 2), "xIvI:88899-2-");
153 q = this::xvi;
154 assertEquals(q.m(900,80,7), "xvi:987");
156 q = this::xIvi;
157 assertEquals(q.m(333,27, 72), "xIvi:(333)99");
158 }
160 public void testVarArgsNsi() {
161 Nsi q;
163 q = this::xvI;
164 assertEquals(q.m(3), "xvI:3-");
166 q = this::xIvI;
167 assertEquals(q.m(888), "xIvI:888");
169 q = this::xvi;
170 assertEquals(q.m(900), "xvi:900");
172 q = this::xIvi;
173 assertEquals(q.m(333), "xIvi:(333)0");
174 }
176 // These should NOT be processed as var args
178 public void testVarArgsNsaO() {
179 NsaO q;
181 q = this::xvO;
182 assertEquals(q.m(new String[] { "yo", "there", "dude" }), "xvO:yo*there*dude*");
183 }
186 }