Tue, 14 May 2013 11:11:09 -0700
8012556: Implement lambda methods on interfaces as static
8006140: Javac NPE compiling Lambda expression on initialization expression of static field in interface
Summary: Lambdas occurring in static contexts or those not needing instance information should be generated into static methods. This has long been the case for classes. However, as a work-around to the lack of support for statics on interfaces, interface lambda methods have been generated into default methods. For lambdas in interface static contexts (fields and static methods) this causes an NPE in javac because there is no 'this'. MethodHandles now support static methods on interfaces. This changeset allows lambda methods to be generated as static interface methods. An existing bug in Hotspot (8013875) is exposed in a test when the "-esa" flag is used. This test and another test that already exposed this bug have been marked with @ignore.
Reviewed-by: mcimadamore
1 /*
2 * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation. Oracle designates this
8 * particular file as subject to the "Classpath" exception as provided
9 * by Oracle in the LICENSE file that accompanied this code.
10 *
11 * This code is distributed in the hope that it will be useful, but WITHOUT
12 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
13 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
14 * version 2 for more details (a copy is included in the LICENSE file that
15 * accompanied this code).
16 *
17 * You should have received a copy of the GNU General Public License version
18 * 2 along with this work; if not, write to the Free Software Foundation,
19 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
20 *
21 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
22 * or visit www.oracle.com if you need additional information or have any
23 * questions.
24 */
26 /**
27 * @test
28 * @bug 8003639
29 * @summary convert lambda testng tests to jtreg and add them
30 * @run testng MethodReferenceTestVarArgsExt
31 */
33 import org.testng.annotations.Test;
34 import java.lang.reflect.Array;
36 import static org.testng.Assert.assertEquals;
38 /**
39 * @author Robert Field
40 */
42 interface NXII { String m(Integer a, Integer b); }
44 interface NXiii { String m(int a, int b, int c); }
46 interface NXi { String m(int a); }
48 interface NXaO { String m(Object[] a); }
50 interface NXai { String m(int[] a); }
52 interface NXvi { String m(int... va); }
54 @Test
55 public class MethodReferenceTestVarArgsExt {
57 // These should be processed as var args
59 public void testVarArgsNXSuperclass() {
60 NXII q;
62 q = (new Ext())::xvO;
63 assertEquals(q.m(55,66), "xvO:55*66*");
64 }
66 public void testVarArgsNXArray() {
67 NXai q;
69 q = (new Ext())::xvO;
70 assertEquals(q.m(new int[] { 55,66 } ), "xvO:[55,66,]*");
71 }
73 public void testVarArgsNXII() {
74 NXII q;
76 q = (new Ext())::xvI;
77 assertEquals(q.m(33,7), "xvI:33-7-");
79 q = (new Ext())::xIvI;
80 assertEquals(q.m(50,40), "xIvI:5040-");
82 q = (new Ext())::xvi;
83 assertEquals(q.m(100,23), "xvi:123");
85 q = (new Ext())::xIvi;
86 assertEquals(q.m(9,21), "xIvi:(9)21");
87 }
89 public void testVarArgsNXiii() {
90 NXiii q;
92 q = (new Ext())::xvI;
93 assertEquals(q.m(3, 2, 1), "xvI:3-2-1-");
95 q = (new Ext())::xIvI;
96 assertEquals(q.m(888, 99, 2), "xIvI:88899-2-");
98 q = (new Ext())::xvi;
99 assertEquals(q.m(900,80,7), "xvi:987");
101 q = (new Ext())::xIvi;
102 assertEquals(q.m(333,27, 72), "xIvi:(333)99");
103 }
105 public void testVarArgsNXi() {
106 NXi q;
108 q = (new Ext())::xvI;
109 assertEquals(q.m(3), "xvI:3-");
111 q = (new Ext())::xIvI;
112 assertEquals(q.m(888), "xIvI:888");
114 q = (new Ext())::xvi;
115 assertEquals(q.m(900), "xvi:900");
117 q = (new Ext())::xIvi;
118 assertEquals(q.m(333), "xIvi:(333)0");
119 }
121 // These should NOT be processed as var args
123 public void testVarArgsNXaO() {
124 NXaO q;
126 q = (new Ext())::xvO;
127 assertEquals(q.m(new String[] { "yo", "there", "dude" }), "xvO:yo*there*dude*");
128 }
131 }
133 class Ext {
135 String xvI(Integer... vi) {
136 StringBuilder sb = new StringBuilder("xvI:");
137 for (Integer i : vi) {
138 sb.append(i);
139 sb.append("-");
140 }
141 return sb.toString();
142 }
144 String xIvI(Integer f, Integer... vi) {
145 StringBuilder sb = new StringBuilder("xIvI:");
146 sb.append(f);
147 for (Integer i : vi) {
148 sb.append(i);
149 sb.append("-");
150 }
151 return sb.toString();
152 }
154 String xvi(int... vi) {
155 int sum = 0;
156 for (int i : vi) {
157 sum += i;
158 }
159 return "xvi:" + sum;
160 }
162 String xIvi(Integer f, int... vi) {
163 int sum = 0;
164 for (int i : vi) {
165 sum += i;
166 }
167 return "xIvi:(" + f + ")" + sum;
168 }
170 String xvO(Object... vi) {
171 StringBuilder sb = new StringBuilder("xvO:");
172 for (Object i : vi) {
173 if (i.getClass().isArray()) {
174 sb.append("[");
175 int len = Array.getLength(i);
176 for (int x = 0; x < len; ++x) {
177 sb.append(Array.get(i, x));
178 sb.append(",");
179 }
180 sb.append("]");
182 } else {
183 sb.append(i);
184 }
185 sb.append("*");
186 }
187 return sb.toString();
188 }
191 }