Sat, 22 Dec 2018 13:10:38 -0800
Added tag jdk8u202-b25 for changeset 15d8c732039b
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. Oracle designates this |
aoqi@0 | 8 | * particular file as subject to the "Classpath" exception as provided |
aoqi@0 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
aoqi@0 | 10 | * |
aoqi@0 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 15 | * accompanied this code). |
aoqi@0 | 16 | * |
aoqi@0 | 17 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 20 | * |
aoqi@0 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 22 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 23 | * questions. |
aoqi@0 | 24 | */ |
aoqi@0 | 25 | |
aoqi@0 | 26 | /* |
aoqi@0 | 27 | * @test |
aoqi@0 | 28 | * @bug 8005931 |
aoqi@0 | 29 | * @summary javac doesn't set ACC_STRICT for classes with package access |
aoqi@0 | 30 | * @run main CheckACC_STRICTFlagOnPkgAccessClassTest |
aoqi@0 | 31 | */ |
aoqi@0 | 32 | |
aoqi@0 | 33 | import java.io.File; |
aoqi@0 | 34 | import java.io.IOException; |
aoqi@0 | 35 | import java.net.URI; |
aoqi@0 | 36 | import java.util.ArrayList; |
aoqi@0 | 37 | import java.util.Arrays; |
aoqi@0 | 38 | import java.util.List; |
aoqi@0 | 39 | import javax.tools.JavaCompiler; |
aoqi@0 | 40 | import javax.tools.JavaFileObject; |
aoqi@0 | 41 | import javax.tools.SimpleJavaFileObject; |
aoqi@0 | 42 | import javax.tools.ToolProvider; |
aoqi@0 | 43 | import com.sun.source.util.JavacTask; |
aoqi@0 | 44 | import com.sun.tools.classfile.ClassFile; |
aoqi@0 | 45 | import com.sun.tools.classfile.ConstantPoolException; |
aoqi@0 | 46 | import com.sun.tools.classfile.Descriptor; |
aoqi@0 | 47 | import com.sun.tools.classfile.Descriptor.InvalidDescriptor; |
aoqi@0 | 48 | import com.sun.tools.classfile.Method; |
aoqi@0 | 49 | |
aoqi@0 | 50 | import static com.sun.tools.classfile.AccessFlags.ACC_STRICT; |
aoqi@0 | 51 | |
aoqi@0 | 52 | public class CheckACC_STRICTFlagOnPkgAccessClassTest { |
aoqi@0 | 53 | |
aoqi@0 | 54 | private static final String AssertionErrorMessage = |
aoqi@0 | 55 | "All methods should have the ACC_STRICT access flag " + |
aoqi@0 | 56 | "please check output"; |
aoqi@0 | 57 | private static final String CompilationErrorMessage = |
aoqi@0 | 58 | "Error thrown when compiling the following source:\n"; |
aoqi@0 | 59 | private static final String offendingMethodErrorMessage = |
aoqi@0 | 60 | "Method %s of class %s doesn't have the ACC_STRICT access flag"; |
aoqi@0 | 61 | |
aoqi@0 | 62 | JavaSource source = new JavaSource(); |
aoqi@0 | 63 | |
aoqi@0 | 64 | private List<String> errors = new ArrayList<>(); |
aoqi@0 | 65 | |
aoqi@0 | 66 | public static void main(String[] args) |
aoqi@0 | 67 | throws IOException, ConstantPoolException, InvalidDescriptor { |
aoqi@0 | 68 | JavaCompiler comp = ToolProvider.getSystemJavaCompiler(); |
aoqi@0 | 69 | new CheckACC_STRICTFlagOnPkgAccessClassTest().run(comp); |
aoqi@0 | 70 | } |
aoqi@0 | 71 | |
aoqi@0 | 72 | private void run(JavaCompiler comp) |
aoqi@0 | 73 | throws IOException, ConstantPoolException, InvalidDescriptor { |
aoqi@0 | 74 | compile(comp); |
aoqi@0 | 75 | check(); |
aoqi@0 | 76 | if (errors.size() > 0) { |
aoqi@0 | 77 | for (String error: errors) { |
aoqi@0 | 78 | System.err.println(error); |
aoqi@0 | 79 | } |
aoqi@0 | 80 | throw new AssertionError(AssertionErrorMessage); |
aoqi@0 | 81 | } |
aoqi@0 | 82 | } |
aoqi@0 | 83 | |
aoqi@0 | 84 | private void compile(JavaCompiler comp) { |
aoqi@0 | 85 | JavacTask ct = (JavacTask)comp.getTask(null, null, null, null, null, |
aoqi@0 | 86 | Arrays.asList(source)); |
aoqi@0 | 87 | try { |
aoqi@0 | 88 | if (!ct.call()) { |
aoqi@0 | 89 | throw new AssertionError(CompilationErrorMessage + |
aoqi@0 | 90 | source.getCharContent(true)); |
aoqi@0 | 91 | } |
aoqi@0 | 92 | } catch (Throwable ex) { |
aoqi@0 | 93 | throw new AssertionError(CompilationErrorMessage + |
aoqi@0 | 94 | source.getCharContent(true)); |
aoqi@0 | 95 | } |
aoqi@0 | 96 | } |
aoqi@0 | 97 | |
aoqi@0 | 98 | void check() |
aoqi@0 | 99 | throws |
aoqi@0 | 100 | IOException, |
aoqi@0 | 101 | ConstantPoolException, |
aoqi@0 | 102 | Descriptor.InvalidDescriptor { |
aoqi@0 | 103 | ClassFile classFileToCheck = ClassFile.read(new File("Test.class")); |
aoqi@0 | 104 | |
aoqi@0 | 105 | for (Method method : classFileToCheck.methods) { |
aoqi@0 | 106 | if ((method.access_flags.flags & ACC_STRICT) == 0) { |
aoqi@0 | 107 | errors.add(String.format(offendingMethodErrorMessage, |
aoqi@0 | 108 | method.getName(classFileToCheck.constant_pool), |
aoqi@0 | 109 | classFileToCheck.getName())); |
aoqi@0 | 110 | } |
aoqi@0 | 111 | } |
aoqi@0 | 112 | } |
aoqi@0 | 113 | |
aoqi@0 | 114 | class JavaSource extends SimpleJavaFileObject { |
aoqi@0 | 115 | |
aoqi@0 | 116 | String source = "strictfp class Test {" + |
aoqi@0 | 117 | " Test(){}" + |
aoqi@0 | 118 | " void m(){}" + |
aoqi@0 | 119 | "}"; |
aoqi@0 | 120 | |
aoqi@0 | 121 | public JavaSource() { |
aoqi@0 | 122 | super(URI.create("Test.java"), JavaFileObject.Kind.SOURCE); |
aoqi@0 | 123 | } |
aoqi@0 | 124 | |
aoqi@0 | 125 | @Override |
aoqi@0 | 126 | public CharSequence getCharContent(boolean ignoreEncodingErrors) { |
aoqi@0 | 127 | return source; |
aoqi@0 | 128 | } |
aoqi@0 | 129 | } |
aoqi@0 | 130 | } |