Mercurial > jdk8-mips64-public > langtools / annotate
test/tools/javac/tree/T8024415.java@ea000904db62 (annotated)
test/tools/javac/tree/T8024415.java
Tue, 08 Oct 2013 15:33:28 +0200
- author
- alundblad
- date
- Tue, 08 Oct 2013 15:33:28 +0200
- changeset 2097
- ea000904db62
- parent 0
- 959103a6100f
- permissions
- -rw-r--r--
8024415: Bug in javac Pretty: Wrong precedence in JCConditional trees
Summary: Fixed precedence and associativity issues with pretty printing of JCConditional expressions.
Reviewed-by: jfranck
Contributed-by: Andreas Lundblad <andreas.lundblad@oracle.com>, Matthew Dempsky <mdempsky@google.com>
| aoqi@0 | 1 | /* |
| aoqi@0 | 2 | * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
| aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
| aoqi@0 | 4 | * |
| aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
| aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
| aoqi@0 | 7 | * published by the Free Software Foundation. |
| aoqi@0 | 8 | * |
| aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
| aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
| aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
| aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
| aoqi@0 | 13 | * accompanied this code). |
| aoqi@0 | 14 | * |
| aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
| aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
| aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
| aoqi@0 | 18 | * |
| aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
| aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
| aoqi@0 | 21 | * questions. |
| aoqi@0 | 22 | */ |
| aoqi@0 | 23 | |
| aoqi@0 | 24 | /* |
| aoqi@0 | 25 | * @test |
| aoqi@0 | 26 | * @bug 8024415 |
| aoqi@0 | 27 | * @summary Pretty printing of JCConditional does not follow the precedence and |
| aoqi@0 | 28 | * associativity rules of JCConditional |
| aoqi@0 | 29 | * @run testng T8024415 |
| aoqi@0 | 30 | */ |
| aoqi@0 | 31 | |
| aoqi@0 | 32 | |
| aoqi@0 | 33 | import static org.testng.Assert.assertEquals; |
| aoqi@0 | 34 | |
| aoqi@0 | 35 | import java.io.IOException; |
| aoqi@0 | 36 | import java.io.StringWriter; |
| aoqi@0 | 37 | |
| aoqi@0 | 38 | import org.testng.annotations.Test; |
| aoqi@0 | 39 | |
| aoqi@0 | 40 | import com.sun.tools.javac.file.JavacFileManager; |
| aoqi@0 | 41 | import com.sun.tools.javac.tree.JCTree; |
| aoqi@0 | 42 | import com.sun.tools.javac.tree.JCTree.JCExpression; |
| aoqi@0 | 43 | import com.sun.tools.javac.tree.Pretty; |
| aoqi@0 | 44 | import com.sun.tools.javac.tree.TreeMaker; |
| aoqi@0 | 45 | import com.sun.tools.javac.util.Context; |
| aoqi@0 | 46 | import com.sun.tools.javac.util.Names; |
| aoqi@0 | 47 | |
| aoqi@0 | 48 | |
| aoqi@0 | 49 | /* |
| aoqi@0 | 50 | * Test verifies that the precedence rules of conditional expressions |
| aoqi@0 | 51 | * (JCConditional) are correct. |
| aoqi@0 | 52 | */ |
| aoqi@0 | 53 | @Test |
| aoqi@0 | 54 | public class T8024415 { |
| aoqi@0 | 55 | |
| aoqi@0 | 56 | TreeMaker maker; |
| aoqi@0 | 57 | JCExpression x; |
| aoqi@0 | 58 | |
| aoqi@0 | 59 | |
| aoqi@0 | 60 | public T8024415() { |
| aoqi@0 | 61 | Context ctx = new Context(); |
| aoqi@0 | 62 | JavacFileManager.preRegister(ctx); |
| aoqi@0 | 63 | maker = TreeMaker.instance(ctx); |
| aoqi@0 | 64 | Names names = Names.instance(ctx); |
| aoqi@0 | 65 | x = maker.Ident(names.fromString("x")); |
| aoqi@0 | 66 | } |
| aoqi@0 | 67 | |
| aoqi@0 | 68 | |
| aoqi@0 | 69 | // JLS 15.25: The conditional operator is syntactically right-associative |
| aoqi@0 | 70 | // (it groups right-to-left). Thus, a?b:c?d:e?f:g means the same as |
| aoqi@0 | 71 | // a?b:(c?d:(e?f:g)). |
| aoqi@0 | 72 | public void testAssociativity() throws IOException { |
| aoqi@0 | 73 | |
| aoqi@0 | 74 | JCTree left = maker.Conditional(maker.Conditional(x, x, x), x, x); |
| aoqi@0 | 75 | JCTree right = maker.Conditional(x, x, maker.Conditional(x, x, x)); |
| aoqi@0 | 76 | |
| aoqi@0 | 77 | String prettyLeft = prettyPrint(left); |
| aoqi@0 | 78 | String prettyRight = prettyPrint(right); |
| aoqi@0 | 79 | |
| aoqi@0 | 80 | assertEquals(prettyLeft.replaceAll("\\s", ""), "(x?x:x)?x:x"); |
| aoqi@0 | 81 | assertEquals(prettyRight.replaceAll("\\s", ""), "x?x:x?x:x"); |
| aoqi@0 | 82 | |
| aoqi@0 | 83 | } |
| aoqi@0 | 84 | |
| aoqi@0 | 85 | |
| aoqi@0 | 86 | // The true-part of of a conditional expression is surrounded by ? and : |
| aoqi@0 | 87 | // and can thus always be parsed unambiguously without surrounding |
| aoqi@0 | 88 | // parentheses. |
| aoqi@0 | 89 | public void testPrecedence() throws IOException { |
| aoqi@0 | 90 | |
| aoqi@0 | 91 | JCTree left = maker.Conditional(maker.Assign(x, x), x, x); |
| aoqi@0 | 92 | JCTree middle = maker.Conditional(x, maker.Assign(x, x), x); |
| aoqi@0 | 93 | JCTree right = maker.Conditional(x, x, maker.Assign(x, x)); |
| aoqi@0 | 94 | |
| aoqi@0 | 95 | String prettyLeft = prettyPrint(left); |
| aoqi@0 | 96 | String prettyMiddle = prettyPrint(middle); |
| aoqi@0 | 97 | String prettyRight = prettyPrint(right); |
| aoqi@0 | 98 | |
| aoqi@0 | 99 | assertEquals(prettyLeft.replaceAll("\\s", ""), "(x=x)?x:x"); |
| aoqi@0 | 100 | assertEquals(prettyMiddle.replaceAll("\\s", ""), "x?x=x:x"); |
| aoqi@0 | 101 | assertEquals(prettyRight.replaceAll("\\s", ""), "x?x:(x=x)"); |
| aoqi@0 | 102 | |
| aoqi@0 | 103 | } |
| aoqi@0 | 104 | |
| aoqi@0 | 105 | |
| aoqi@0 | 106 | // Helper method |
| aoqi@0 | 107 | private static String prettyPrint(JCTree tree) throws IOException { |
| aoqi@0 | 108 | StringWriter sw = new StringWriter(); |
| aoqi@0 | 109 | new Pretty(sw, true).printExpr(tree); |
| aoqi@0 | 110 | return sw.toString(); |
| aoqi@0 | 111 | } |
| aoqi@0 | 112 | |
| aoqi@0 | 113 | } |
