Wed, 14 May 2014 15:41:28 -0600
8034223: Most-specific should not have any special treatment for boxed vs. unboxed types
Summary: Rewrite most-specific logic to conform to JLS 8 15.12.2.5
Reviewed-by: vromero
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | */ |
aoqi@0 | 23 | |
aoqi@0 | 24 | /* |
aoqi@0 | 25 | * @test |
aoqi@0 | 26 | * @bug 8012557 |
aoqi@0 | 27 | * @summary Check that 8012557 is fixed, that interface lambda |
aoqi@0 | 28 | * methods are private |
aoqi@0 | 29 | * @author Robert Field |
aoqi@0 | 30 | * @compile SAM.java |
aoqi@0 | 31 | * @compile A.java |
aoqi@0 | 32 | * @compile B.java |
aoqi@0 | 33 | * @compile C.java |
aoqi@0 | 34 | * @run main PrivateLambdas |
aoqi@0 | 35 | * |
aoqi@0 | 36 | * Unless the lambda methods are private, this will fail with: |
aoqi@0 | 37 | * AbstractMethodError: |
aoqi@0 | 38 | * Conflicting default methods: A.lambda$0 B.lambda$0 C.lambda$0 |
aoqi@0 | 39 | */ |
aoqi@0 | 40 | |
aoqi@0 | 41 | import java.lang.reflect.Method; |
aoqi@0 | 42 | import java.lang.reflect.Modifier; |
aoqi@0 | 43 | |
aoqi@0 | 44 | interface X extends A, B, C { |
aoqi@0 | 45 | default String u() { return " "; } |
aoqi@0 | 46 | default String name() { |
aoqi@0 | 47 | return A.super.name() + B.super.name() + C.super.name(); |
aoqi@0 | 48 | } |
aoqi@0 | 49 | } |
aoqi@0 | 50 | |
aoqi@0 | 51 | public class PrivateLambdas implements X { |
aoqi@0 | 52 | public static void main(String[] args) throws Exception { |
aoqi@0 | 53 | |
aoqi@0 | 54 | // Check that all the lambda methods are private instance synthetic |
aoqi@0 | 55 | for (Class<?> k : new Class<?>[] { A.class, B.class, C.class }) { |
aoqi@0 | 56 | Method[] methods = k.getDeclaredMethods(); |
aoqi@0 | 57 | int lambdaCount = 0; |
aoqi@0 | 58 | for(Method m : methods) { |
aoqi@0 | 59 | if (m.getName().startsWith("lambda$")) { |
aoqi@0 | 60 | ++lambdaCount; |
aoqi@0 | 61 | int mod = m.getModifiers(); |
aoqi@0 | 62 | if ((mod & Modifier.PRIVATE) == 0) { |
aoqi@0 | 63 | throw new Exception("Expected " + m + " to be private"); |
aoqi@0 | 64 | } |
aoqi@0 | 65 | if (!m.isSynthetic()) { |
aoqi@0 | 66 | throw new Exception("Expected " + m + " to be synthetic"); |
aoqi@0 | 67 | } |
aoqi@0 | 68 | if ((mod & Modifier.STATIC) != 0) { |
aoqi@0 | 69 | throw new Exception("Expected " + m + " to be instance method"); |
aoqi@0 | 70 | } |
aoqi@0 | 71 | } |
aoqi@0 | 72 | } |
aoqi@0 | 73 | if (lambdaCount == 0) { |
aoqi@0 | 74 | throw new Exception("Expected at least one lambda method"); |
aoqi@0 | 75 | } |
aoqi@0 | 76 | } |
aoqi@0 | 77 | |
aoqi@0 | 78 | /* |
aoqi@0 | 79 | * Unless the lambda methods are private, this will fail with: |
aoqi@0 | 80 | * AbstractMethodError: |
aoqi@0 | 81 | * Conflicting default methods: A.lambda$0 B.lambda$0 C.lambda$0 |
aoqi@0 | 82 | */ |
aoqi@0 | 83 | X x = new PrivateLambdas(); |
aoqi@0 | 84 | if (!x.name().equals(" A B C")) { |
aoqi@0 | 85 | throw new Exception("Expected ' A B C' got: " + x.name()); |
aoqi@0 | 86 | } |
aoqi@0 | 87 | } |
aoqi@0 | 88 | } |