Tue, 11 Aug 2009 01:13:14 +0100
6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
Summary: javac should warn/complain about identifiers with the same name as synthetic symbol
Reviewed-by: jjg
duke@1 | 1 | /* |
duke@1 | 2 | * Copyright 1997-2006 Sun Microsystems, Inc. All Rights Reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@1 | 7 | * published by the Free Software Foundation. Sun designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
duke@1 | 9 | * by Sun in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
duke@1 | 21 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
duke@1 | 22 | * CA 95054 USA or visit www.sun.com if you need additional information or |
duke@1 | 23 | * have any questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javadoc; |
duke@1 | 27 | |
duke@1 | 28 | import com.sun.javadoc.*; |
duke@1 | 29 | |
duke@1 | 30 | import com.sun.tools.javac.code.*; |
duke@1 | 31 | import com.sun.tools.javac.code.Symbol.*; |
duke@1 | 32 | import com.sun.tools.javac.code.Type; |
duke@1 | 33 | import com.sun.tools.javac.code.TypeTags; |
duke@1 | 34 | import com.sun.tools.javac.tree.JCTree.JCMethodDecl; |
duke@1 | 35 | import com.sun.tools.javac.util.Position; |
duke@1 | 36 | |
duke@1 | 37 | import java.lang.reflect.Modifier; |
duke@1 | 38 | |
duke@1 | 39 | /** |
duke@1 | 40 | * Represents a method of a java class. |
duke@1 | 41 | * |
duke@1 | 42 | * @since 1.2 |
duke@1 | 43 | * @author Robert Field |
duke@1 | 44 | * @author Neal Gafter (rewrite) |
duke@1 | 45 | */ |
duke@1 | 46 | |
duke@1 | 47 | public class MethodDocImpl |
duke@1 | 48 | extends ExecutableMemberDocImpl implements MethodDoc { |
duke@1 | 49 | |
duke@1 | 50 | /** |
duke@1 | 51 | * constructor. |
duke@1 | 52 | */ |
duke@1 | 53 | public MethodDocImpl(DocEnv env, MethodSymbol sym) { |
duke@1 | 54 | super(env, sym); |
duke@1 | 55 | } |
duke@1 | 56 | |
duke@1 | 57 | /** |
duke@1 | 58 | * constructor. |
duke@1 | 59 | */ |
duke@1 | 60 | public MethodDocImpl(DocEnv env, MethodSymbol sym, |
duke@1 | 61 | String docComment, JCMethodDecl tree, Position.LineMap lineMap) { |
duke@1 | 62 | super(env, sym, docComment, tree, lineMap); |
duke@1 | 63 | } |
duke@1 | 64 | |
duke@1 | 65 | /** |
duke@1 | 66 | * Return true if it is a method, which it is. |
duke@1 | 67 | * Note: constructors are not methods. |
duke@1 | 68 | * This method is overridden by AnnotationTypeElementDocImpl. |
duke@1 | 69 | * |
duke@1 | 70 | * @return true |
duke@1 | 71 | */ |
duke@1 | 72 | public boolean isMethod() { |
duke@1 | 73 | return true; |
duke@1 | 74 | } |
duke@1 | 75 | |
duke@1 | 76 | /** |
duke@1 | 77 | * Return true if this method is abstract |
duke@1 | 78 | */ |
duke@1 | 79 | public boolean isAbstract() { |
duke@1 | 80 | //### This is dubious, but old 'javadoc' apparently does it. |
duke@1 | 81 | //### I regard this as a bug and an obstacle to treating the |
duke@1 | 82 | //### doclet API as a proper compile-time reflection facility. |
duke@1 | 83 | //### (maddox 09/26/2000) |
duke@1 | 84 | if (containingClass().isInterface()) { |
duke@1 | 85 | //### Don't force creation of ClassDocImpl for super here. |
duke@1 | 86 | // Abstract modifier is implicit. Strip/canonicalize it. |
duke@1 | 87 | return false; |
duke@1 | 88 | } |
duke@1 | 89 | return Modifier.isAbstract(getModifiers()); |
duke@1 | 90 | } |
duke@1 | 91 | |
duke@1 | 92 | /** |
duke@1 | 93 | * Get return type. |
duke@1 | 94 | * |
duke@1 | 95 | * @return the return type of this method, null if it |
duke@1 | 96 | * is a constructor. |
duke@1 | 97 | */ |
duke@1 | 98 | public com.sun.javadoc.Type returnType() { |
duke@1 | 99 | return TypeMaker.getType(env, sym.type.getReturnType(), false); |
duke@1 | 100 | } |
duke@1 | 101 | |
duke@1 | 102 | /** |
duke@1 | 103 | * Return the class that originally defined the method that |
duke@1 | 104 | * is overridden by the current definition, or null if no |
duke@1 | 105 | * such class exists. |
duke@1 | 106 | * |
duke@1 | 107 | * @return a ClassDocImpl representing the superclass that |
duke@1 | 108 | * originally defined this method, null if this method does |
duke@1 | 109 | * not override a definition in a superclass. |
duke@1 | 110 | */ |
duke@1 | 111 | public ClassDoc overriddenClass() { |
duke@1 | 112 | com.sun.javadoc.Type t = overriddenType(); |
duke@1 | 113 | return (t != null) ? t.asClassDoc() : null; |
duke@1 | 114 | } |
duke@1 | 115 | |
duke@1 | 116 | /** |
duke@1 | 117 | * Return the type containing the method that this method overrides. |
duke@1 | 118 | * It may be a <code>ClassDoc</code> or a <code>ParameterizedType</code>. |
duke@1 | 119 | */ |
duke@1 | 120 | public com.sun.javadoc.Type overriddenType() { |
duke@1 | 121 | |
duke@1 | 122 | if ((sym.flags() & Flags.STATIC) != 0) { |
duke@1 | 123 | return null; |
duke@1 | 124 | } |
duke@1 | 125 | |
duke@1 | 126 | ClassSymbol origin = (ClassSymbol)sym.owner; |
duke@1 | 127 | for (Type t = env.types.supertype(origin.type); |
duke@1 | 128 | t.tag == TypeTags.CLASS; |
duke@1 | 129 | t = env.types.supertype(t)) { |
duke@1 | 130 | ClassSymbol c = (ClassSymbol)t.tsym; |
duke@1 | 131 | for (Scope.Entry e = c.members().lookup(sym.name); e.scope != null; e = e.next()) { |
duke@1 | 132 | if (sym.overrides(e.sym, origin, env.types, true)) { |
duke@1 | 133 | return TypeMaker.getType(env, t); |
duke@1 | 134 | } |
duke@1 | 135 | } |
duke@1 | 136 | } |
duke@1 | 137 | return null; |
duke@1 | 138 | } |
duke@1 | 139 | |
duke@1 | 140 | /** |
duke@1 | 141 | * Return the method that this method overrides. |
duke@1 | 142 | * |
duke@1 | 143 | * @return a MethodDoc representing a method definition |
duke@1 | 144 | * in a superclass this method overrides, null if |
duke@1 | 145 | * this method does not override. |
duke@1 | 146 | */ |
duke@1 | 147 | public MethodDoc overriddenMethod() { |
duke@1 | 148 | |
duke@1 | 149 | // Real overriding only. Static members are simply hidden. |
duke@1 | 150 | // Likewise for constructors, but the MethodSymbol.overrides |
duke@1 | 151 | // method takes this into account. |
duke@1 | 152 | if ((sym.flags() & Flags.STATIC) != 0) { |
duke@1 | 153 | return null; |
duke@1 | 154 | } |
duke@1 | 155 | |
duke@1 | 156 | // Derived from com.sun.tools.javac.comp.Check.checkOverride . |
duke@1 | 157 | |
duke@1 | 158 | ClassSymbol origin = (ClassSymbol)sym.owner; |
duke@1 | 159 | for (Type t = env.types.supertype(origin.type); |
duke@1 | 160 | t.tag == TypeTags.CLASS; |
duke@1 | 161 | t = env.types.supertype(t)) { |
duke@1 | 162 | ClassSymbol c = (ClassSymbol)t.tsym; |
duke@1 | 163 | for (Scope.Entry e = c.members().lookup(sym.name); e.scope != null; e = e.next()) { |
duke@1 | 164 | if (sym.overrides(e.sym, origin, env.types, true)) { |
duke@1 | 165 | return env.getMethodDoc((MethodSymbol)e.sym); |
duke@1 | 166 | } |
duke@1 | 167 | } |
duke@1 | 168 | } |
duke@1 | 169 | return null; |
duke@1 | 170 | } |
duke@1 | 171 | |
duke@1 | 172 | /** |
duke@1 | 173 | * Tests whether this method overrides another. |
duke@1 | 174 | * The overridden method may be one declared in a superclass or |
duke@1 | 175 | * a superinterface (unlike {@link #overriddenMethod()}). |
duke@1 | 176 | * |
duke@1 | 177 | * <p> When a non-abstract method overrides an abstract one, it is |
duke@1 | 178 | * also said to <i>implement</i> the other. |
duke@1 | 179 | * |
duke@1 | 180 | * @param meth the other method to examine |
duke@1 | 181 | * @return <tt>true</tt> if this method overrides the other |
duke@1 | 182 | */ |
duke@1 | 183 | public boolean overrides(MethodDoc meth) { |
duke@1 | 184 | MethodSymbol overridee = ((MethodDocImpl) meth).sym; |
duke@1 | 185 | ClassSymbol origin = (ClassSymbol) sym.owner; |
duke@1 | 186 | |
duke@1 | 187 | return sym.name == overridee.name && |
duke@1 | 188 | |
duke@1 | 189 | // not reflexive as per JLS |
duke@1 | 190 | sym != overridee && |
duke@1 | 191 | |
duke@1 | 192 | // we don't care if overridee is static, though that wouldn't |
duke@1 | 193 | // compile |
duke@1 | 194 | !sym.isStatic() && |
duke@1 | 195 | |
duke@1 | 196 | // sym, whose declaring type is the origin, must be |
duke@1 | 197 | // in a subtype of overridee's type |
duke@1 | 198 | env.types.asSuper(origin.type, overridee.owner) != null && |
duke@1 | 199 | |
duke@1 | 200 | // check access and signatures; don't check return types |
duke@1 | 201 | sym.overrides(overridee, origin, env.types, false); |
duke@1 | 202 | } |
duke@1 | 203 | |
duke@1 | 204 | |
duke@1 | 205 | public String name() { |
duke@1 | 206 | return sym.name.toString(); |
duke@1 | 207 | } |
duke@1 | 208 | |
duke@1 | 209 | public String qualifiedName() { |
duke@1 | 210 | return sym.enclClass().getQualifiedName() + "." + sym.name; |
duke@1 | 211 | } |
duke@1 | 212 | |
duke@1 | 213 | /** |
duke@1 | 214 | * Returns a string representation of this method. Includes the |
duke@1 | 215 | * qualified signature, the qualified method name, and any type |
duke@1 | 216 | * parameters. Type parameters follow the class name, as they do |
duke@1 | 217 | * in the syntax for invoking methods with explicit type parameters. |
duke@1 | 218 | */ |
duke@1 | 219 | public String toString() { |
duke@1 | 220 | return sym.enclClass().getQualifiedName() + |
duke@1 | 221 | "." + typeParametersString() + name() + signature(); |
duke@1 | 222 | } |
duke@1 | 223 | } |