Tue, 11 Aug 2009 01:13:14 +0100
6521805: Regression: JDK5/JDK6 javac allows write access to outer class reference
Summary: javac should warn/complain about identifiers with the same name as synthetic symbol
Reviewed-by: jjg
duke@1 | 1 | /* |
xdono@229 | 2 | * Copyright 1997-2009 Sun Microsystems, Inc. All Rights Reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
duke@1 | 7 | * published by the Free Software Foundation. Sun designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
duke@1 | 9 | * by Sun in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
duke@1 | 21 | * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara, |
duke@1 | 22 | * CA 95054 USA or visit www.sun.com if you need additional information or |
duke@1 | 23 | * have any questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javadoc; |
duke@1 | 27 | |
jjg@197 | 28 | import java.lang.reflect.Modifier; |
jjg@197 | 29 | import java.text.CollationKey; |
jjg@197 | 30 | |
duke@1 | 31 | import com.sun.javadoc.*; |
duke@1 | 32 | |
jjg@197 | 33 | import com.sun.tools.javac.code.Flags; |
jjg@197 | 34 | import com.sun.tools.javac.code.Symbol.*; |
jjg@197 | 35 | import com.sun.tools.javac.code.Type; |
jjg@197 | 36 | import com.sun.tools.javac.tree.JCTree.JCMethodDecl; |
duke@1 | 37 | import com.sun.tools.javac.util.List; |
duke@1 | 38 | import com.sun.tools.javac.util.ListBuffer; |
duke@1 | 39 | import com.sun.tools.javac.util.Position; |
duke@1 | 40 | |
duke@1 | 41 | /** |
duke@1 | 42 | * Represents a method or constructor of a java class. |
duke@1 | 43 | * |
duke@1 | 44 | * @since 1.2 |
duke@1 | 45 | * @author Robert Field |
duke@1 | 46 | * @author Neal Gafter (rewrite) |
duke@1 | 47 | * @author Scott Seligman (generics, annotations) |
duke@1 | 48 | */ |
duke@1 | 49 | |
duke@1 | 50 | public abstract class ExecutableMemberDocImpl |
duke@1 | 51 | extends MemberDocImpl implements ExecutableMemberDoc { |
duke@1 | 52 | |
duke@1 | 53 | protected final MethodSymbol sym; |
duke@1 | 54 | |
duke@1 | 55 | /** |
duke@1 | 56 | * Constructor. |
duke@1 | 57 | */ |
duke@1 | 58 | public ExecutableMemberDocImpl(DocEnv env, MethodSymbol sym, |
duke@1 | 59 | String rawDocs, JCMethodDecl tree, Position.LineMap lineMap) { |
duke@1 | 60 | super(env, sym, rawDocs, tree, lineMap); |
duke@1 | 61 | this.sym = sym; |
duke@1 | 62 | } |
duke@1 | 63 | |
duke@1 | 64 | /** |
duke@1 | 65 | * Constructor. |
duke@1 | 66 | */ |
duke@1 | 67 | public ExecutableMemberDocImpl(DocEnv env, MethodSymbol sym) { |
duke@1 | 68 | this(env, sym, null, null, null); |
duke@1 | 69 | } |
duke@1 | 70 | |
duke@1 | 71 | /** |
duke@1 | 72 | * Returns the flags in terms of javac's flags |
duke@1 | 73 | */ |
duke@1 | 74 | protected long getFlags() { |
duke@1 | 75 | return sym.flags(); |
duke@1 | 76 | } |
duke@1 | 77 | |
duke@1 | 78 | /** |
duke@1 | 79 | * Identify the containing class |
duke@1 | 80 | */ |
duke@1 | 81 | protected ClassSymbol getContainingClass() { |
duke@1 | 82 | return sym.enclClass(); |
duke@1 | 83 | } |
duke@1 | 84 | |
duke@1 | 85 | /** |
duke@1 | 86 | * Return true if this method is native |
duke@1 | 87 | */ |
duke@1 | 88 | public boolean isNative() { |
duke@1 | 89 | return Modifier.isNative(getModifiers()); |
duke@1 | 90 | } |
duke@1 | 91 | |
duke@1 | 92 | /** |
duke@1 | 93 | * Return true if this method is synchronized |
duke@1 | 94 | */ |
duke@1 | 95 | public boolean isSynchronized() { |
duke@1 | 96 | return Modifier.isSynchronized(getModifiers()); |
duke@1 | 97 | } |
duke@1 | 98 | |
duke@1 | 99 | /** |
duke@1 | 100 | * Return true if this method was declared to take a variable number |
duke@1 | 101 | * of arguments. |
duke@1 | 102 | */ |
duke@1 | 103 | public boolean isVarArgs() { |
duke@1 | 104 | return ((sym.flags() & Flags.VARARGS) != 0 |
duke@1 | 105 | && !env.legacyDoclet); |
duke@1 | 106 | } |
duke@1 | 107 | |
duke@1 | 108 | /** |
duke@1 | 109 | * Returns true if this field was synthesized by the compiler. |
duke@1 | 110 | */ |
duke@1 | 111 | public boolean isSynthetic() { |
duke@1 | 112 | return ((sym.flags() & Flags.SYNTHETIC) != 0); |
duke@1 | 113 | } |
duke@1 | 114 | |
duke@1 | 115 | public boolean isIncluded() { |
duke@1 | 116 | return containingClass().isIncluded() && env.shouldDocument(sym); |
duke@1 | 117 | } |
duke@1 | 118 | |
duke@1 | 119 | /** |
duke@1 | 120 | * Return the throws tags in this method. |
duke@1 | 121 | * |
duke@1 | 122 | * @return an array of ThrowTagImpl containing all {@code @exception} |
duke@1 | 123 | * and {@code @throws} tags. |
duke@1 | 124 | */ |
duke@1 | 125 | public ThrowsTag[] throwsTags() { |
duke@1 | 126 | return comment().throwsTags(); |
duke@1 | 127 | } |
duke@1 | 128 | |
duke@1 | 129 | /** |
duke@1 | 130 | * Return the param tags in this method, excluding the type |
duke@1 | 131 | * parameter tags. |
duke@1 | 132 | * |
duke@1 | 133 | * @return an array of ParamTagImpl containing all {@code @param} tags. |
duke@1 | 134 | */ |
duke@1 | 135 | public ParamTag[] paramTags() { |
duke@1 | 136 | return comment().paramTags(); |
duke@1 | 137 | } |
duke@1 | 138 | |
duke@1 | 139 | /** |
duke@1 | 140 | * Return the type parameter tags in this method. |
duke@1 | 141 | */ |
duke@1 | 142 | public ParamTag[] typeParamTags() { |
duke@1 | 143 | return env.legacyDoclet |
duke@1 | 144 | ? new ParamTag[0] |
duke@1 | 145 | : comment().typeParamTags(); |
duke@1 | 146 | } |
duke@1 | 147 | |
duke@1 | 148 | /** |
duke@1 | 149 | * Return exceptions this method or constructor throws. |
duke@1 | 150 | * |
duke@1 | 151 | * @return an array of ClassDoc[] representing the exceptions |
duke@1 | 152 | * thrown by this method. |
duke@1 | 153 | */ |
duke@1 | 154 | public ClassDoc[] thrownExceptions() { |
duke@1 | 155 | ListBuffer<ClassDocImpl> l = new ListBuffer<ClassDocImpl>(); |
duke@1 | 156 | for (Type ex : sym.type.getThrownTypes()) { |
duke@1 | 157 | ex = env.types.erasure(ex); |
duke@1 | 158 | //### Will these casts succeed in the face of static semantic |
duke@1 | 159 | //### errors in the documented code? |
duke@1 | 160 | ClassDocImpl cdi = env.getClassDoc((ClassSymbol)ex.tsym); |
duke@1 | 161 | if (cdi != null) l.append(cdi); |
duke@1 | 162 | } |
duke@1 | 163 | return l.toArray(new ClassDocImpl[l.length()]); |
duke@1 | 164 | } |
duke@1 | 165 | |
duke@1 | 166 | /** |
duke@1 | 167 | * Return exceptions this method or constructor throws. |
duke@1 | 168 | * Each array element is either a <code>ClassDoc</code> or a |
duke@1 | 169 | * <code>TypeVariable</code>. |
duke@1 | 170 | */ |
duke@1 | 171 | public com.sun.javadoc.Type[] thrownExceptionTypes() { |
duke@1 | 172 | return TypeMaker.getTypes(env, sym.type.getThrownTypes()); |
duke@1 | 173 | } |
duke@1 | 174 | |
duke@1 | 175 | /** |
duke@1 | 176 | * Get argument information. |
duke@1 | 177 | * |
duke@1 | 178 | * @see ParameterImpl |
duke@1 | 179 | * |
duke@1 | 180 | * @return an array of ParameterImpl, one element per argument |
duke@1 | 181 | * in the order the arguments are present. |
duke@1 | 182 | */ |
duke@1 | 183 | public Parameter[] parameters() { |
duke@1 | 184 | // generate the parameters on the fly: they're not cached |
duke@1 | 185 | List<VarSymbol> params = sym.params(); |
duke@1 | 186 | Parameter result[] = new Parameter[params.length()]; |
duke@1 | 187 | |
duke@1 | 188 | int i = 0; |
duke@1 | 189 | for (VarSymbol param : params) { |
duke@1 | 190 | result[i++] = new ParameterImpl(env, param); |
duke@1 | 191 | } |
duke@1 | 192 | return result; |
duke@1 | 193 | } |
duke@1 | 194 | |
duke@1 | 195 | /** |
duke@1 | 196 | * Return the formal type parameters of this method or constructor. |
duke@1 | 197 | * Return an empty array if there are none. |
duke@1 | 198 | */ |
duke@1 | 199 | public TypeVariable[] typeParameters() { |
duke@1 | 200 | if (env.legacyDoclet) { |
duke@1 | 201 | return new TypeVariable[0]; |
duke@1 | 202 | } |
duke@1 | 203 | TypeVariable res[] = new TypeVariable[sym.type.getTypeArguments().length()]; |
duke@1 | 204 | TypeMaker.getTypes(env, sym.type.getTypeArguments(), res); |
duke@1 | 205 | return res; |
duke@1 | 206 | } |
duke@1 | 207 | |
duke@1 | 208 | /** |
duke@1 | 209 | * Get the signature. It is the parameter list, type is qualified. |
duke@1 | 210 | * For instance, for a method <code>mymethod(String x, int y)</code>, |
duke@1 | 211 | * it will return <code>(java.lang.String,int)</code>. |
duke@1 | 212 | */ |
duke@1 | 213 | public String signature() { |
duke@1 | 214 | return makeSignature(true); |
duke@1 | 215 | } |
duke@1 | 216 | |
duke@1 | 217 | /** |
duke@1 | 218 | * Get flat signature. All types are not qualified. |
duke@1 | 219 | * Return a String, which is the flat signiture of this member. |
duke@1 | 220 | * It is the parameter list, type is not qualified. |
duke@1 | 221 | * For instance, for a method <code>mymethod(String x, int y)</code>, |
duke@1 | 222 | * it will return <code>(String, int)</code>. |
duke@1 | 223 | */ |
duke@1 | 224 | public String flatSignature() { |
duke@1 | 225 | return makeSignature(false); |
duke@1 | 226 | } |
duke@1 | 227 | |
duke@1 | 228 | private String makeSignature(boolean full) { |
duke@1 | 229 | StringBuffer result = new StringBuffer(); |
duke@1 | 230 | result.append("("); |
duke@1 | 231 | for (List<Type> types = sym.type.getParameterTypes(); types.nonEmpty(); ) { |
jjg@74 | 232 | Type t = types.head; |
duke@1 | 233 | result.append(TypeMaker.getTypeString(env, t, full)); |
duke@1 | 234 | types = types.tail; |
duke@1 | 235 | if (types.nonEmpty()) { |
duke@1 | 236 | result.append(", "); |
duke@1 | 237 | } |
duke@1 | 238 | } |
duke@1 | 239 | if (isVarArgs()) { |
duke@1 | 240 | int len = result.length(); |
duke@1 | 241 | result.replace(len - 2, len, "..."); |
duke@1 | 242 | } |
duke@1 | 243 | result.append(")"); |
duke@1 | 244 | return result.toString(); |
duke@1 | 245 | } |
duke@1 | 246 | |
duke@1 | 247 | protected String typeParametersString() { |
duke@1 | 248 | return TypeMaker.typeParametersString(env, sym, true); |
duke@1 | 249 | } |
duke@1 | 250 | |
duke@1 | 251 | /** |
duke@1 | 252 | * Generate a key for sorting. |
duke@1 | 253 | */ |
duke@1 | 254 | CollationKey generateKey() { |
duke@1 | 255 | String k = name() + flatSignature() + typeParametersString(); |
duke@1 | 256 | // ',' and '&' are between '$' and 'a': normalize to spaces. |
duke@1 | 257 | k = k.replace(',', ' ').replace('&', ' '); |
duke@1 | 258 | // System.out.println("COLLATION KEY FOR " + this + " is \"" + k + "\""); |
duke@1 | 259 | return env.doclocale.collator.getCollationKey(k); |
duke@1 | 260 | } |
duke@1 | 261 | |
duke@1 | 262 | /** |
duke@1 | 263 | * Return the source position of the entity, or null if |
duke@1 | 264 | * no position is available. |
duke@1 | 265 | */ |
duke@1 | 266 | public SourcePosition position() { |
duke@1 | 267 | if (sym.enclClass().sourcefile == null) return null; |
jjg@197 | 268 | return SourcePositionImpl.make(sym.enclClass().sourcefile, |
duke@1 | 269 | (tree==null) ? 0 : tree.pos, |
duke@1 | 270 | lineMap); |
duke@1 | 271 | } |
duke@1 | 272 | } |