Mon, 13 Dec 2010 15:11:00 -0800
6993978: Project Coin: Compiler support of annotation to reduce varargs warnings
Reviewed-by: jjg, darcy
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | */ |
aoqi@0 | 23 | |
aoqi@0 | 24 | /* |
aoqi@0 | 25 | * @test |
aoqi@0 | 26 | * @bug 6999210 |
aoqi@0 | 27 | * @summary javac should be able to warn of anomalous conditions in classfiles |
aoqi@0 | 28 | */ |
aoqi@0 | 29 | |
aoqi@0 | 30 | import java.io.*; |
aoqi@0 | 31 | import java.util.*; |
aoqi@0 | 32 | |
aoqi@0 | 33 | public class T6999210 { |
aoqi@0 | 34 | public static void main(String... args) throws Exception { |
aoqi@0 | 35 | new T6999210().run(); |
aoqi@0 | 36 | } |
aoqi@0 | 37 | |
aoqi@0 | 38 | void run() throws Exception { |
aoqi@0 | 39 | File srcDir = new File("src"); |
aoqi@0 | 40 | File classesDir = new File("classes"); |
aoqi@0 | 41 | classesDir.mkdirs(); |
aoqi@0 | 42 | |
aoqi@0 | 43 | File c_java = writeFile(srcDir, "C.java", "class C<T> { }"); |
aoqi@0 | 44 | compile("-d", classesDir.getPath(), c_java.getPath()); |
aoqi@0 | 45 | File c_class = new File(classesDir, "C.class"); |
aoqi@0 | 46 | setMajorVersion(c_class, 48); |
aoqi@0 | 47 | File d_java = writeFile(srcDir, "D.java", "class D { C c; }"); |
aoqi@0 | 48 | |
aoqi@0 | 49 | // verify no warning if -Xlint:classfile not enabled |
aoqi@0 | 50 | String out1 = compile( |
aoqi@0 | 51 | "-d", classesDir.getPath(), |
aoqi@0 | 52 | "-classpath", classesDir.getPath(), |
aoqi@0 | 53 | d_java.getPath()); |
aoqi@0 | 54 | if (out1.length() > 0) |
aoqi@0 | 55 | error("unexpected output from javac"); |
aoqi@0 | 56 | |
aoqi@0 | 57 | // sanity check of warning when -XDrawDiagnostics not used |
aoqi@0 | 58 | String out2 = compile( |
aoqi@0 | 59 | "-d", classesDir.getPath(), |
aoqi@0 | 60 | "-classpath", classesDir.getPath(), |
aoqi@0 | 61 | "-Xlint:classfile", |
aoqi@0 | 62 | d_java.getPath()); |
aoqi@0 | 63 | if (!out2.contains("[classfile]")) |
aoqi@0 | 64 | error("expected output \"[classfile]\" not found"); |
aoqi@0 | 65 | |
aoqi@0 | 66 | // check specific details, using -XDrawDiagnostics |
aoqi@0 | 67 | String out3 = compile( |
aoqi@0 | 68 | "-d", classesDir.getPath(), |
aoqi@0 | 69 | "-classpath", classesDir.getPath(), |
aoqi@0 | 70 | "-Xlint:classfile", "-XDrawDiagnostics", |
aoqi@0 | 71 | d_java.getPath()); |
aoqi@0 | 72 | String expect = "C.class:-:-: compiler.warn.future.attr: Signature, 49, 0, 48, 0"; |
aoqi@0 | 73 | if (!out3.contains(expect)) |
aoqi@0 | 74 | error("expected output \"" + expect + "\" not found"); |
aoqi@0 | 75 | |
aoqi@0 | 76 | if (errors > 0) |
aoqi@0 | 77 | throw new Exception(errors + " errors occurred"); |
aoqi@0 | 78 | } |
aoqi@0 | 79 | |
aoqi@0 | 80 | String compile(String... args) throws Exception { |
aoqi@0 | 81 | System.err.println("compile: " + Arrays.asList(args)); |
aoqi@0 | 82 | StringWriter sw = new StringWriter(); |
aoqi@0 | 83 | PrintWriter pw = new PrintWriter(sw); |
aoqi@0 | 84 | int rc = com.sun.tools.javac.Main.compile(args, pw); |
aoqi@0 | 85 | pw.close(); |
aoqi@0 | 86 | String out = sw.toString(); |
aoqi@0 | 87 | if (out.length() > 0) |
aoqi@0 | 88 | System.err.println(out); |
aoqi@0 | 89 | if (rc != 0) |
aoqi@0 | 90 | throw new Exception("compilation failed, rc=" + rc); |
aoqi@0 | 91 | return out; |
aoqi@0 | 92 | } |
aoqi@0 | 93 | |
aoqi@0 | 94 | void setMajorVersion(File f, int major) throws IOException { |
aoqi@0 | 95 | int len = (int) f.length(); |
aoqi@0 | 96 | byte[] data = new byte[len]; |
aoqi@0 | 97 | try (DataInputStream in = new DataInputStream(new FileInputStream(f))) { |
aoqi@0 | 98 | in.readFully(data); |
aoqi@0 | 99 | } |
aoqi@0 | 100 | // u4 magic |
aoqi@0 | 101 | // u2 minor |
aoqi@0 | 102 | data[6] = (byte) (major >> 8); |
aoqi@0 | 103 | data[7] = (byte) (major & 0xff); |
aoqi@0 | 104 | try (FileOutputStream out = new FileOutputStream(f)) { |
aoqi@0 | 105 | out.write(data); |
aoqi@0 | 106 | } |
aoqi@0 | 107 | } |
aoqi@0 | 108 | |
aoqi@0 | 109 | File writeFile(File dir, String path, String body) throws IOException { |
aoqi@0 | 110 | File f = new File(dir, path); |
aoqi@0 | 111 | f.getParentFile().mkdirs(); |
aoqi@0 | 112 | try (FileWriter out = new FileWriter(f)) { |
aoqi@0 | 113 | out.write(body); |
aoqi@0 | 114 | } |
aoqi@0 | 115 | return f; |
aoqi@0 | 116 | } |
aoqi@0 | 117 | |
aoqi@0 | 118 | void error(String msg) { |
aoqi@0 | 119 | System.err.println("Error: " + msg); |
aoqi@0 | 120 | errors++; |
aoqi@0 | 121 | } |
aoqi@0 | 122 | |
aoqi@0 | 123 | int errors; |
aoqi@0 | 124 | } |