Mon, 17 Oct 2011 12:57:36 +0100
7093325: Redundant entry in bytecode exception table
Summary: Inlining of finalizers does not update gaps list accordingly
Reviewed-by: jjg
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | */ |
aoqi@0 | 23 | |
aoqi@0 | 24 | /* |
aoqi@0 | 25 | * @test |
aoqi@0 | 26 | * @bug 6863465 |
aoqi@0 | 27 | * @summary javac doesn't detect circular subclass dependencies via qualified names |
aoqi@0 | 28 | * @run main TestCircularClassfile |
aoqi@0 | 29 | */ |
aoqi@0 | 30 | |
aoqi@0 | 31 | import java.io.*; |
aoqi@0 | 32 | import java.net.URI; |
aoqi@0 | 33 | import java.util.Arrays; |
aoqi@0 | 34 | import javax.tools.Diagnostic; |
aoqi@0 | 35 | import javax.tools.DiagnosticListener; |
aoqi@0 | 36 | import javax.tools.JavaCompiler; |
aoqi@0 | 37 | import javax.tools.JavaFileObject; |
aoqi@0 | 38 | import javax.tools.SimpleJavaFileObject; |
aoqi@0 | 39 | import javax.tools.ToolProvider; |
aoqi@0 | 40 | |
aoqi@0 | 41 | import com.sun.source.util.JavacTask; |
aoqi@0 | 42 | import java.util.EnumSet; |
aoqi@0 | 43 | |
aoqi@0 | 44 | public class TestCircularClassfile { |
aoqi@0 | 45 | |
aoqi@0 | 46 | enum ClassName { |
aoqi@0 | 47 | A("A"), |
aoqi@0 | 48 | B("B"), |
aoqi@0 | 49 | C("C"), |
aoqi@0 | 50 | OBJECT("Object"); |
aoqi@0 | 51 | |
aoqi@0 | 52 | String name; |
aoqi@0 | 53 | |
aoqi@0 | 54 | ClassName(String name) { |
aoqi@0 | 55 | this.name = name; |
aoqi@0 | 56 | } |
aoqi@0 | 57 | } |
aoqi@0 | 58 | |
aoqi@0 | 59 | static class JavaSource extends SimpleJavaFileObject { |
aoqi@0 | 60 | |
aoqi@0 | 61 | final static String sourceStub = "class #C extends #S {}"; |
aoqi@0 | 62 | |
aoqi@0 | 63 | String source; |
aoqi@0 | 64 | |
aoqi@0 | 65 | public JavaSource(ClassName clazz, ClassName sup) { |
aoqi@0 | 66 | super(URI.create("myfo:/Test.java"), JavaFileObject.Kind.SOURCE); |
aoqi@0 | 67 | source = sourceStub.replace("#C", clazz.name).replace("#S", sup.name); |
aoqi@0 | 68 | } |
aoqi@0 | 69 | |
aoqi@0 | 70 | @Override |
aoqi@0 | 71 | public CharSequence getCharContent(boolean ignoreEncodingErrors) { |
aoqi@0 | 72 | return source; |
aoqi@0 | 73 | } |
aoqi@0 | 74 | } |
aoqi@0 | 75 | |
aoqi@0 | 76 | public static void main(String... args) throws Exception { |
aoqi@0 | 77 | int count = 0; |
aoqi@0 | 78 | for (ClassName clazz : EnumSet.of(ClassName.A, ClassName.B, ClassName.C)) { |
aoqi@0 | 79 | for (ClassName sup : EnumSet.of(ClassName.A, ClassName.B, ClassName.C)) { |
aoqi@0 | 80 | if (sup.ordinal() < clazz.ordinal()) continue; |
aoqi@0 | 81 | check("sub_"+count++, clazz, sup); |
aoqi@0 | 82 | } |
aoqi@0 | 83 | } |
aoqi@0 | 84 | } |
aoqi@0 | 85 | |
aoqi@0 | 86 | static JavaSource[] initialSources = new JavaSource[] { |
aoqi@0 | 87 | new JavaSource(ClassName.A, ClassName.OBJECT), |
aoqi@0 | 88 | new JavaSource(ClassName.B, ClassName.A), |
aoqi@0 | 89 | new JavaSource(ClassName.C, ClassName.B) |
aoqi@0 | 90 | }; |
aoqi@0 | 91 | |
aoqi@0 | 92 | static String workDir = System.getProperty("user.dir"); |
aoqi@0 | 93 | |
aoqi@0 | 94 | static void check(String destPath, ClassName clazz, ClassName sup) throws Exception { |
aoqi@0 | 95 | File destDir = new File(workDir, destPath); destDir.mkdir(); |
aoqi@0 | 96 | final JavaCompiler tool = ToolProvider.getSystemJavaCompiler(); |
aoqi@0 | 97 | JavacTask ct = (JavacTask)tool.getTask(null, null, null, |
aoqi@0 | 98 | Arrays.asList("-d", destPath), null, Arrays.asList(initialSources)); |
aoqi@0 | 99 | ct.generate(); |
aoqi@0 | 100 | File fileToRemove = new File(destPath, clazz.name + ".class"); |
aoqi@0 | 101 | fileToRemove.delete(); |
aoqi@0 | 102 | JavaSource newSource = new JavaSource(clazz, sup); |
aoqi@0 | 103 | DiagnosticChecker checker = new DiagnosticChecker(); |
aoqi@0 | 104 | ct = (JavacTask)tool.getTask(null, null, checker, |
aoqi@0 | 105 | Arrays.asList("-cp", destPath), null, Arrays.asList(newSource)); |
aoqi@0 | 106 | ct.analyze(); |
aoqi@0 | 107 | if (!checker.errorFound) { |
aoqi@0 | 108 | throw new AssertionError(newSource.source); |
aoqi@0 | 109 | } |
aoqi@0 | 110 | } |
aoqi@0 | 111 | |
aoqi@0 | 112 | static class DiagnosticChecker implements DiagnosticListener<JavaFileObject> { |
aoqi@0 | 113 | |
aoqi@0 | 114 | boolean errorFound = false; |
aoqi@0 | 115 | |
aoqi@0 | 116 | public void report(Diagnostic<? extends JavaFileObject> diagnostic) { |
aoqi@0 | 117 | if (diagnostic.getKind() == Diagnostic.Kind.ERROR && |
aoqi@0 | 118 | diagnostic.getCode().equals("compiler.err.cyclic.inheritance")) { |
aoqi@0 | 119 | errorFound = true; |
aoqi@0 | 120 | } |
aoqi@0 | 121 | } |
aoqi@0 | 122 | } |
aoqi@0 | 123 | } |