Thu, 31 Aug 2017 15:17:03 +0800
merge
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. |
aoqi@0 | 8 | * |
aoqi@0 | 9 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 10 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 11 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 12 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 13 | * accompanied this code). |
aoqi@0 | 14 | * |
aoqi@0 | 15 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 16 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 17 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 18 | * |
aoqi@0 | 19 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 20 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 21 | * questions. |
aoqi@0 | 22 | */ |
aoqi@0 | 23 | |
aoqi@0 | 24 | /* |
aoqi@0 | 25 | * @test |
aoqi@0 | 26 | * @bug 8029800 |
aoqi@0 | 27 | * @summary String.toLowerCase()/toUpperCase is generally dangerous, check it is not used in langtools |
aoqi@0 | 28 | */ |
aoqi@0 | 29 | |
aoqi@0 | 30 | import java.io.*; |
aoqi@0 | 31 | import java.util.*; |
aoqi@0 | 32 | import javax.tools.*; |
aoqi@0 | 33 | import com.sun.tools.classfile.*; |
aoqi@0 | 34 | import com.sun.tools.classfile.ConstantPool.CONSTANT_Methodref_info; |
aoqi@0 | 35 | |
aoqi@0 | 36 | public class NoStringToLower { |
aoqi@0 | 37 | public static void main(String... args) throws Exception { |
aoqi@0 | 38 | NoStringToLower c = new NoStringToLower(); |
aoqi@0 | 39 | if (c.run(args)) |
aoqi@0 | 40 | return; |
aoqi@0 | 41 | |
aoqi@0 | 42 | if (is_jtreg()) |
aoqi@0 | 43 | throw new Exception(c.errors + " errors occurred"); |
aoqi@0 | 44 | else |
aoqi@0 | 45 | System.exit(1); |
aoqi@0 | 46 | } |
aoqi@0 | 47 | |
aoqi@0 | 48 | static boolean is_jtreg() { |
aoqi@0 | 49 | return (System.getProperty("test.src") != null); |
aoqi@0 | 50 | } |
aoqi@0 | 51 | |
aoqi@0 | 52 | /** |
aoqi@0 | 53 | * Main entry point. |
aoqi@0 | 54 | */ |
aoqi@0 | 55 | boolean run(String... args) throws Exception { |
aoqi@0 | 56 | JavaCompiler c = ToolProvider.getSystemJavaCompiler(); |
aoqi@0 | 57 | JavaFileManager fm = c.getStandardFileManager(null, null, null); |
aoqi@0 | 58 | JavaFileManager.Location javacLoc = findJavacLocation(fm); |
aoqi@0 | 59 | String[] pkgs = { |
aoqi@0 | 60 | "javax.annotation.processing", |
aoqi@0 | 61 | "javax.lang.model", |
aoqi@0 | 62 | "javax.tools", |
aoqi@0 | 63 | "com.sun.source", |
aoqi@0 | 64 | "com.sun.tools.classfile", |
aoqi@0 | 65 | "com.sun.tools.doclet", |
aoqi@0 | 66 | "com.sun.tools.doclint", |
aoqi@0 | 67 | "com.sun.tools.javac", |
aoqi@0 | 68 | "com.sun.tools.javadoc", |
aoqi@0 | 69 | "com.sun.tools.javah", |
aoqi@0 | 70 | "com.sun.tools.javap", |
aoqi@0 | 71 | "com.sun.tools.jdeps", |
aoqi@0 | 72 | "com.sun.tools.sjavac" |
aoqi@0 | 73 | }; |
aoqi@0 | 74 | for (String pkg: pkgs) { |
aoqi@0 | 75 | for (JavaFileObject fo: fm.list(javacLoc, |
aoqi@0 | 76 | pkg, EnumSet.of(JavaFileObject.Kind.CLASS), true)) { |
aoqi@0 | 77 | scan(fo); |
aoqi@0 | 78 | } |
aoqi@0 | 79 | } |
aoqi@0 | 80 | |
aoqi@0 | 81 | return (errors == 0); |
aoqi@0 | 82 | } |
aoqi@0 | 83 | |
aoqi@0 | 84 | // depending on how the test is run, javac may be on bootclasspath or classpath |
aoqi@0 | 85 | JavaFileManager.Location findJavacLocation(JavaFileManager fm) { |
aoqi@0 | 86 | JavaFileManager.Location[] locns = |
aoqi@0 | 87 | { StandardLocation.PLATFORM_CLASS_PATH, StandardLocation.CLASS_PATH }; |
aoqi@0 | 88 | try { |
aoqi@0 | 89 | for (JavaFileManager.Location l: locns) { |
aoqi@0 | 90 | JavaFileObject fo = fm.getJavaFileForInput(l, |
aoqi@0 | 91 | "com.sun.tools.javac.Main", JavaFileObject.Kind.CLASS); |
aoqi@0 | 92 | if (fo != null) |
aoqi@0 | 93 | return l; |
aoqi@0 | 94 | } |
aoqi@0 | 95 | } catch (IOException e) { |
aoqi@0 | 96 | throw new Error(e); |
aoqi@0 | 97 | } |
aoqi@0 | 98 | throw new IllegalStateException("Cannot find javac"); |
aoqi@0 | 99 | } |
aoqi@0 | 100 | |
aoqi@0 | 101 | /** |
aoqi@0 | 102 | * Verify there are no references to String.toLowerCase() in a class file. |
aoqi@0 | 103 | */ |
aoqi@0 | 104 | void scan(JavaFileObject fo) throws IOException { |
aoqi@0 | 105 | InputStream in = fo.openInputStream(); |
aoqi@0 | 106 | try { |
aoqi@0 | 107 | ClassFile cf = ClassFile.read(in); |
aoqi@0 | 108 | for (ConstantPool.CPInfo cpinfo: cf.constant_pool.entries()) { |
aoqi@0 | 109 | if (cpinfo.getTag() == ConstantPool.CONSTANT_Methodref) { |
aoqi@0 | 110 | CONSTANT_Methodref_info ref = (CONSTANT_Methodref_info) cpinfo; |
aoqi@0 | 111 | String methodDesc = ref.getClassInfo().getName() + "." + ref.getNameAndTypeInfo().getName() + ":" + ref.getNameAndTypeInfo().getType(); |
aoqi@0 | 112 | |
aoqi@0 | 113 | if ("java/lang/String.toLowerCase:()Ljava/lang/String;".equals(methodDesc)) { |
aoqi@0 | 114 | error("found reference to String.toLowerCase() in: " + fo.getName()); |
aoqi@0 | 115 | } |
aoqi@0 | 116 | if ("java/lang/String.toUpperCase:()Ljava/lang/String;".equals(methodDesc)) { |
aoqi@0 | 117 | error("found reference to String.toLowerCase() in: " + fo.getName()); |
aoqi@0 | 118 | } |
aoqi@0 | 119 | } |
aoqi@0 | 120 | } |
aoqi@0 | 121 | } catch (ConstantPoolException ignore) { |
aoqi@0 | 122 | } finally { |
aoqi@0 | 123 | in.close(); |
aoqi@0 | 124 | } |
aoqi@0 | 125 | } |
aoqi@0 | 126 | |
aoqi@0 | 127 | /** |
aoqi@0 | 128 | * Report an error. |
aoqi@0 | 129 | */ |
aoqi@0 | 130 | void error(String msg) { |
aoqi@0 | 131 | System.err.println("Error: " + msg); |
aoqi@0 | 132 | errors++; |
aoqi@0 | 133 | } |
aoqi@0 | 134 | |
aoqi@0 | 135 | int errors; |
aoqi@0 | 136 | } |