Thu, 12 Jan 2012 15:28:34 +0000
7123100: javac fails with java.lang.StackOverflowError
Summary: Inference of under-constrained type-variables creates erroneous recursive wildcard types
Reviewed-by: jjg
duke@1 | 1 | /* |
jjg@910 | 2 | * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved. |
duke@1 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
duke@1 | 4 | * |
duke@1 | 5 | * This code is free software; you can redistribute it and/or modify it |
duke@1 | 6 | * under the terms of the GNU General Public License version 2 only, as |
ohair@554 | 7 | * published by the Free Software Foundation. Oracle designates this |
duke@1 | 8 | * particular file as subject to the "Classpath" exception as provided |
ohair@554 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
duke@1 | 10 | * |
duke@1 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
duke@1 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
duke@1 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
duke@1 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
duke@1 | 15 | * accompanied this code). |
duke@1 | 16 | * |
duke@1 | 17 | * You should have received a copy of the GNU General Public License version |
duke@1 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
duke@1 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
duke@1 | 20 | * |
ohair@554 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
ohair@554 | 22 | * or visit www.oracle.com if you need additional information or have any |
ohair@554 | 23 | * questions. |
duke@1 | 24 | */ |
duke@1 | 25 | |
duke@1 | 26 | package com.sun.tools.javadoc; |
duke@1 | 27 | |
duke@1 | 28 | |
duke@1 | 29 | import com.sun.javadoc.*; |
duke@1 | 30 | |
duke@1 | 31 | import com.sun.tools.javac.code.Attribute; |
duke@1 | 32 | import com.sun.tools.javac.code.Symbol.*; |
duke@1 | 33 | import com.sun.tools.javac.code.TypeTags; |
duke@1 | 34 | |
duke@1 | 35 | |
duke@1 | 36 | /** |
duke@1 | 37 | * Represents a value of an annotation type element. |
duke@1 | 38 | * |
duke@1 | 39 | * @author Scott Seligman |
duke@1 | 40 | * @since 1.5 |
duke@1 | 41 | */ |
duke@1 | 42 | |
duke@1 | 43 | public class AnnotationValueImpl implements AnnotationValue { |
duke@1 | 44 | |
duke@1 | 45 | private final DocEnv env; |
duke@1 | 46 | private final Attribute attr; |
duke@1 | 47 | |
duke@1 | 48 | |
duke@1 | 49 | AnnotationValueImpl(DocEnv env, Attribute attr) { |
duke@1 | 50 | this.env = env; |
duke@1 | 51 | this.attr = attr; |
duke@1 | 52 | } |
duke@1 | 53 | |
duke@1 | 54 | /** |
duke@1 | 55 | * Returns the value. |
duke@1 | 56 | * The type of the returned object is one of the following: |
duke@1 | 57 | * <ul><li> a wrapper class for a primitive type |
duke@1 | 58 | * <li> <code>String</code> |
duke@1 | 59 | * <li> <code>Type</code> (representing a class literal) |
duke@1 | 60 | * <li> <code>FieldDoc</code> (representing an enum constant) |
duke@1 | 61 | * <li> <code>AnnotationDesc</code> |
duke@1 | 62 | * <li> <code>AnnotationValue[]</code> |
duke@1 | 63 | * </ul> |
duke@1 | 64 | */ |
duke@1 | 65 | public Object value() { |
duke@1 | 66 | ValueVisitor vv = new ValueVisitor(); |
duke@1 | 67 | attr.accept(vv); |
duke@1 | 68 | return vv.value; |
duke@1 | 69 | } |
duke@1 | 70 | |
duke@1 | 71 | private class ValueVisitor implements Attribute.Visitor { |
duke@1 | 72 | public Object value; |
duke@1 | 73 | |
duke@1 | 74 | public void visitConstant(Attribute.Constant c) { |
duke@1 | 75 | if (c.type.tag == TypeTags.BOOLEAN) { |
duke@1 | 76 | // javac represents false and true as integers 0 and 1 |
duke@1 | 77 | value = Boolean.valueOf( |
duke@1 | 78 | ((Integer)c.value).intValue() != 0); |
duke@1 | 79 | } else { |
duke@1 | 80 | value = c.value; |
duke@1 | 81 | } |
duke@1 | 82 | } |
duke@1 | 83 | |
duke@1 | 84 | public void visitClass(Attribute.Class c) { |
duke@1 | 85 | value = TypeMaker.getType(env, |
duke@1 | 86 | env.types.erasure(c.type)); |
duke@1 | 87 | } |
duke@1 | 88 | |
duke@1 | 89 | public void visitEnum(Attribute.Enum e) { |
duke@1 | 90 | value = env.getFieldDoc(e.value); |
duke@1 | 91 | } |
duke@1 | 92 | |
duke@1 | 93 | public void visitCompound(Attribute.Compound c) { |
duke@1 | 94 | value = new AnnotationDescImpl(env, c); |
duke@1 | 95 | } |
duke@1 | 96 | |
duke@1 | 97 | public void visitArray(Attribute.Array a) { |
duke@1 | 98 | AnnotationValue vals[] = new AnnotationValue[a.values.length]; |
duke@1 | 99 | for (int i = 0; i < vals.length; i++) { |
duke@1 | 100 | vals[i] = new AnnotationValueImpl(env, a.values[i]); |
duke@1 | 101 | } |
duke@1 | 102 | value = vals; |
duke@1 | 103 | } |
duke@1 | 104 | |
duke@1 | 105 | public void visitError(Attribute.Error e) { |
duke@1 | 106 | value = "<error>"; |
duke@1 | 107 | } |
duke@1 | 108 | } |
duke@1 | 109 | |
duke@1 | 110 | /** |
duke@1 | 111 | * Returns a string representation of the value. |
duke@1 | 112 | * |
duke@1 | 113 | * @return the text of a Java language annotation value expression |
duke@1 | 114 | * whose value is the value of this annotation type element. |
duke@1 | 115 | */ |
jjg@910 | 116 | @Override |
duke@1 | 117 | public String toString() { |
duke@1 | 118 | ToStringVisitor tv = new ToStringVisitor(); |
duke@1 | 119 | attr.accept(tv); |
duke@1 | 120 | return tv.toString(); |
duke@1 | 121 | } |
duke@1 | 122 | |
duke@1 | 123 | private class ToStringVisitor implements Attribute.Visitor { |
jjg@910 | 124 | private final StringBuilder sb = new StringBuilder(); |
duke@1 | 125 | |
jjg@910 | 126 | @Override |
duke@1 | 127 | public String toString() { |
duke@1 | 128 | return sb.toString(); |
duke@1 | 129 | } |
duke@1 | 130 | |
duke@1 | 131 | public void visitConstant(Attribute.Constant c) { |
duke@1 | 132 | if (c.type.tag == TypeTags.BOOLEAN) { |
duke@1 | 133 | // javac represents false and true as integers 0 and 1 |
duke@1 | 134 | sb.append(((Integer)c.value).intValue() != 0); |
duke@1 | 135 | } else { |
duke@1 | 136 | sb.append(FieldDocImpl.constantValueExpression(c.value)); |
duke@1 | 137 | } |
duke@1 | 138 | } |
duke@1 | 139 | |
duke@1 | 140 | public void visitClass(Attribute.Class c) { |
duke@1 | 141 | sb.append(c); |
duke@1 | 142 | } |
duke@1 | 143 | |
duke@1 | 144 | public void visitEnum(Attribute.Enum e) { |
duke@1 | 145 | sb.append(e); |
duke@1 | 146 | } |
duke@1 | 147 | |
duke@1 | 148 | public void visitCompound(Attribute.Compound c) { |
duke@1 | 149 | sb.append(new AnnotationDescImpl(env, c)); |
duke@1 | 150 | } |
duke@1 | 151 | |
duke@1 | 152 | public void visitArray(Attribute.Array a) { |
duke@1 | 153 | // Omit braces from singleton. |
duke@1 | 154 | if (a.values.length != 1) sb.append('{'); |
duke@1 | 155 | |
duke@1 | 156 | boolean first = true; |
duke@1 | 157 | for (Attribute elem : a.values) { |
duke@1 | 158 | if (first) { |
duke@1 | 159 | first = false; |
duke@1 | 160 | } else { |
duke@1 | 161 | sb.append(", "); |
duke@1 | 162 | } |
duke@1 | 163 | elem.accept(this); |
duke@1 | 164 | } |
duke@1 | 165 | // Omit braces from singleton. |
duke@1 | 166 | if (a.values.length != 1) sb.append('}'); |
duke@1 | 167 | } |
duke@1 | 168 | |
duke@1 | 169 | public void visitError(Attribute.Error e) { |
duke@1 | 170 | sb.append("<error>"); |
duke@1 | 171 | } |
duke@1 | 172 | } |
duke@1 | 173 | } |