test/tools/javac/T7008643/InlinedFinallyConfuseDebuggersTest.java

Wed, 07 Jun 2017 00:04:12 -0700

author
shshahma
date
Wed, 07 Jun 2017 00:04:12 -0700
changeset 3497
08a21473de54
parent 3371
7220be8747f0
permissions
-rw-r--r--

8180660: missing LNT entry for finally block
Reviewed-by: mcimadamore, vromero
Contributed-by: maurizio.cimadamore@oracle.com, vicente.romero@oracle.com

aoqi@0 1 /*
shshahma@3371 2 * Copyright (c) 2013, 2017, Oracle and/or its affiliates. All rights reserved.
aoqi@0 3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
aoqi@0 4 *
aoqi@0 5 * This code is free software; you can redistribute it and/or modify it
aoqi@0 6 * under the terms of the GNU General Public License version 2 only, as
aoqi@0 7 * published by the Free Software Foundation.
aoqi@0 8 *
aoqi@0 9 * This code is distributed in the hope that it will be useful, but WITHOUT
aoqi@0 10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
aoqi@0 11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
aoqi@0 12 * version 2 for more details (a copy is included in the LICENSE file that
aoqi@0 13 * accompanied this code).
aoqi@0 14 *
aoqi@0 15 * You should have received a copy of the GNU General Public License version
aoqi@0 16 * 2 along with this work; if not, write to the Free Software Foundation,
aoqi@0 17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
aoqi@0 18 *
aoqi@0 19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
aoqi@0 20 * or visit www.oracle.com if you need additional information or have any
aoqi@0 21 * questions.
aoqi@0 22 */
aoqi@0 23
aoqi@0 24 /*
aoqi@0 25 * @test
aoqi@0 26 * @bug 7008643
aoqi@0 27 * @summary inlined finally clauses confuse debuggers
aoqi@0 28 * @library /tools/javac/lib
aoqi@0 29 * @build ToolBox
aoqi@0 30 * @run main InlinedFinallyConfuseDebuggersTest
aoqi@0 31 */
aoqi@0 32
aoqi@0 33 import java.io.File;
aoqi@0 34 import java.nio.file.Paths;
aoqi@0 35
aoqi@0 36 import com.sun.tools.classfile.ClassFile;
aoqi@0 37 import com.sun.tools.classfile.Code_attribute;
aoqi@0 38 import com.sun.tools.classfile.LineNumberTable_attribute;
aoqi@0 39 import com.sun.tools.classfile.Method;
aoqi@0 40 import com.sun.tools.javac.util.Assert;
aoqi@0 41
aoqi@0 42 public class InlinedFinallyConfuseDebuggersTest {
aoqi@0 43
aoqi@0 44 static final String testSource =
aoqi@0 45 /* 01 */ "public class InlinedFinallyTest {\n" +
aoqi@0 46 /* 02 */ " void lookForThisMethod(int value) {\n" +
aoqi@0 47 /* 03 */ " try {\n" +
aoqi@0 48 /* 04 */ " if (value > 0) {\n" +
aoqi@0 49 /* 05 */ " System.out.println(\"if\");\n" +
aoqi@0 50 /* 06 */ " return;\n" +
aoqi@0 51 /* 07 */ " }\n" +
aoqi@0 52 /* 08 */ " } finally {\n" +
aoqi@0 53 /* 09 */ " System.out.println(\"finally\");\n" +
aoqi@0 54 /* 10 */ " }\n" +
aoqi@0 55 /* 11 */ " }\n" +
aoqi@0 56 /* 12 */ "}";
aoqi@0 57
aoqi@0 58 static final int[][] expectedLNT = {
aoqi@0 59 // {line-number, start-pc},
aoqi@0 60 {4, 0}, //if (value > 0) {
aoqi@0 61 {5, 4}, // System.out.println("if");
aoqi@0 62 {9, 12}, //System.out.println("finally");
aoqi@0 63 {6, 20}, // return;
aoqi@0 64 {9, 21}, //System.out.println("finally");
aoqi@0 65 {10, 29},
aoqi@0 66 {9, 32}, //System.out.println("finally");
shshahma@3371 67 {10, 41}, //}
aoqi@0 68 {11, 43},
aoqi@0 69 };
aoqi@0 70
aoqi@0 71 static final String methodToLookFor = "lookForThisMethod";
aoqi@0 72
aoqi@0 73 public static void main(String[] args) throws Exception {
aoqi@0 74 new InlinedFinallyConfuseDebuggersTest().run();
aoqi@0 75 }
aoqi@0 76
aoqi@0 77 void run() throws Exception {
aoqi@0 78 compileTestClass();
aoqi@0 79 checkClassFile(new File(Paths.get(System.getProperty("user.dir"),
aoqi@0 80 "InlinedFinallyTest.class").toUri()), methodToLookFor);
aoqi@0 81 }
aoqi@0 82
aoqi@0 83 void compileTestClass() throws Exception {
aoqi@0 84 ToolBox.JavaToolArgs javacSuccessArgs =
aoqi@0 85 new ToolBox.JavaToolArgs().setSources(testSource);
aoqi@0 86 ToolBox.javac(javacSuccessArgs);
aoqi@0 87 }
aoqi@0 88
aoqi@0 89 void checkClassFile(final File cfile, String methodToFind) throws Exception {
aoqi@0 90 ClassFile classFile = ClassFile.read(cfile);
aoqi@0 91 boolean methodFound = false;
aoqi@0 92 for (Method method : classFile.methods) {
aoqi@0 93 if (method.getName(classFile.constant_pool).equals(methodToFind)) {
aoqi@0 94 methodFound = true;
aoqi@0 95 Code_attribute code = (Code_attribute) method.attributes.get("Code");
aoqi@0 96 LineNumberTable_attribute lnt =
aoqi@0 97 (LineNumberTable_attribute) code.attributes.get("LineNumberTable");
aoqi@0 98 Assert.check(lnt.line_number_table_length == expectedLNT.length,
aoqi@0 99 "The LineNumberTable found has a length different to the expected one");
aoqi@0 100 int i = 0;
aoqi@0 101 for (LineNumberTable_attribute.Entry entry: lnt.line_number_table) {
aoqi@0 102 Assert.check(entry.line_number == expectedLNT[i][0] &&
aoqi@0 103 entry.start_pc == expectedLNT[i][1],
aoqi@0 104 "LNT entry at pos " + i + " differ from expected." +
aoqi@0 105 "Found " + entry.line_number + ":" + entry.start_pc +
aoqi@0 106 ". Expected " + expectedLNT[i][0] + ":" + expectedLNT[i][1]);
aoqi@0 107 i++;
aoqi@0 108 }
aoqi@0 109 }
aoqi@0 110 }
aoqi@0 111 Assert.check(methodFound, "The seek method was not found");
aoqi@0 112 }
aoqi@0 113
aoqi@0 114 void error(String msg) {
aoqi@0 115 throw new AssertionError(msg);
aoqi@0 116 }
aoqi@0 117
aoqi@0 118 }

mercurial