Fri, 24 Apr 2020 03:58:51 +0100
Merge
aoqi@0 | 1 | /* |
aoqi@0 | 2 | * Copyright (c) 2013, Oracle and/or its affiliates. All rights reserved. |
aoqi@0 | 3 | * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. |
aoqi@0 | 4 | * |
aoqi@0 | 5 | * This code is free software; you can redistribute it and/or modify it |
aoqi@0 | 6 | * under the terms of the GNU General Public License version 2 only, as |
aoqi@0 | 7 | * published by the Free Software Foundation. Oracle designates this |
aoqi@0 | 8 | * particular file as subject to the "Classpath" exception as provided |
aoqi@0 | 9 | * by Oracle in the LICENSE file that accompanied this code. |
aoqi@0 | 10 | * |
aoqi@0 | 11 | * This code is distributed in the hope that it will be useful, but WITHOUT |
aoqi@0 | 12 | * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or |
aoqi@0 | 13 | * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License |
aoqi@0 | 14 | * version 2 for more details (a copy is included in the LICENSE file that |
aoqi@0 | 15 | * accompanied this code). |
aoqi@0 | 16 | * |
aoqi@0 | 17 | * You should have received a copy of the GNU General Public License version |
aoqi@0 | 18 | * 2 along with this work; if not, write to the Free Software Foundation, |
aoqi@0 | 19 | * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. |
aoqi@0 | 20 | * |
aoqi@0 | 21 | * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA |
aoqi@0 | 22 | * or visit www.oracle.com if you need additional information or have any |
aoqi@0 | 23 | * questions. |
aoqi@0 | 24 | */ |
aoqi@0 | 25 | |
aoqi@0 | 26 | /* |
aoqi@0 | 27 | * @test |
aoqi@0 | 28 | * @bug 8022186 |
aoqi@0 | 29 | * @summary javac generates dead code if a try with an empty body has a finalizer |
aoqi@0 | 30 | */ |
aoqi@0 | 31 | |
aoqi@0 | 32 | import com.sun.tools.classfile.Attribute; |
aoqi@0 | 33 | import com.sun.tools.classfile.ClassFile; |
aoqi@0 | 34 | import com.sun.tools.classfile.Code_attribute; |
aoqi@0 | 35 | import com.sun.tools.classfile.ConstantPool; |
aoqi@0 | 36 | import com.sun.tools.classfile.ConstantPool.CONSTANT_String_info; |
aoqi@0 | 37 | import com.sun.tools.classfile.ConstantPool.CPInfo; |
aoqi@0 | 38 | import com.sun.tools.classfile.ConstantPool.InvalidIndex; |
aoqi@0 | 39 | import com.sun.tools.classfile.Instruction; |
aoqi@0 | 40 | import com.sun.tools.classfile.Instruction.KindVisitor; |
aoqi@0 | 41 | import com.sun.tools.classfile.Instruction.TypeKind; |
aoqi@0 | 42 | import com.sun.tools.classfile.Method; |
aoqi@0 | 43 | import com.sun.tools.javac.util.Assert; |
aoqi@0 | 44 | import java.io.BufferedInputStream; |
aoqi@0 | 45 | import java.nio.file.Files; |
aoqi@0 | 46 | import java.nio.file.Path; |
aoqi@0 | 47 | import java.nio.file.Paths; |
aoqi@0 | 48 | |
aoqi@0 | 49 | public class DeadCodeGeneratedForEmptyTryTest { |
aoqi@0 | 50 | |
aoqi@0 | 51 | public static void main(String[] args) throws Exception { |
aoqi@0 | 52 | new DeadCodeGeneratedForEmptyTryTest().run(); |
aoqi@0 | 53 | } |
aoqi@0 | 54 | |
aoqi@0 | 55 | void run() throws Exception { |
aoqi@0 | 56 | checkClassFile(Paths.get(System.getProperty("test.classes"), |
aoqi@0 | 57 | this.getClass().getName() + "$Test.class")); |
aoqi@0 | 58 | } |
aoqi@0 | 59 | |
aoqi@0 | 60 | int utf8Index; |
aoqi@0 | 61 | int numberOfRefToStr = 0; |
aoqi@0 | 62 | ConstantPool constantPool; |
aoqi@0 | 63 | |
aoqi@0 | 64 | void checkClassFile(final Path path) throws Exception { |
aoqi@0 | 65 | ClassFile classFile = ClassFile.read( |
aoqi@0 | 66 | new BufferedInputStream(Files.newInputStream(path))); |
aoqi@0 | 67 | constantPool = classFile.constant_pool; |
aoqi@0 | 68 | utf8Index = constantPool.getUTF8Index("STR_TO_LOOK_FOR"); |
aoqi@0 | 69 | for (Method method: classFile.methods) { |
aoqi@0 | 70 | if (method.getName(constantPool).equals("methodToLookFor")) { |
aoqi@0 | 71 | Code_attribute codeAtt = (Code_attribute)method.attributes.get(Attribute.Code); |
aoqi@0 | 72 | for (Instruction inst: codeAtt.getInstructions()) { |
aoqi@0 | 73 | inst.accept(codeVisitor, null); |
aoqi@0 | 74 | } |
aoqi@0 | 75 | } |
aoqi@0 | 76 | } |
aoqi@0 | 77 | Assert.check(numberOfRefToStr == 1, |
aoqi@0 | 78 | "There should only be one reference to a CONSTANT_String_info structure in the generated code"); |
aoqi@0 | 79 | } |
aoqi@0 | 80 | |
aoqi@0 | 81 | CodeVisitor codeVisitor = new CodeVisitor(); |
aoqi@0 | 82 | |
aoqi@0 | 83 | class CodeVisitor implements KindVisitor<Void, Void> { |
aoqi@0 | 84 | |
aoqi@0 | 85 | void checkIndirectRefToString(int cp_index) { |
aoqi@0 | 86 | try { |
aoqi@0 | 87 | CPInfo cInfo = constantPool.get(cp_index); |
aoqi@0 | 88 | if (cInfo instanceof CONSTANT_String_info) { |
aoqi@0 | 89 | CONSTANT_String_info strInfo = (CONSTANT_String_info)cInfo; |
aoqi@0 | 90 | if (strInfo.string_index == utf8Index) { |
aoqi@0 | 91 | numberOfRefToStr++; |
aoqi@0 | 92 | } |
aoqi@0 | 93 | } |
aoqi@0 | 94 | } catch (InvalidIndex ex) { |
aoqi@0 | 95 | throw new AssertionError("invalid constant pool index at " + cp_index); |
aoqi@0 | 96 | } |
aoqi@0 | 97 | } |
aoqi@0 | 98 | |
aoqi@0 | 99 | @Override |
aoqi@0 | 100 | public Void visitNoOperands(Instruction instr, Void p) { |
aoqi@0 | 101 | return null; |
aoqi@0 | 102 | } |
aoqi@0 | 103 | |
aoqi@0 | 104 | @Override |
aoqi@0 | 105 | public Void visitArrayType(Instruction instr, TypeKind kind, Void p) { |
aoqi@0 | 106 | return null; |
aoqi@0 | 107 | } |
aoqi@0 | 108 | |
aoqi@0 | 109 | @Override |
aoqi@0 | 110 | public Void visitBranch(Instruction instr, int offset, Void p) { |
aoqi@0 | 111 | return null; |
aoqi@0 | 112 | } |
aoqi@0 | 113 | |
aoqi@0 | 114 | @Override |
aoqi@0 | 115 | public Void visitConstantPoolRef(Instruction instr, int index, Void p) { |
aoqi@0 | 116 | checkIndirectRefToString(index); |
aoqi@0 | 117 | return null; |
aoqi@0 | 118 | } |
aoqi@0 | 119 | |
aoqi@0 | 120 | @Override |
aoqi@0 | 121 | public Void visitConstantPoolRefAndValue(Instruction instr, int index, int value, Void p) { |
aoqi@0 | 122 | checkIndirectRefToString(index); |
aoqi@0 | 123 | return null; |
aoqi@0 | 124 | } |
aoqi@0 | 125 | |
aoqi@0 | 126 | @Override |
aoqi@0 | 127 | public Void visitLocal(Instruction instr, int index, Void p) { |
aoqi@0 | 128 | return null; |
aoqi@0 | 129 | } |
aoqi@0 | 130 | |
aoqi@0 | 131 | @Override |
aoqi@0 | 132 | public Void visitLocalAndValue(Instruction instr, int index, int value, Void p) { |
aoqi@0 | 133 | return null; |
aoqi@0 | 134 | } |
aoqi@0 | 135 | |
aoqi@0 | 136 | @Override |
aoqi@0 | 137 | public Void visitLookupSwitch(Instruction instr, int default_, int npairs, int[] matches, int[] offsets, Void p) { |
aoqi@0 | 138 | return null; |
aoqi@0 | 139 | } |
aoqi@0 | 140 | |
aoqi@0 | 141 | @Override |
aoqi@0 | 142 | public Void visitTableSwitch(Instruction instr, int default_, int low, int high, int[] offsets, Void p) { |
aoqi@0 | 143 | return null; |
aoqi@0 | 144 | } |
aoqi@0 | 145 | |
aoqi@0 | 146 | @Override |
aoqi@0 | 147 | public Void visitValue(Instruction instr, int value, Void p) { |
aoqi@0 | 148 | return null; |
aoqi@0 | 149 | } |
aoqi@0 | 150 | |
aoqi@0 | 151 | @Override |
aoqi@0 | 152 | public Void visitUnknown(Instruction instr, Void p) { |
aoqi@0 | 153 | return null; |
aoqi@0 | 154 | } |
aoqi@0 | 155 | |
aoqi@0 | 156 | } |
aoqi@0 | 157 | |
aoqi@0 | 158 | public class Test { |
aoqi@0 | 159 | void methodToLookFor() { |
aoqi@0 | 160 | try { |
aoqi@0 | 161 | } finally { |
aoqi@0 | 162 | System.out.println("STR_TO_LOOK_FOR"); |
aoqi@0 | 163 | } |
aoqi@0 | 164 | } |
aoqi@0 | 165 | } |
aoqi@0 | 166 | } |