8166742: SIGFPE in C2 Loop IV elimination

Thu, 07 Sep 2017 09:21:05 -0400

author
dbuck
date
Thu, 07 Sep 2017 09:21:05 -0400
changeset 8895
8a06805fcf5d
parent 8894
440fd98d0bd1
child 8896
c89173159237

8166742: SIGFPE in C2 Loop IV elimination
Reviewed-by: kvn

src/share/vm/opto/loopnode.cpp file | annotate | diff | comparison | revisions
test/compiler/loopopts/TestImpossibleIV.java file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/vm/opto/loopnode.cpp	Thu Sep 07 09:17:43 2017 -0400
     1.2 +++ b/src/share/vm/opto/loopnode.cpp	Thu Sep 07 09:21:05 2017 -0400
     1.3 @@ -1,5 +1,5 @@
     1.4  /*
     1.5 - * Copyright (c) 1998, 2014, Oracle and/or its affiliates. All rights reserved.
     1.6 + * Copyright (c) 1998, 2017, Oracle and/or its affiliates. All rights reserved.
     1.7   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     1.8   *
     1.9   * This code is free software; you can redistribute it and/or modify it
    1.10 @@ -1773,6 +1773,12 @@
    1.11      Node *init2 = phi2->in( LoopNode::EntryControl );
    1.12      int stride_con2 = incr2->in(2)->get_int();
    1.13  
    1.14 +    // The ratio of the two strides cannot be represented as an int
    1.15 +    // if stride_con2 is min_int and stride_con is -1.
    1.16 +    if (stride_con2 == min_jint && stride_con == -1) {
    1.17 +      continue;
    1.18 +    }
    1.19 +
    1.20      // The general case here gets a little tricky.  We want to find the
    1.21      // GCD of all possible parallel IV's and make a new IV using this
    1.22      // GCD for the loop.  Then all possible IVs are simple multiples of
     2.1 --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
     2.2 +++ b/test/compiler/loopopts/TestImpossibleIV.java	Thu Sep 07 09:21:05 2017 -0400
     2.3 @@ -0,0 +1,51 @@
     2.4 +/*
     2.5 + * Copyright 2016 Google, Inc.  All Rights Reserved.
     2.6 + * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.7 + *
     2.8 + * This code is free software; you can redistribute it and/or modify it
     2.9 + * under the terms of the GNU General Public License version 2 only, as
    2.10 + * published by the Free Software Foundation.
    2.11 + *
    2.12 + * This code is distributed in the hope that it will be useful, but WITHOUT
    2.13 + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    2.14 + * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    2.15 + * version 2 for more details (a copy is included in the LICENSE file that
    2.16 + * accompanied this code).
    2.17 + *
    2.18 + * You should have received a copy of the GNU General Public License version
    2.19 + * 2 along with this work; if not, write to the Free Software Foundation,
    2.20 + * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    2.21 + *
    2.22 + * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    2.23 + * or visit www.oracle.com if you need additional information or have any
    2.24 + * questions.
    2.25 + */
    2.26 +
    2.27 +/*
    2.28 + * @test
    2.29 + * @bug 8166742
    2.30 + * @summary C2 IV elimination throws FPE
    2.31 + * @run main/othervm -XX:-TieredCompilation -XX:-BackgroundCompilation TestImpossibleIV
    2.32 + * @author Chuck Rasbold rasbold@google.com
    2.33 + */
    2.34 +
    2.35 +/*
    2.36 + * Use -XX:-TieredCompilation to get C2 only.
    2.37 + * Use -XX:-BackgroundCompilation to wait for compilation before test exit.
    2.38 + */
    2.39 +
    2.40 +public class TestImpossibleIV {
    2.41 +
    2.42 +  static private void testMethod() {
    2.43 +    int sum = 0;
    2.44 +    // A unit count-down loop which has an induction variable with
    2.45 +    // MIN_VALUE stride.
    2.46 +    for (int i = 100000; i >= 0; i--) {
    2.47 +      sum += Integer.MIN_VALUE;
    2.48 +    }
    2.49 +  }
    2.50 +
    2.51 +  public static void main(String[] args) {
    2.52 +    testMethod();
    2.53 +  }
    2.54 +}

mercurial