7146354: Re-enable Compressed OOPs after 7118647 is resolved

Thu, 16 Feb 2012 15:52:01 -0500

author
coleenp
date
Thu, 16 Feb 2012 15:52:01 -0500
changeset 3561
7df3125953cb
parent 3559
f1cb6f9cfe21
child 3562
df4927a3b82e

7146354: Re-enable Compressed OOPs after 7118647 is resolved
Summary: Relax the assertion to simply check for COOP mode rather than an exact address.
Reviewed-by: coleenp, kvn, phh, dcubed
Contributed-by: james.melvin@oracle.com

src/share/vm/runtime/arguments.cpp file | annotate | diff | comparison | revisions
src/share/vm/runtime/virtualspace.cpp file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/vm/runtime/arguments.cpp	Wed Feb 15 12:17:30 2012 -0800
     1.2 +++ b/src/share/vm/runtime/arguments.cpp	Thu Feb 16 15:52:01 2012 -0500
     1.3 @@ -1370,12 +1370,9 @@
     1.4    // by ergonomics.
     1.5    if (MaxHeapSize <= max_heap_for_compressed_oops()) {
     1.6  #if !defined(COMPILER1) || defined(TIERED)
     1.7 -// disable UseCompressedOops by default on MacOS X until 7118647 is fixed
     1.8 -#ifndef __APPLE__
     1.9      if (FLAG_IS_DEFAULT(UseCompressedOops)) {
    1.10        FLAG_SET_ERGO(bool, UseCompressedOops, true);
    1.11      }
    1.12 -#endif // !__APPLE__
    1.13  #endif
    1.14  #ifdef _WIN64
    1.15      if (UseLargePages && UseCompressedOops) {
     2.1 --- a/src/share/vm/runtime/virtualspace.cpp	Wed Feb 15 12:17:30 2012 -0800
     2.2 +++ b/src/share/vm/runtime/virtualspace.cpp	Thu Feb 16 15:52:01 2012 -0500
     2.3 @@ -1,5 +1,5 @@
     2.4  /*
     2.5 - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights reserved.
     2.6 + * Copyright (c) 1997, 2012, Oracle and/or its affiliates. All rights reserved.
     2.7   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     2.8   *
     2.9   * This code is free software; you can redistribute it and/or modify it
    2.10 @@ -455,7 +455,7 @@
    2.11  
    2.12  void ReservedSpace::protect_noaccess_prefix(const size_t size) {
    2.13    assert( (_noaccess_prefix != 0) == (UseCompressedOops && _base != NULL &&
    2.14 -                                      (size_t(_base + _size) > OopEncodingHeapMax) &&
    2.15 +                                      (Universe::narrow_oop_base() != NULL) &&
    2.16                                        Universe::narrow_oop_use_implicit_null_checks()),
    2.17           "noaccess_prefix should be used only with non zero based compressed oops");
    2.18  

mercurial