8206425: .gnu_debuglink sections added unconditionally when no debuginfo is stripped

Thu, 05 Jul 2018 18:27:02 +0200

author
sgehwolf
date
Thu, 05 Jul 2018 18:27:02 +0200
changeset 9346
5ba59d58d976
parent 9344
ad057f2e3211
child 9347
06dcd58caf4a

8206425: .gnu_debuglink sections added unconditionally when no debuginfo is stripped
Summary: Only add .gnu_debuglink sections when there is some stripping done.
Reviewed-by: erikj, dholmes

make/linux/makefiles/jsig.make file | annotate | diff | comparison | revisions
make/linux/makefiles/saproc.make file | annotate | diff | comparison | revisions
make/linux/makefiles/vm.make file | annotate | diff | comparison | revisions
     1.1 --- a/make/linux/makefiles/jsig.make	Wed Jul 04 03:02:43 2018 -0400
     1.2 +++ b/make/linux/makefiles/jsig.make	Thu Jul 05 18:27:02 2018 +0200
     1.3 @@ -57,14 +57,15 @@
     1.4                           $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(EXTRA_CFLAGS) -o $@ $< -ldl
     1.5  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
     1.6  	$(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO)
     1.7 +  ifeq ($(STRIP_POLICY),all_strip)
     1.8  	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@
     1.9 -  ifeq ($(STRIP_POLICY),all_strip)
    1.10  	$(QUIETLY) $(STRIP) $@
    1.11    else
    1.12      ifeq ($(STRIP_POLICY),min_strip)
    1.13 +	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@
    1.14  	$(QUIETLY) $(STRIP) -g $@
    1.15 +    endif
    1.16      # implied else here is no stripping at all
    1.17 -    endif
    1.18    endif
    1.19    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    1.20  	$(ZIPEXE) -q -y $(LIBJSIG_DIZ) $(LIBJSIG_DEBUGINFO)
     2.1 --- a/make/linux/makefiles/saproc.make	Wed Jul 04 03:02:43 2018 -0400
     2.2 +++ b/make/linux/makefiles/saproc.make	Thu Jul 05 18:27:02 2018 +0200
     2.3 @@ -100,14 +100,15 @@
     2.4  	           -lthread_db
     2.5  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
     2.6  	$(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBSAPROC_DEBUGINFO)
     2.7 +  ifeq ($(STRIP_POLICY),all_strip)
     2.8  	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBSAPROC_DEBUGINFO) $@
     2.9 -  ifeq ($(STRIP_POLICY),all_strip)
    2.10  	$(QUIETLY) $(STRIP) $@
    2.11    else
    2.12      ifeq ($(STRIP_POLICY),min_strip)
    2.13 +	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBSAPROC_DEBUGINFO) $@
    2.14  	$(QUIETLY) $(STRIP) -g $@
    2.15 +    endif
    2.16      # implied else here is no stripping at all
    2.17 -    endif
    2.18    endif
    2.19    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    2.20  	$(ZIPEXE) -q -y $(LIBSAPROC_DIZ) $(LIBSAPROC_DEBUGINFO)
     3.1 --- a/make/linux/makefiles/vm.make	Wed Jul 04 03:02:43 2018 -0400
     3.2 +++ b/make/linux/makefiles/vm.make	Thu Jul 05 18:27:02 2018 +0200
     3.3 @@ -358,14 +358,15 @@
     3.4  
     3.5  ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1)
     3.6  	$(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJVM_DEBUGINFO)
     3.7 +  ifeq ($(STRIP_POLICY),all_strip)
     3.8  	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJVM_DEBUGINFO) $@
     3.9 -  ifeq ($(STRIP_POLICY),all_strip)
    3.10  	$(QUIETLY) $(STRIP) $@
    3.11    else
    3.12      ifeq ($(STRIP_POLICY),min_strip)
    3.13 +	$(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJVM_DEBUGINFO) $@
    3.14  	$(QUIETLY) $(STRIP) -g $@
    3.15 +    endif
    3.16      # implied else here is no stripping at all
    3.17 -    endif
    3.18    endif
    3.19    ifeq ($(ZIP_DEBUGINFO_FILES),1)
    3.20  	$(ZIPEXE) -q -y $(LIBJVM_DIZ) $(LIBJVM_DEBUGINFO)

mercurial