Thu, 08 Aug 2013 15:19:12 -0700
8019583: [TESTBUG] runtime/7107135 always passes
Summary: If java test return none zero, the value will be override by 'if' statement, the exit value will always '0' and pass. Fix by recording the result in a variable.
Reviewed-by: coleenp, dholmes, iklam
Contributed-by: yumin.qi@oracle.com
test/runtime/7107135/Test7107135.sh | file | annotate | diff | comparison | revisions |
1.1 --- a/test/runtime/7107135/Test7107135.sh Thu Aug 08 09:21:30 2013 -0700 1.2 +++ b/test/runtime/7107135/Test7107135.sh Thu Aug 08 15:19:12 2013 -0700 1.3 @@ -53,9 +53,6 @@ 1.4 fi 1.5 ;; 1.6 *) 1.7 - NULL=NUL 1.8 - PS=";" 1.9 - FS="\\" 1.10 echo "Test passed; only valid for Linux" 1.11 exit 0; 1.12 ;; 1.13 @@ -87,14 +84,16 @@ 1.14 1.15 echo 1.16 echo Test changing of stack protection: 1.17 -echo ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} Test test-rw 1.18 +echo ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} Test test-rwx 1.19 ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} Test test-rwx 1.20 +JAVA_RETVAL=$? 1.21 1.22 -if [ "$?" == "0" ] 1.23 +if [ "$JAVA_RETVAL" == "0" ] 1.24 then 1.25 echo 1.26 echo ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} TestMT test-rwx 1.27 ${TESTJAVA}${FS}bin${FS}java -cp ${THIS_DIR} TestMT test-rwx 1.28 + JAVA_RETVAL=$? 1.29 fi 1.30 1.31 -exit $? 1.32 +exit $JAVA_RETVAL