Fri, 21 Sep 2018 16:58:36 +0200
8210761: libjsig is being compiled without optimization
Reviewed-by: clanger, andrew
1.1 --- a/make/aix/makefiles/jsig.make Sat Jul 06 19:18:57 2019 +0100 1.2 +++ b/make/aix/makefiles/jsig.make Fri Sep 21 16:58:36 2018 +0200 1.3 @@ -54,10 +54,15 @@ 1.4 JSIG_DEBUG_CFLAGS = -g 1.5 endif 1.6 1.7 +# Optimize jsig lib at level -O3 unless it's a slowdebug build 1.8 +ifneq ($(DEBUG_LEVEL), slowdebug) 1.9 + JSIG_OPT_FLAGS = $(OPT_CFLAGS) 1.10 +endif 1.11 + 1.12 $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) 1.13 @echo Making signal interposition lib... 1.14 $(QUIETLY) $(CXX) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ 1.15 - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) -o $@ $< -ldl 1.16 + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(JSIG_OPT_FLAGS) -o $@ $< -ldl 1.17 1.18 #ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) 1.19 # $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO)
2.1 --- a/make/bsd/makefiles/jsig.make Sat Jul 06 19:18:57 2019 +0100 2.2 +++ b/make/bsd/makefiles/jsig.make Fri Sep 21 16:58:36 2018 +0200 2.3 @@ -59,10 +59,15 @@ 2.4 JSIG_DEBUG_CFLAGS = -g 2.5 endif 2.6 2.7 +# Optimize jsig lib at level -O3 unless it's a slowdebug build 2.8 +ifneq ($(DEBUG_LEVEL), slowdebug) 2.9 + JSIG_OPT_FLAGS = $(OPT_CFLAGS) 2.10 +endif 2.11 + 2.12 $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) 2.13 @echo Making signal interposition lib... 2.14 $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ 2.15 - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(EXTRA_CFLAGS) -o $@ $< 2.16 + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(JSIG_OPT_FLAGS) $(EXTRA_CFLAGS) -o $@ $< 2.17 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) 2.18 ifeq ($(OS_VENDOR), Darwin) 2.19 $(DSYMUTIL) $@
3.1 --- a/make/linux/makefiles/jsig.make Sat Jul 06 19:18:57 2019 +0100 3.2 +++ b/make/linux/makefiles/jsig.make Fri Sep 21 16:58:36 2018 +0200 3.3 @@ -51,10 +51,15 @@ 3.4 JSIG_DEBUG_CFLAGS = -g 3.5 endif 3.6 3.7 +# Optimize jsig lib at level -O3 unless it's a slowdebug build 3.8 +ifneq ($(DEBUG_LEVEL), slowdebug) 3.9 + JSIG_OPT_FLAGS = $(OPT_CFLAGS) 3.10 +endif 3.11 + 3.12 $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) 3.13 @echo Making signal interposition lib... 3.14 $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ 3.15 - $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(EXTRA_CFLAGS) -o $@ $< -ldl 3.16 + $(LFLAGS_JSIG) $(JSIG_DEBUG_CFLAGS) $(JSIG_OPT_FLAGS) $(EXTRA_CFLAGS) -o $@ $< -ldl 3.17 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) 3.18 ifneq ($(STRIP_POLICY),no_strip) 3.19 $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO)
4.1 --- a/make/solaris/makefiles/jsig.make Sat Jul 06 19:18:57 2019 +0100 4.2 +++ b/make/solaris/makefiles/jsig.make Fri Sep 21 16:58:36 2018 +0200 4.3 @@ -47,10 +47,15 @@ 4.4 LFLAGS_JSIG += -mt -xnolib 4.5 endif 4.6 4.7 +# Optimize jsig lib unless it's a slowdebug build 4.8 +ifneq ($(DEBUG_LEVEL), slowdebug) 4.9 + JSIG_OPT_FLAGS = -xO4 -g 4.10 +endif 4.11 + 4.12 $(LIBJSIG): $(JSIGSRCDIR)/jsig.c $(LIBJSIG_MAPFILE) 4.13 @echo Making signal interposition lib... 4.14 $(QUIETLY) $(CC) $(SYMFLAG) $(ARCHFLAG) $(SHARED_FLAG) $(PICFLAG) \ 4.15 - $(LFLAGS_JSIG) -o $@ $(JSIGSRCDIR)/jsig.c -ldl 4.16 + $(LFLAGS_JSIG) $(JSIG_OPT_FLAGS) -o $@ $(JSIGSRCDIR)/jsig.c -ldl 4.17 ifeq ($(ENABLE_FULL_DEBUG_SYMBOLS),1) 4.18 $(QUIETLY) $(OBJCOPY) --only-keep-debug $@ $(LIBJSIG_DEBUGINFO) 4.19 $(QUIETLY) $(OBJCOPY) --add-gnu-debuglink=$(LIBJSIG_DEBUGINFO) $@