6980206: G1: assert(has_undefined_max_size, "Undefined max size");

Fri, 27 Aug 2010 13:34:14 -0400

author
tonyp
date
Fri, 27 Aug 2010 13:34:14 -0400
changeset 2112
1c63587d925b
parent 2110
8e5955ddf8e4
child 2113
af586a7893cf

6980206: G1: assert(has_undefined_max_size, "Undefined max size");
Summary: An assert in the management.cpp is too strong and assumes the max size is always defined on memory pools, even when we don't need to use it.
Reviewed-by: mchung, johnc

src/share/vm/services/management.cpp file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/vm/services/management.cpp	Wed Aug 25 14:39:55 2010 -0700
     1.2 +++ b/src/share/vm/services/management.cpp	Fri Aug 27 13:34:14 2010 -0400
     1.3 @@ -785,10 +785,11 @@
     1.4      }
     1.5    }
     1.6  
     1.7 -  // In our current implementation, all pools should have
     1.8 -  // defined init and max size
     1.9 -  assert(!has_undefined_init_size, "Undefined init size");
    1.10 -  assert(!has_undefined_max_size, "Undefined max size");
    1.11 +  // In our current implementation, we make sure that all non-heap
    1.12 +  // pools have defined init and max sizes. Heap pools do not matter,
    1.13 +  // as we never use total_init and total_max for them.
    1.14 +  assert(heap || !has_undefined_init_size, "Undefined init size");
    1.15 +  assert(heap || !has_undefined_max_size,  "Undefined max size");
    1.16  
    1.17    MemoryUsage usage((heap ? InitialHeapSize : total_init),
    1.18                      total_used,

mercurial