8005002: Crash because of a raw oop in ClassLoaderData::add_dependency

Wed, 12 Dec 2012 22:41:13 +0100

author
stefank
date
Wed, 12 Dec 2012 22:41:13 +0100
changeset 4353
1b1e16471e46
parent 4352
a70c88896791
child 4355
3c433d080bae

8005002: Crash because of a raw oop in ClassLoaderData::add_dependency
Summary: Move the handelization of 'last' to a point before the GC might enter.
Reviewed-by: dholmes, sspitsyn, coleenp

src/share/vm/classfile/classLoaderData.cpp file | annotate | diff | comparison | revisions
     1.1 --- a/src/share/vm/classfile/classLoaderData.cpp	Thu Dec 13 17:27:55 2012 -0800
     1.2 +++ b/src/share/vm/classfile/classLoaderData.cpp	Wed Dec 12 22:41:13 2012 +0100
     1.3 @@ -167,16 +167,18 @@
     1.4      ok = (objArrayOop)ok->obj_at(1);
     1.5    }
     1.6  
     1.7 +  // Must handle over GC points
     1.8 +  assert (last != NULL, "dependencies should be initialized");
     1.9 +  objArrayHandle last_handle(THREAD, last);
    1.10 +
    1.11    // Create a new dependency node with fields for (class_loader or mirror, next)
    1.12    objArrayOop deps = oopFactory::new_objectArray(2, CHECK);
    1.13    deps->obj_at_put(0, dependency());
    1.14  
    1.15 -  // Must handle over more GC points
    1.16 +  // Must handle over GC points
    1.17    objArrayHandle new_dependency(THREAD, deps);
    1.18  
    1.19    // Add the dependency under lock
    1.20 -  assert (last != NULL, "dependencies should be initialized");
    1.21 -  objArrayHandle last_handle(THREAD, last);
    1.22    locked_add_dependency(last_handle, new_dependency);
    1.23  }
    1.24  

mercurial