Wed, 09 Dec 2009 16:40:45 -0800
6895383: JCK test throws NPE for method compiled with Escape Analysis
Summary: Add missing checks for MemBar nodes in EA.
Reviewed-by: never
1 /*
2 * Copyright 2000-2009 Sun Microsystems, Inc. All Rights Reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
20 * CA 95054 USA or visit www.sun.com if you need additional information or
21 * have any questions.
22 *
23 */
25 // Portions of code courtesy of Clifford Click
27 // Optimization - Graph Style
29 #include "incls/_precompiled.incl"
30 #include "incls/_ifnode.cpp.incl"
33 extern int explicit_null_checks_elided;
35 //=============================================================================
36 //------------------------------Value------------------------------------------
37 // Return a tuple for whichever arm of the IF is reachable
38 const Type *IfNode::Value( PhaseTransform *phase ) const {
39 if( !in(0) ) return Type::TOP;
40 if( phase->type(in(0)) == Type::TOP )
41 return Type::TOP;
42 const Type *t = phase->type(in(1));
43 if( t == Type::TOP ) // data is undefined
44 return TypeTuple::IFNEITHER; // unreachable altogether
45 if( t == TypeInt::ZERO ) // zero, or false
46 return TypeTuple::IFFALSE; // only false branch is reachable
47 if( t == TypeInt::ONE ) // 1, or true
48 return TypeTuple::IFTRUE; // only true branch is reachable
49 assert( t == TypeInt::BOOL, "expected boolean type" );
51 return TypeTuple::IFBOTH; // No progress
52 }
54 const RegMask &IfNode::out_RegMask() const {
55 return RegMask::Empty;
56 }
58 //------------------------------split_if---------------------------------------
59 // Look for places where we merge constants, then test on the merged value.
60 // If the IF test will be constant folded on the path with the constant, we
61 // win by splitting the IF to before the merge point.
62 static Node* split_if(IfNode *iff, PhaseIterGVN *igvn) {
63 // I could be a lot more general here, but I'm trying to squeeze this
64 // in before the Christmas '98 break so I'm gonna be kinda restrictive
65 // on the patterns I accept. CNC
67 // Look for a compare of a constant and a merged value
68 Node *i1 = iff->in(1);
69 if( !i1->is_Bool() ) return NULL;
70 BoolNode *b = i1->as_Bool();
71 Node *cmp = b->in(1);
72 if( !cmp->is_Cmp() ) return NULL;
73 i1 = cmp->in(1);
74 if( i1 == NULL || !i1->is_Phi() ) return NULL;
75 PhiNode *phi = i1->as_Phi();
76 if( phi->is_copy() ) return NULL;
77 Node *con2 = cmp->in(2);
78 if( !con2->is_Con() ) return NULL;
79 // See that the merge point contains some constants
80 Node *con1=NULL;
81 uint i4;
82 for( i4 = 1; i4 < phi->req(); i4++ ) {
83 con1 = phi->in(i4);
84 if( !con1 ) return NULL; // Do not optimize partially collapsed merges
85 if( con1->is_Con() ) break; // Found a constant
86 // Also allow null-vs-not-null checks
87 const TypePtr *tp = igvn->type(con1)->isa_ptr();
88 if( tp && tp->_ptr == TypePtr::NotNull )
89 break;
90 }
91 if( i4 >= phi->req() ) return NULL; // Found no constants
93 igvn->C->set_has_split_ifs(true); // Has chance for split-if
95 // Make sure that the compare can be constant folded away
96 Node *cmp2 = cmp->clone();
97 cmp2->set_req(1,con1);
98 cmp2->set_req(2,con2);
99 const Type *t = cmp2->Value(igvn);
100 // This compare is dead, so whack it!
101 igvn->remove_dead_node(cmp2);
102 if( !t->singleton() ) return NULL;
104 // No intervening control, like a simple Call
105 Node *r = iff->in(0);
106 if( !r->is_Region() ) return NULL;
107 if( phi->region() != r ) return NULL;
108 // No other users of the cmp/bool
109 if (b->outcnt() != 1 || cmp->outcnt() != 1) {
110 //tty->print_cr("many users of cmp/bool");
111 return NULL;
112 }
114 // Make sure we can determine where all the uses of merged values go
115 for (DUIterator_Fast jmax, j = r->fast_outs(jmax); j < jmax; j++) {
116 Node* u = r->fast_out(j);
117 if( u == r ) continue;
118 if( u == iff ) continue;
119 if( u->outcnt() == 0 ) continue; // use is dead & ignorable
120 if( !u->is_Phi() ) {
121 /*
122 if( u->is_Start() ) {
123 tty->print_cr("Region has inlined start use");
124 } else {
125 tty->print_cr("Region has odd use");
126 u->dump(2);
127 }*/
128 return NULL;
129 }
130 if( u != phi ) {
131 // CNC - do not allow any other merged value
132 //tty->print_cr("Merging another value");
133 //u->dump(2);
134 return NULL;
135 }
136 // Make sure we can account for all Phi uses
137 for (DUIterator_Fast kmax, k = u->fast_outs(kmax); k < kmax; k++) {
138 Node* v = u->fast_out(k); // User of the phi
139 // CNC - Allow only really simple patterns.
140 // In particular I disallow AddP of the Phi, a fairly common pattern
141 if( v == cmp ) continue; // The compare is OK
142 if( (v->is_ConstraintCast()) &&
143 v->in(0)->in(0) == iff )
144 continue; // CastPP/II of the IfNode is OK
145 // Disabled following code because I cannot tell if exactly one
146 // path dominates without a real dominator check. CNC 9/9/1999
147 //uint vop = v->Opcode();
148 //if( vop == Op_Phi ) { // Phi from another merge point might be OK
149 // Node *r = v->in(0); // Get controlling point
150 // if( !r ) return NULL; // Degraded to a copy
151 // // Find exactly one path in (either True or False doms, but not IFF)
152 // int cnt = 0;
153 // for( uint i = 1; i < r->req(); i++ )
154 // if( r->in(i) && r->in(i)->in(0) == iff )
155 // cnt++;
156 // if( cnt == 1 ) continue; // Exactly one of True or False guards Phi
157 //}
158 if( !v->is_Call() ) {
159 /*
160 if( v->Opcode() == Op_AddP ) {
161 tty->print_cr("Phi has AddP use");
162 } else if( v->Opcode() == Op_CastPP ) {
163 tty->print_cr("Phi has CastPP use");
164 } else if( v->Opcode() == Op_CastII ) {
165 tty->print_cr("Phi has CastII use");
166 } else {
167 tty->print_cr("Phi has use I cant be bothered with");
168 }
169 */
170 }
171 return NULL;
173 /* CNC - Cut out all the fancy acceptance tests
174 // Can we clone this use when doing the transformation?
175 // If all uses are from Phis at this merge or constants, then YES.
176 if( !v->in(0) && v != cmp ) {
177 tty->print_cr("Phi has free-floating use");
178 v->dump(2);
179 return NULL;
180 }
181 for( uint l = 1; l < v->req(); l++ ) {
182 if( (!v->in(l)->is_Phi() || v->in(l)->in(0) != r) &&
183 !v->in(l)->is_Con() ) {
184 tty->print_cr("Phi has use");
185 v->dump(2);
186 return NULL;
187 } // End of if Phi-use input is neither Phi nor Constant
188 } // End of for all inputs to Phi-use
189 */
190 } // End of for all uses of Phi
191 } // End of for all uses of Region
193 // Only do this if the IF node is in a sane state
194 if (iff->outcnt() != 2)
195 return NULL;
197 // Got a hit! Do the Mondo Hack!
198 //
199 //ABC a1c def ghi B 1 e h A C a c d f g i
200 // R - Phi - Phi - Phi Rc - Phi - Phi - Phi Rx - Phi - Phi - Phi
201 // cmp - 2 cmp - 2 cmp - 2
202 // bool bool_c bool_x
203 // if if_c if_x
204 // T F T F T F
205 // ..s.. ..t .. ..s.. ..t.. ..s.. ..t..
206 //
207 // Split the paths coming into the merge point into 2 separate groups of
208 // merges. On the left will be all the paths feeding constants into the
209 // Cmp's Phi. On the right will be the remaining paths. The Cmp's Phi
210 // will fold up into a constant; this will let the Cmp fold up as well as
211 // all the control flow. Below the original IF we have 2 control
212 // dependent regions, 's' and 't'. Now we will merge the two paths
213 // just prior to 's' and 't' from the two IFs. At least 1 path (and quite
214 // likely 2 or more) will promptly constant fold away.
215 PhaseGVN *phase = igvn;
217 // Make a region merging constants and a region merging the rest
218 uint req_c = 0;
219 for (uint ii = 1; ii < r->req(); ii++) {
220 if( phi->in(ii) == con1 ) {
221 req_c++;
222 }
223 }
224 Node *region_c = new (igvn->C, req_c + 1) RegionNode(req_c + 1);
225 Node *phi_c = con1;
226 uint len = r->req();
227 Node *region_x = new (igvn->C, len - req_c + 1) RegionNode(len - req_c + 1);
228 Node *phi_x = PhiNode::make_blank(region_x, phi);
229 for (uint i = 1, i_c = 1, i_x = 1; i < len; i++) {
230 if( phi->in(i) == con1 ) {
231 region_c->init_req( i_c++, r ->in(i) );
232 } else {
233 region_x->init_req( i_x, r ->in(i) );
234 phi_x ->init_req( i_x++, phi->in(i) );
235 }
236 }
238 // Register the new RegionNodes but do not transform them. Cannot
239 // transform until the entire Region/Phi conglomerate has been hacked
240 // as a single huge transform.
241 igvn->register_new_node_with_optimizer( region_c );
242 igvn->register_new_node_with_optimizer( region_x );
243 // Prevent the untimely death of phi_x. Currently he has no uses. He is
244 // about to get one. If this only use goes away, then phi_x will look dead.
245 // However, he will be picking up some more uses down below.
246 Node *hook = new (igvn->C, 4) Node(4);
247 hook->init_req(0, phi_x);
248 hook->init_req(1, phi_c);
249 phi_x = phase->transform( phi_x );
251 // Make the compare
252 Node *cmp_c = phase->makecon(t);
253 Node *cmp_x = cmp->clone();
254 cmp_x->set_req(1,phi_x);
255 cmp_x->set_req(2,con2);
256 cmp_x = phase->transform(cmp_x);
257 // Make the bool
258 Node *b_c = phase->transform(new (igvn->C, 2) BoolNode(cmp_c,b->_test._test));
259 Node *b_x = phase->transform(new (igvn->C, 2) BoolNode(cmp_x,b->_test._test));
260 // Make the IfNode
261 IfNode *iff_c = new (igvn->C, 2) IfNode(region_c,b_c,iff->_prob,iff->_fcnt);
262 igvn->set_type_bottom(iff_c);
263 igvn->_worklist.push(iff_c);
264 hook->init_req(2, iff_c);
266 IfNode *iff_x = new (igvn->C, 2) IfNode(region_x,b_x,iff->_prob, iff->_fcnt);
267 igvn->set_type_bottom(iff_x);
268 igvn->_worklist.push(iff_x);
269 hook->init_req(3, iff_x);
271 // Make the true/false arms
272 Node *iff_c_t = phase->transform(new (igvn->C, 1) IfTrueNode (iff_c));
273 Node *iff_c_f = phase->transform(new (igvn->C, 1) IfFalseNode(iff_c));
274 Node *iff_x_t = phase->transform(new (igvn->C, 1) IfTrueNode (iff_x));
275 Node *iff_x_f = phase->transform(new (igvn->C, 1) IfFalseNode(iff_x));
277 // Merge the TRUE paths
278 Node *region_s = new (igvn->C, 3) RegionNode(3);
279 igvn->_worklist.push(region_s);
280 region_s->init_req(1, iff_c_t);
281 region_s->init_req(2, iff_x_t);
282 igvn->register_new_node_with_optimizer( region_s );
284 // Merge the FALSE paths
285 Node *region_f = new (igvn->C, 3) RegionNode(3);
286 igvn->_worklist.push(region_f);
287 region_f->init_req(1, iff_c_f);
288 region_f->init_req(2, iff_x_f);
289 igvn->register_new_node_with_optimizer( region_f );
291 igvn->hash_delete(cmp);// Remove soon-to-be-dead node from hash table.
292 cmp->set_req(1,NULL); // Whack the inputs to cmp because it will be dead
293 cmp->set_req(2,NULL);
294 // Check for all uses of the Phi and give them a new home.
295 // The 'cmp' got cloned, but CastPP/IIs need to be moved.
296 Node *phi_s = NULL; // do not construct unless needed
297 Node *phi_f = NULL; // do not construct unless needed
298 for (DUIterator_Last i2min, i2 = phi->last_outs(i2min); i2 >= i2min; --i2) {
299 Node* v = phi->last_out(i2);// User of the phi
300 igvn->hash_delete(v); // Have to fixup other Phi users
301 igvn->_worklist.push(v);
302 uint vop = v->Opcode();
303 Node *proj = NULL;
304 if( vop == Op_Phi ) { // Remote merge point
305 Node *r = v->in(0);
306 for (uint i3 = 1; i3 < r->req(); i3++)
307 if (r->in(i3) && r->in(i3)->in(0) == iff) {
308 proj = r->in(i3);
309 break;
310 }
311 } else if( v->is_ConstraintCast() ) {
312 proj = v->in(0); // Controlling projection
313 } else {
314 assert( 0, "do not know how to handle this guy" );
315 }
317 Node *proj_path_data, *proj_path_ctrl;
318 if( proj->Opcode() == Op_IfTrue ) {
319 if( phi_s == NULL ) {
320 // Only construct phi_s if needed, otherwise provides
321 // interfering use.
322 phi_s = PhiNode::make_blank(region_s,phi);
323 phi_s->init_req( 1, phi_c );
324 phi_s->init_req( 2, phi_x );
325 hook->add_req(phi_s);
326 phi_s = phase->transform(phi_s);
327 }
328 proj_path_data = phi_s;
329 proj_path_ctrl = region_s;
330 } else {
331 if( phi_f == NULL ) {
332 // Only construct phi_f if needed, otherwise provides
333 // interfering use.
334 phi_f = PhiNode::make_blank(region_f,phi);
335 phi_f->init_req( 1, phi_c );
336 phi_f->init_req( 2, phi_x );
337 hook->add_req(phi_f);
338 phi_f = phase->transform(phi_f);
339 }
340 proj_path_data = phi_f;
341 proj_path_ctrl = region_f;
342 }
344 // Fixup 'v' for for the split
345 if( vop == Op_Phi ) { // Remote merge point
346 uint i;
347 for( i = 1; i < v->req(); i++ )
348 if( v->in(i) == phi )
349 break;
350 v->set_req(i, proj_path_data );
351 } else if( v->is_ConstraintCast() ) {
352 v->set_req(0, proj_path_ctrl );
353 v->set_req(1, proj_path_data );
354 } else
355 ShouldNotReachHere();
356 }
358 // Now replace the original iff's True/False with region_s/region_t.
359 // This makes the original iff go dead.
360 for (DUIterator_Last i3min, i3 = iff->last_outs(i3min); i3 >= i3min; --i3) {
361 Node* p = iff->last_out(i3);
362 assert( p->Opcode() == Op_IfTrue || p->Opcode() == Op_IfFalse, "" );
363 Node *u = (p->Opcode() == Op_IfTrue) ? region_s : region_f;
364 // Replace p with u
365 igvn->add_users_to_worklist(p);
366 for (DUIterator_Last lmin, l = p->last_outs(lmin); l >= lmin;) {
367 Node* x = p->last_out(l);
368 igvn->hash_delete(x);
369 uint uses_found = 0;
370 for( uint j = 0; j < x->req(); j++ ) {
371 if( x->in(j) == p ) {
372 x->set_req(j, u);
373 uses_found++;
374 }
375 }
376 l -= uses_found; // we deleted 1 or more copies of this edge
377 }
378 igvn->remove_dead_node(p);
379 }
381 // Force the original merge dead
382 igvn->hash_delete(r);
383 // First, remove region's dead users.
384 for (DUIterator_Last lmin, l = r->last_outs(lmin); l >= lmin;) {
385 Node* u = r->last_out(l);
386 if( u == r ) {
387 r->set_req(0, NULL);
388 } else {
389 assert(u->outcnt() == 0, "only dead users");
390 igvn->remove_dead_node(u);
391 }
392 l -= 1;
393 }
394 igvn->remove_dead_node(r);
396 // Now remove the bogus extra edges used to keep things alive
397 igvn->remove_dead_node( hook );
399 // Must return either the original node (now dead) or a new node
400 // (Do not return a top here, since that would break the uniqueness of top.)
401 return new (igvn->C, 1) ConINode(TypeInt::ZERO);
402 }
404 //------------------------------is_range_check---------------------------------
405 // Return 0 if not a range check. Return 1 if a range check and set index and
406 // offset. Return 2 if we had to negate the test. Index is NULL if the check
407 // is versus a constant.
408 int IfNode::is_range_check(Node* &range, Node* &index, jint &offset) {
409 Node* b = in(1);
410 if (b == NULL || !b->is_Bool()) return 0;
411 BoolNode* bn = b->as_Bool();
412 Node* cmp = bn->in(1);
413 if (cmp == NULL) return 0;
414 if (cmp->Opcode() != Op_CmpU) return 0;
416 Node* l = cmp->in(1);
417 Node* r = cmp->in(2);
418 int flip_test = 1;
419 if (bn->_test._test == BoolTest::le) {
420 l = cmp->in(2);
421 r = cmp->in(1);
422 flip_test = 2;
423 } else if (bn->_test._test != BoolTest::lt) {
424 return 0;
425 }
426 if (l->is_top()) return 0; // Top input means dead test
427 if (r->Opcode() != Op_LoadRange) return 0;
429 // We have recognized one of these forms:
430 // Flip 1: If (Bool[<] CmpU(l, LoadRange)) ...
431 // Flip 2: If (Bool[<=] CmpU(LoadRange, l)) ...
433 // Make sure it's a real range check by requiring an uncommon trap
434 // along the OOB path. Otherwise, it's possible that the user wrote
435 // something which optimized to look like a range check but behaves
436 // in some other way.
437 Node* iftrap = proj_out(flip_test == 2 ? true : false);
438 bool found_trap = false;
439 if (iftrap != NULL) {
440 Node* u = iftrap->unique_ctrl_out();
441 if (u != NULL) {
442 // It could be a merge point (Region) for uncommon trap.
443 if (u->is_Region()) {
444 Node* c = u->unique_ctrl_out();
445 if (c != NULL) {
446 iftrap = u;
447 u = c;
448 }
449 }
450 if (u->in(0) == iftrap && u->is_CallStaticJava()) {
451 int req = u->as_CallStaticJava()->uncommon_trap_request();
452 if (Deoptimization::trap_request_reason(req) ==
453 Deoptimization::Reason_range_check) {
454 found_trap = true;
455 }
456 }
457 }
458 }
459 if (!found_trap) return 0; // sorry, no cigar
461 // Look for index+offset form
462 Node* ind = l;
463 jint off = 0;
464 if (l->is_top()) {
465 return 0;
466 } else if (l->is_Add()) {
467 if ((off = l->in(1)->find_int_con(0)) != 0) {
468 ind = l->in(2);
469 } else if ((off = l->in(2)->find_int_con(0)) != 0) {
470 ind = l->in(1);
471 }
472 } else if ((off = l->find_int_con(-1)) >= 0) {
473 // constant offset with no variable index
474 ind = NULL;
475 } else {
476 // variable index with no constant offset (or dead negative index)
477 off = 0;
478 }
480 // Return all the values:
481 index = ind;
482 offset = off;
483 range = r;
484 return flip_test;
485 }
487 //------------------------------adjust_check-----------------------------------
488 // Adjust (widen) a prior range check
489 static void adjust_check(Node* proj, Node* range, Node* index,
490 int flip, jint off_lo, PhaseIterGVN* igvn) {
491 PhaseGVN *gvn = igvn;
492 // Break apart the old check
493 Node *iff = proj->in(0);
494 Node *bol = iff->in(1);
495 if( bol->is_top() ) return; // In case a partially dead range check appears
496 // bail (or bomb[ASSERT/DEBUG]) if NOT projection-->IfNode-->BoolNode
497 DEBUG_ONLY( if( !bol->is_Bool() ) { proj->dump(3); fatal("Expect projection-->IfNode-->BoolNode"); } )
498 if( !bol->is_Bool() ) return;
500 Node *cmp = bol->in(1);
501 // Compute a new check
502 Node *new_add = gvn->intcon(off_lo);
503 if( index ) {
504 new_add = off_lo ? gvn->transform(new (gvn->C, 3) AddINode( index, new_add )) : index;
505 }
506 Node *new_cmp = (flip == 1)
507 ? new (gvn->C, 3) CmpUNode( new_add, range )
508 : new (gvn->C, 3) CmpUNode( range, new_add );
509 new_cmp = gvn->transform(new_cmp);
510 // See if no need to adjust the existing check
511 if( new_cmp == cmp ) return;
512 // Else, adjust existing check
513 Node *new_bol = gvn->transform( new (gvn->C, 2) BoolNode( new_cmp, bol->as_Bool()->_test._test ) );
514 igvn->hash_delete( iff );
515 iff->set_req_X( 1, new_bol, igvn );
516 }
518 //------------------------------up_one_dom-------------------------------------
519 // Walk up the dominator tree one step. Return NULL at root or true
520 // complex merges. Skips through small diamonds.
521 Node* IfNode::up_one_dom(Node *curr, bool linear_only) {
522 Node *dom = curr->in(0);
523 if( !dom ) // Found a Region degraded to a copy?
524 return curr->nonnull_req(); // Skip thru it
526 if( curr != dom ) // Normal walk up one step?
527 return dom;
529 // Use linear_only if we are still parsing, since we cannot
530 // trust the regions to be fully filled in.
531 if (linear_only)
532 return NULL;
534 // Else hit a Region. Check for a loop header
535 if( dom->is_Loop() )
536 return dom->in(1); // Skip up thru loops
538 // Check for small diamonds
539 Node *din1, *din2, *din3, *din4;
540 if( dom->req() == 3 && // 2-path merge point
541 (din1 = dom ->in(1)) && // Left path exists
542 (din2 = dom ->in(2)) && // Right path exists
543 (din3 = din1->in(0)) && // Left path up one
544 (din4 = din2->in(0)) ) { // Right path up one
545 if( din3->is_Call() && // Handle a slow-path call on either arm
546 (din3 = din3->in(0)) )
547 din3 = din3->in(0);
548 if( din4->is_Call() && // Handle a slow-path call on either arm
549 (din4 = din4->in(0)) )
550 din4 = din4->in(0);
551 if( din3 == din4 && din3->is_If() )
552 return din3; // Skip around diamonds
553 }
555 // Give up the search at true merges
556 return NULL; // Dead loop? Or hit root?
557 }
560 //------------------------------filtered_int_type--------------------------------
561 // Return a possibly more restrictive type for val based on condition control flow for an if
562 const TypeInt* IfNode::filtered_int_type(PhaseGVN* gvn, Node *val, Node* if_proj) {
563 assert(if_proj &&
564 (if_proj->Opcode() == Op_IfTrue || if_proj->Opcode() == Op_IfFalse), "expecting an if projection");
565 if (if_proj->in(0) && if_proj->in(0)->is_If()) {
566 IfNode* iff = if_proj->in(0)->as_If();
567 if (iff->in(1) && iff->in(1)->is_Bool()) {
568 BoolNode* bol = iff->in(1)->as_Bool();
569 if (bol->in(1) && bol->in(1)->is_Cmp()) {
570 const CmpNode* cmp = bol->in(1)->as_Cmp();
571 if (cmp->in(1) == val) {
572 const TypeInt* cmp2_t = gvn->type(cmp->in(2))->isa_int();
573 if (cmp2_t != NULL) {
574 jint lo = cmp2_t->_lo;
575 jint hi = cmp2_t->_hi;
576 BoolTest::mask msk = if_proj->Opcode() == Op_IfTrue ? bol->_test._test : bol->_test.negate();
577 switch (msk) {
578 case BoolTest::ne:
579 // Can't refine type
580 return NULL;
581 case BoolTest::eq:
582 return cmp2_t;
583 case BoolTest::lt:
584 lo = TypeInt::INT->_lo;
585 if (hi - 1 < hi) {
586 hi = hi - 1;
587 }
588 break;
589 case BoolTest::le:
590 lo = TypeInt::INT->_lo;
591 break;
592 case BoolTest::gt:
593 if (lo + 1 > lo) {
594 lo = lo + 1;
595 }
596 hi = TypeInt::INT->_hi;
597 break;
598 case BoolTest::ge:
599 // lo unchanged
600 hi = TypeInt::INT->_hi;
601 break;
602 }
603 const TypeInt* rtn_t = TypeInt::make(lo, hi, cmp2_t->_widen);
604 return rtn_t;
605 }
606 }
607 }
608 }
609 }
610 return NULL;
611 }
613 //------------------------------fold_compares----------------------------
614 // See if a pair of CmpIs can be converted into a CmpU. In some cases
615 // the direction of this if is determined by the preceding if so it
616 // can be eliminate entirely. Given an if testing (CmpI n c) check
617 // for an immediately control dependent if that is testing (CmpI n c2)
618 // and has one projection leading to this if and the other projection
619 // leading to a region that merges one of this ifs control
620 // projections.
621 //
622 // If
623 // / |
624 // / |
625 // / |
626 // If |
627 // /\ |
628 // / \ |
629 // / \ |
630 // / Region
631 //
632 Node* IfNode::fold_compares(PhaseGVN* phase) {
633 if (!EliminateAutoBox || Opcode() != Op_If) return NULL;
635 Node* this_cmp = in(1)->in(1);
636 if (this_cmp != NULL && this_cmp->Opcode() == Op_CmpI &&
637 this_cmp->in(2)->is_Con() && this_cmp->in(2) != phase->C->top()) {
638 Node* ctrl = in(0);
639 BoolNode* this_bool = in(1)->as_Bool();
640 Node* n = this_cmp->in(1);
641 int hi = this_cmp->in(2)->get_int();
642 if (ctrl != NULL && ctrl->is_Proj() && ctrl->outcnt() == 1 &&
643 ctrl->in(0)->is_If() &&
644 ctrl->in(0)->outcnt() == 2 &&
645 ctrl->in(0)->in(1)->is_Bool() &&
646 ctrl->in(0)->in(1)->in(1)->Opcode() == Op_CmpI &&
647 ctrl->in(0)->in(1)->in(1)->in(2)->is_Con() &&
648 ctrl->in(0)->in(1)->in(1)->in(1) == n) {
649 IfNode* dom_iff = ctrl->in(0)->as_If();
650 Node* otherproj = dom_iff->proj_out(!ctrl->as_Proj()->_con);
651 if (otherproj->outcnt() == 1 && otherproj->unique_out()->is_Region() &&
652 this_bool->_test._test != BoolTest::ne && this_bool->_test._test != BoolTest::eq) {
653 // Identify which proj goes to the region and which continues on
654 RegionNode* region = otherproj->unique_out()->as_Region();
655 Node* success = NULL;
656 Node* fail = NULL;
657 for (int i = 0; i < 2; i++) {
658 Node* proj = proj_out(i);
659 if (success == NULL && proj->outcnt() == 1 && proj->unique_out() == region) {
660 success = proj;
661 } else if (fail == NULL) {
662 fail = proj;
663 } else {
664 success = fail = NULL;
665 }
666 }
667 if (success != NULL && fail != NULL && !region->has_phi()) {
668 int lo = dom_iff->in(1)->in(1)->in(2)->get_int();
669 BoolNode* dom_bool = dom_iff->in(1)->as_Bool();
670 Node* dom_cmp = dom_bool->in(1);
671 const TypeInt* failtype = filtered_int_type(phase, n, ctrl);
672 if (failtype != NULL) {
673 const TypeInt* type2 = filtered_int_type(phase, n, fail);
674 if (type2 != NULL) {
675 failtype = failtype->join(type2)->is_int();
676 } else {
677 failtype = NULL;
678 }
679 }
681 if (failtype != NULL &&
682 dom_bool->_test._test != BoolTest::ne && dom_bool->_test._test != BoolTest::eq) {
683 int bound = failtype->_hi - failtype->_lo + 1;
684 if (failtype->_hi != max_jint && failtype->_lo != min_jint && bound > 1) {
685 // Merge the two compares into a single unsigned compare by building (CmpU (n - lo) hi)
686 BoolTest::mask cond = fail->as_Proj()->_con ? BoolTest::lt : BoolTest::ge;
687 Node* adjusted = phase->transform(new (phase->C, 3) SubINode(n, phase->intcon(failtype->_lo)));
688 Node* newcmp = phase->transform(new (phase->C, 3) CmpUNode(adjusted, phase->intcon(bound)));
689 Node* newbool = phase->transform(new (phase->C, 2) BoolNode(newcmp, cond));
690 phase->hash_delete(dom_iff);
691 dom_iff->set_req(1, phase->intcon(ctrl->as_Proj()->_con));
692 phase->is_IterGVN()->_worklist.push(dom_iff);
693 phase->hash_delete(this);
694 set_req(1, newbool);
695 return this;
696 }
697 if (failtype->_lo > failtype->_hi) {
698 // previous if determines the result of this if so
699 // replace Bool with constant
700 phase->hash_delete(this);
701 set_req(1, phase->intcon(success->as_Proj()->_con));
702 return this;
703 }
704 }
705 }
706 }
707 }
708 }
709 return NULL;
710 }
712 //------------------------------remove_useless_bool----------------------------
713 // Check for people making a useless boolean: things like
714 // if( (x < y ? true : false) ) { ... }
715 // Replace with if( x < y ) { ... }
716 static Node *remove_useless_bool(IfNode *iff, PhaseGVN *phase) {
717 Node *i1 = iff->in(1);
718 if( !i1->is_Bool() ) return NULL;
719 BoolNode *bol = i1->as_Bool();
721 Node *cmp = bol->in(1);
722 if( cmp->Opcode() != Op_CmpI ) return NULL;
724 // Must be comparing against a bool
725 const Type *cmp2_t = phase->type( cmp->in(2) );
726 if( cmp2_t != TypeInt::ZERO &&
727 cmp2_t != TypeInt::ONE )
728 return NULL;
730 // Find a prior merge point merging the boolean
731 i1 = cmp->in(1);
732 if( !i1->is_Phi() ) return NULL;
733 PhiNode *phi = i1->as_Phi();
734 if( phase->type( phi ) != TypeInt::BOOL )
735 return NULL;
737 // Check for diamond pattern
738 int true_path = phi->is_diamond_phi();
739 if( true_path == 0 ) return NULL;
741 // Make sure that iff and the control of the phi are different. This
742 // should really only happen for dead control flow since it requires
743 // an illegal cycle.
744 if (phi->in(0)->in(1)->in(0) == iff) return NULL;
746 // phi->region->if_proj->ifnode->bool->cmp
747 BoolNode *bol2 = phi->in(0)->in(1)->in(0)->in(1)->as_Bool();
749 // Now get the 'sense' of the test correct so we can plug in
750 // either iff2->in(1) or its complement.
751 int flip = 0;
752 if( bol->_test._test == BoolTest::ne ) flip = 1-flip;
753 else if( bol->_test._test != BoolTest::eq ) return NULL;
754 if( cmp2_t == TypeInt::ZERO ) flip = 1-flip;
756 const Type *phi1_t = phase->type( phi->in(1) );
757 const Type *phi2_t = phase->type( phi->in(2) );
758 // Check for Phi(0,1) and flip
759 if( phi1_t == TypeInt::ZERO ) {
760 if( phi2_t != TypeInt::ONE ) return NULL;
761 flip = 1-flip;
762 } else {
763 // Check for Phi(1,0)
764 if( phi1_t != TypeInt::ONE ) return NULL;
765 if( phi2_t != TypeInt::ZERO ) return NULL;
766 }
767 if( true_path == 2 ) {
768 flip = 1-flip;
769 }
771 Node* new_bol = (flip ? phase->transform( bol2->negate(phase) ) : bol2);
772 assert(new_bol != iff->in(1), "must make progress");
773 iff->set_req(1, new_bol);
774 // Intervening diamond probably goes dead
775 phase->C->set_major_progress();
776 return iff;
777 }
779 static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff);
781 //------------------------------Ideal------------------------------------------
782 // Return a node which is more "ideal" than the current node. Strip out
783 // control copies
784 Node *IfNode::Ideal(PhaseGVN *phase, bool can_reshape) {
785 if (remove_dead_region(phase, can_reshape)) return this;
786 // No Def-Use info?
787 if (!can_reshape) return NULL;
788 PhaseIterGVN *igvn = phase->is_IterGVN();
790 // Don't bother trying to transform a dead if
791 if (in(0)->is_top()) return NULL;
792 // Don't bother trying to transform an if with a dead test
793 if (in(1)->is_top()) return NULL;
794 // Another variation of a dead test
795 if (in(1)->is_Con()) return NULL;
796 // Another variation of a dead if
797 if (outcnt() < 2) return NULL;
799 // Canonicalize the test.
800 Node* idt_if = idealize_test(phase, this);
801 if (idt_if != NULL) return idt_if;
803 // Try to split the IF
804 Node *s = split_if(this, igvn);
805 if (s != NULL) return s;
807 // Check for people making a useless boolean: things like
808 // if( (x < y ? true : false) ) { ... }
809 // Replace with if( x < y ) { ... }
810 Node *bol2 = remove_useless_bool(this, phase);
811 if( bol2 ) return bol2;
813 // Setup to scan up the CFG looking for a dominating test
814 Node *dom = in(0);
815 Node *prev_dom = this;
817 // Check for range-check vs other kinds of tests
818 Node *index1, *range1;
819 jint offset1;
820 int flip1 = is_range_check(range1, index1, offset1);
821 if( flip1 ) {
822 Node *first_prev_dom = NULL;
824 // Try to remove extra range checks. All 'up_one_dom' gives up at merges
825 // so all checks we inspect post-dominate the top-most check we find.
826 // If we are going to fail the current check and we reach the top check
827 // then we are guaranteed to fail, so just start interpreting there.
828 // We 'expand' the top 2 range checks to include all post-dominating
829 // checks.
831 // The top 2 range checks seen
832 Node *prev_chk1 = NULL;
833 Node *prev_chk2 = NULL;
834 // Low and high offsets seen so far
835 jint off_lo = offset1;
836 jint off_hi = offset1;
838 // Scan for the top 2 checks and collect range of offsets
839 for( int dist = 0; dist < 999; dist++ ) { // Range-Check scan limit
840 if( dom->Opcode() == Op_If && // Not same opcode?
841 prev_dom->in(0) == dom ) { // One path of test does dominate?
842 if( dom == this ) return NULL; // dead loop
843 // See if this is a range check
844 Node *index2, *range2;
845 jint offset2;
846 int flip2 = dom->as_If()->is_range_check(range2, index2, offset2);
847 // See if this is a _matching_ range check, checking against
848 // the same array bounds.
849 if( flip2 == flip1 && range2 == range1 && index2 == index1 &&
850 dom->outcnt() == 2 ) {
851 // Gather expanded bounds
852 off_lo = MIN2(off_lo,offset2);
853 off_hi = MAX2(off_hi,offset2);
854 // Record top 2 range checks
855 prev_chk2 = prev_chk1;
856 prev_chk1 = prev_dom;
857 // If we match the test exactly, then the top test covers
858 // both our lower and upper bounds.
859 if( dom->in(1) == in(1) )
860 prev_chk2 = prev_chk1;
861 }
862 }
863 prev_dom = dom;
864 dom = up_one_dom( dom );
865 if( !dom ) break;
866 }
869 // Attempt to widen the dominating range check to cover some later
870 // ones. Since range checks "fail" by uncommon-trapping to the
871 // interpreter, widening a check can make us speculative enter the
872 // interpreter. If we see range-check deopt's, do not widen!
873 if (!phase->C->allow_range_check_smearing()) return NULL;
875 // Constant indices only need to check the upper bound.
876 // Non-constance indices must check both low and high.
877 if( index1 ) {
878 // Didn't find 2 prior covering checks, so cannot remove anything.
879 if( !prev_chk2 ) return NULL;
880 // 'Widen' the offsets of the 1st and 2nd covering check
881 adjust_check( prev_chk1, range1, index1, flip1, off_lo, igvn );
882 // Do not call adjust_check twice on the same projection
883 // as the first call may have transformed the BoolNode to a ConI
884 if( prev_chk1 != prev_chk2 ) {
885 adjust_check( prev_chk2, range1, index1, flip1, off_hi, igvn );
886 }
887 // Test is now covered by prior checks, dominate it out
888 prev_dom = prev_chk2;
889 } else {
890 // Didn't find prior covering check, so cannot remove anything.
891 if( !prev_chk1 ) return NULL;
892 // 'Widen' the offset of the 1st and only covering check
893 adjust_check( prev_chk1, range1, index1, flip1, off_hi, igvn );
894 // Test is now covered by prior checks, dominate it out
895 prev_dom = prev_chk1;
896 }
899 } else { // Scan for an equivalent test
901 Node *cmp;
902 int dist = 0; // Cutoff limit for search
903 int op = Opcode();
904 if( op == Op_If &&
905 (cmp=in(1)->in(1))->Opcode() == Op_CmpP ) {
906 if( cmp->in(2) != NULL && // make sure cmp is not already dead
907 cmp->in(2)->bottom_type() == TypePtr::NULL_PTR ) {
908 dist = 64; // Limit for null-pointer scans
909 } else {
910 dist = 4; // Do not bother for random pointer tests
911 }
912 } else {
913 dist = 4; // Limit for random junky scans
914 }
916 // Normal equivalent-test check.
917 if( !dom ) return NULL; // Dead loop?
919 Node* result = fold_compares(phase);
920 if (result != NULL) {
921 return result;
922 }
924 // Search up the dominator tree for an If with an identical test
925 while( dom->Opcode() != op || // Not same opcode?
926 dom->in(1) != in(1) || // Not same input 1?
927 (req() == 3 && dom->in(2) != in(2)) || // Not same input 2?
928 prev_dom->in(0) != dom ) { // One path of test does not dominate?
929 if( dist < 0 ) return NULL;
931 dist--;
932 prev_dom = dom;
933 dom = up_one_dom( dom );
934 if( !dom ) return NULL;
935 }
937 // Check that we did not follow a loop back to ourselves
938 if( this == dom )
939 return NULL;
941 if( dist > 2 ) // Add to count of NULL checks elided
942 explicit_null_checks_elided++;
944 } // End of Else scan for an equivalent test
946 // Hit! Remove this IF
947 #ifndef PRODUCT
948 if( TraceIterativeGVN ) {
949 tty->print(" Removing IfNode: "); this->dump();
950 }
951 if( VerifyOpto && !phase->allow_progress() ) {
952 // Found an equivalent dominating test,
953 // we can not guarantee reaching a fix-point for these during iterativeGVN
954 // since intervening nodes may not change.
955 return NULL;
956 }
957 #endif
959 // Replace dominated IfNode
960 dominated_by( prev_dom, igvn );
962 // Must return either the original node (now dead) or a new node
963 // (Do not return a top here, since that would break the uniqueness of top.)
964 return new (phase->C, 1) ConINode(TypeInt::ZERO);
965 }
967 //------------------------------dominated_by-----------------------------------
968 void IfNode::dominated_by( Node *prev_dom, PhaseIterGVN *igvn ) {
969 igvn->hash_delete(this); // Remove self to prevent spurious V-N
970 Node *idom = in(0);
971 // Need opcode to decide which way 'this' test goes
972 int prev_op = prev_dom->Opcode();
973 Node *top = igvn->C->top(); // Shortcut to top
975 // Now walk the current IfNode's projections.
976 // Loop ends when 'this' has no more uses.
977 for (DUIterator_Last imin, i = last_outs(imin); i >= imin; --i) {
978 Node *ifp = last_out(i); // Get IfTrue/IfFalse
979 igvn->add_users_to_worklist(ifp);
980 // Check which projection it is and set target.
981 // Data-target is either the dominating projection of the same type
982 // or TOP if the dominating projection is of opposite type.
983 // Data-target will be used as the new control edge for the non-CFG
984 // nodes like Casts and Loads.
985 Node *data_target = (ifp->Opcode() == prev_op ) ? prev_dom : top;
986 // Control-target is just the If's immediate dominator or TOP.
987 Node *ctrl_target = (ifp->Opcode() == prev_op ) ? idom : top;
989 // For each child of an IfTrue/IfFalse projection, reroute.
990 // Loop ends when projection has no more uses.
991 for (DUIterator_Last jmin, j = ifp->last_outs(jmin); j >= jmin; --j) {
992 Node* s = ifp->last_out(j); // Get child of IfTrue/IfFalse
993 igvn->hash_delete(s); // Yank from hash table before edge hacking
994 if( !s->depends_only_on_test() ) {
995 // Find the control input matching this def-use edge.
996 // For Regions it may not be in slot 0.
997 uint l;
998 for( l = 0; s->in(l) != ifp; l++ ) { }
999 s->set_req(l, ctrl_target);
1000 } else { // Else, for control producers,
1001 s->set_req(0, data_target); // Move child to data-target
1002 }
1003 igvn->_worklist.push(s); // Revisit collapsed Phis
1004 } // End for each child of a projection
1006 igvn->remove_dead_node(ifp);
1007 } // End for each IfTrue/IfFalse child of If
1009 // Kill the IfNode
1010 igvn->remove_dead_node(this);
1011 }
1013 //------------------------------Identity---------------------------------------
1014 // If the test is constant & we match, then we are the input Control
1015 Node *IfTrueNode::Identity( PhaseTransform *phase ) {
1016 // Can only optimize if cannot go the other way
1017 const TypeTuple *t = phase->type(in(0))->is_tuple();
1018 return ( t == TypeTuple::IFNEITHER || t == TypeTuple::IFTRUE )
1019 ? in(0)->in(0) // IfNode control
1020 : this; // no progress
1021 }
1023 //------------------------------dump_spec--------------------------------------
1024 #ifndef PRODUCT
1025 void IfNode::dump_spec(outputStream *st) const {
1026 st->print("P=%f, C=%f",_prob,_fcnt);
1027 }
1028 #endif
1030 //------------------------------idealize_test----------------------------------
1031 // Try to canonicalize tests better. Peek at the Cmp/Bool/If sequence and
1032 // come up with a canonical sequence. Bools getting 'eq', 'gt' and 'ge' forms
1033 // converted to 'ne', 'le' and 'lt' forms. IfTrue/IfFalse get swapped as
1034 // needed.
1035 static IfNode* idealize_test(PhaseGVN* phase, IfNode* iff) {
1036 assert(iff->in(0) != NULL, "If must be live");
1038 if (iff->outcnt() != 2) return NULL; // Malformed projections.
1039 Node* old_if_f = iff->proj_out(false);
1040 Node* old_if_t = iff->proj_out(true);
1042 // CountedLoopEnds want the back-control test to be TRUE, irregardless of
1043 // whether they are testing a 'gt' or 'lt' condition. The 'gt' condition
1044 // happens in count-down loops
1045 if (iff->is_CountedLoopEnd()) return NULL;
1046 if (!iff->in(1)->is_Bool()) return NULL; // Happens for partially optimized IF tests
1047 BoolNode *b = iff->in(1)->as_Bool();
1048 BoolTest bt = b->_test;
1049 // Test already in good order?
1050 if( bt.is_canonical() )
1051 return NULL;
1053 // Flip test to be canonical. Requires flipping the IfFalse/IfTrue and
1054 // cloning the IfNode.
1055 Node* new_b = phase->transform( new (phase->C, 2) BoolNode(b->in(1), bt.negate()) );
1056 if( !new_b->is_Bool() ) return NULL;
1057 b = new_b->as_Bool();
1059 PhaseIterGVN *igvn = phase->is_IterGVN();
1060 assert( igvn, "Test is not canonical in parser?" );
1062 // The IF node never really changes, but it needs to be cloned
1063 iff = new (phase->C, 2) IfNode( iff->in(0), b, 1.0-iff->_prob, iff->_fcnt);
1065 Node *prior = igvn->hash_find_insert(iff);
1066 if( prior ) {
1067 igvn->remove_dead_node(iff);
1068 iff = (IfNode*)prior;
1069 } else {
1070 // Cannot call transform on it just yet
1071 igvn->set_type_bottom(iff);
1072 }
1073 igvn->_worklist.push(iff);
1075 // Now handle projections. Cloning not required.
1076 Node* new_if_f = (Node*)(new (phase->C, 1) IfFalseNode( iff ));
1077 Node* new_if_t = (Node*)(new (phase->C, 1) IfTrueNode ( iff ));
1079 igvn->register_new_node_with_optimizer(new_if_f);
1080 igvn->register_new_node_with_optimizer(new_if_t);
1081 igvn->hash_delete(old_if_f);
1082 igvn->hash_delete(old_if_t);
1083 // Flip test, so flip trailing control
1084 igvn->subsume_node(old_if_f, new_if_t);
1085 igvn->subsume_node(old_if_t, new_if_f);
1087 // Progress
1088 return iff;
1089 }
1091 //------------------------------Identity---------------------------------------
1092 // If the test is constant & we match, then we are the input Control
1093 Node *IfFalseNode::Identity( PhaseTransform *phase ) {
1094 // Can only optimize if cannot go the other way
1095 const TypeTuple *t = phase->type(in(0))->is_tuple();
1096 return ( t == TypeTuple::IFNEITHER || t == TypeTuple::IFFALSE )
1097 ? in(0)->in(0) // IfNode control
1098 : this; // no progress
1099 }