jdk8-mips64-public/hotspot: src/share/vm/opto/locknode.cpp@f3b3fe64f59f

6692301: Side effect in NumberFormat tests with -server -Xcomp
Summary: Optimization in CmpPNode::sub() removed the valid compare instruction because of false positive answer from detect_dominating_control().
Reviewed-by: jrose, sgoldman

     1 /*

     2  * Copyright 1999-2006 Sun Microsystems, Inc.  All Rights Reserved.

     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.

     4  *

     5  * This code is free software; you can redistribute it and/or modify it

     6  * under the terms of the GNU General Public License version 2 only, as

     7  * published by the Free Software Foundation.

     8  *

     9  * This code is distributed in the hope that it will be useful, but WITHOUT

    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or

    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License

    12  * version 2 for more details (a copy is included in the LICENSE file that

    13  * accompanied this code).

    14  *

    15  * You should have received a copy of the GNU General Public License version

    16  * 2 along with this work; if not, write to the Free Software Foundation,

    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.

    18  *

    19  * Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,

    20  * CA 95054 USA or visit www.sun.com if you need additional information or

    21  * have any questions.

    22  *

    23  */

    25 #include "incls/_precompiled.incl"

    26 #include "incls/_locknode.cpp.incl"

    28 //=============================================================================

    29 const RegMask &BoxLockNode::in_RegMask(uint i) const {

    30   return _inmask;

    31 }

    33 const RegMask &BoxLockNode::out_RegMask() const {

    34   return *Matcher::idealreg2regmask[Op_RegP];

    35 }

    37 uint BoxLockNode::size_of() const { return sizeof(*this); }

    39 BoxLockNode::BoxLockNode( int slot ) : Node( Compile::current()->root() ),

    40                                        _slot(slot), _is_eliminated(false) {

    41   init_class_id(Class_BoxLock);

    42   init_flags(Flag_rematerialize);

    43   OptoReg::Name reg = OptoReg::stack2reg(_slot);

    44   _inmask.Insert(reg);

    45 }

    47 //------------------------------cmp--------------------------------------------

    48 uint BoxLockNode::cmp( const Node &n ) const {

    49   const BoxLockNode &bn = (const BoxLockNode &)n;

    50   return bn._slot == _slot;

    51 }

    53 OptoReg::Name BoxLockNode::stack_slot(Node* box_node) {

    54   // Chase down the BoxNode

    55   while (!box_node->is_BoxLock()) {

    56     //    if (box_node->is_SpillCopy()) {

    57     //      Node *m = box_node->in(1);

    58     //      if (m->is_Mach() && m->as_Mach()->ideal_Opcode() == Op_StoreP) {

    59     //        box_node = m->in(m->as_Mach()->operand_index(2));

    60     //        continue;

    61     //      }

    62     //    }

    63     assert(box_node->is_SpillCopy() || box_node->is_Phi(), "Bad spill of Lock.");

    64     box_node = box_node->in(1);

    65   }

    66   return box_node->in_RegMask(0).find_first_elem();

    67 }

    69 //=============================================================================

    70 //-----------------------------hash--------------------------------------------

    71 uint FastLockNode::hash() const { return NO_HASH; }

    73 //------------------------------cmp--------------------------------------------

    74 uint FastLockNode::cmp( const Node &n ) const {

    75   return (&n == this);                // Always fail except on self

    76 }

    78 //=============================================================================

    79 //-----------------------------hash--------------------------------------------

    80 uint FastUnlockNode::hash() const { return NO_HASH; }

    82 //------------------------------cmp--------------------------------------------

    83 uint FastUnlockNode::cmp( const Node &n ) const {

    84   return (&n == this);                // Always fail except on self

    85 }

    87 //

    88 // Create a counter which counts the number of times this lock is acquired

    89 //

    90 void FastLockNode::create_lock_counter(JVMState* state) {

    91   BiasedLockingNamedCounter* blnc = (BiasedLockingNamedCounter*)

    92            OptoRuntime::new_named_counter(state, NamedCounter::BiasedLockingCounter);

    93   _counters = blnc->counters();

    94 }

    96 //=============================================================================

    97 //------------------------------do_monitor_enter-------------------------------

    98 void Parse::do_monitor_enter() {

    99   kill_dead_locals();

   101   // Null check; get casted pointer.

   102   Node *obj = do_null_check(peek(), T_OBJECT);

   103   // Check for locking null object

   104   if (stopped()) return;

   106   // the monitor object is not part of debug info expression stack

   107   pop();

   109   // Insert a FastLockNode which takes as arguments the current thread pointer,

   110   // the obj pointer & the address of the stack slot pair used for the lock.

   111   shared_lock(obj);

   112 }

   114 //------------------------------do_monitor_exit--------------------------------

   115 void Parse::do_monitor_exit() {

   116   kill_dead_locals();

   118   pop();                        // Pop oop to unlock

   119   // Because monitors are guarenteed paired (else we bail out), we know

   120   // the matching Lock for this Unlock.  Hence we know there is no need

   121   // for a null check on Unlock.

   122   shared_unlock(map()->peek_monitor_box(), map()->peek_monitor_obj());

   123 }

Mercurial > jdk8-mips64-public > hotspot / file revision

src/share/vm/opto/locknode.cpp@f3b3fe64f59f

src/share/vm/opto/locknode.cpp