Wed, 02 Nov 2011 08:04:23 +0100
7106751: G1: gc/gctests/nativeGC03 crashes VM with SIGSEGV
Summary: _cset_rs_update_cl[] was indexed with values beyond what it is set up to handle.
Reviewed-by: ysr, jmasa, johnc
1 /*
2 * Copyright (c) 2001, 2011, Oracle and/or its affiliates. All rights reserved.
3 * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
4 *
5 * This code is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 only, as
7 * published by the Free Software Foundation.
8 *
9 * This code is distributed in the hope that it will be useful, but WITHOUT
10 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
11 * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
12 * version 2 for more details (a copy is included in the LICENSE file that
13 * accompanied this code).
14 *
15 * You should have received a copy of the GNU General Public License version
16 * 2 along with this work; if not, write to the Free Software Foundation,
17 * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
18 *
19 * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
20 * or visit www.oracle.com if you need additional information or have any
21 * questions.
22 *
23 */
25 #include "precompiled.hpp"
26 #include "gc_implementation/g1/concurrentMarkThread.inline.hpp"
27 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
28 #include "gc_implementation/g1/g1CollectorPolicy.hpp"
29 #include "gc_implementation/g1/g1MMUTracker.hpp"
30 #include "gc_implementation/g1/vm_operations_g1.hpp"
31 #include "memory/resourceArea.hpp"
32 #include "runtime/vmThread.hpp"
34 // ======= Concurrent Mark Thread ========
36 // The CM thread is created when the G1 garbage collector is used
38 SurrogateLockerThread*
39 ConcurrentMarkThread::_slt = NULL;
41 ConcurrentMarkThread::ConcurrentMarkThread(ConcurrentMark* cm) :
42 ConcurrentGCThread(),
43 _cm(cm),
44 _started(false),
45 _in_progress(false),
46 _vtime_accum(0.0),
47 _vtime_mark_accum(0.0),
48 _vtime_count_accum(0.0)
49 {
50 create_and_start();
51 }
53 class CMCheckpointRootsFinalClosure: public VoidClosure {
55 ConcurrentMark* _cm;
56 public:
58 CMCheckpointRootsFinalClosure(ConcurrentMark* cm) :
59 _cm(cm) {}
61 void do_void(){
62 _cm->checkpointRootsFinal(false); // !clear_all_soft_refs
63 }
64 };
66 class CMCleanUp: public VoidClosure {
67 ConcurrentMark* _cm;
68 public:
70 CMCleanUp(ConcurrentMark* cm) :
71 _cm(cm) {}
73 void do_void(){
74 _cm->cleanup();
75 }
76 };
80 void ConcurrentMarkThread::run() {
81 initialize_in_thread();
82 _vtime_start = os::elapsedVTime();
83 wait_for_universe_init();
85 G1CollectedHeap* g1h = G1CollectedHeap::heap();
86 G1CollectorPolicy* g1_policy = g1h->g1_policy();
87 G1MMUTracker *mmu_tracker = g1_policy->mmu_tracker();
88 Thread *current_thread = Thread::current();
90 while (!_should_terminate) {
91 // wait until started is set.
92 sleepBeforeNextCycle();
93 {
94 ResourceMark rm;
95 HandleMark hm;
96 double cycle_start = os::elapsedVTime();
97 double mark_start_sec = os::elapsedTime();
98 char verbose_str[128];
100 if (PrintGC) {
101 gclog_or_tty->date_stamp(PrintGCDateStamps);
102 gclog_or_tty->stamp(PrintGCTimeStamps);
103 gclog_or_tty->print_cr("[GC concurrent-mark-start]");
104 }
106 int iter = 0;
107 do {
108 iter++;
109 if (!cm()->has_aborted()) {
110 _cm->markFromRoots();
111 }
113 double mark_end_time = os::elapsedVTime();
114 double mark_end_sec = os::elapsedTime();
115 _vtime_mark_accum += (mark_end_time - cycle_start);
116 if (!cm()->has_aborted()) {
117 if (g1_policy->adaptive_young_list_length()) {
118 double now = os::elapsedTime();
119 double remark_prediction_ms = g1_policy->predict_remark_time_ms();
120 jlong sleep_time_ms = mmu_tracker->when_ms(now, remark_prediction_ms);
121 os::sleep(current_thread, sleep_time_ms, false);
122 }
124 if (PrintGC) {
125 gclog_or_tty->date_stamp(PrintGCDateStamps);
126 gclog_or_tty->stamp(PrintGCTimeStamps);
127 gclog_or_tty->print_cr("[GC concurrent-mark-end, %1.7lf sec]",
128 mark_end_sec - mark_start_sec);
129 }
131 CMCheckpointRootsFinalClosure final_cl(_cm);
132 sprintf(verbose_str, "GC remark");
133 VM_CGC_Operation op(&final_cl, verbose_str);
134 VMThread::execute(&op);
135 }
136 if (cm()->restart_for_overflow() &&
137 G1TraceMarkStackOverflow) {
138 gclog_or_tty->print_cr("Restarting conc marking because of MS overflow "
139 "in remark (restart #%d).", iter);
140 }
142 if (cm()->restart_for_overflow()) {
143 if (PrintGC) {
144 gclog_or_tty->date_stamp(PrintGCDateStamps);
145 gclog_or_tty->stamp(PrintGCTimeStamps);
146 gclog_or_tty->print_cr("[GC concurrent-mark-restart-for-overflow]");
147 }
148 }
149 } while (cm()->restart_for_overflow());
151 double counting_start_time = os::elapsedVTime();
152 if (!cm()->has_aborted()) {
153 double count_start_sec = os::elapsedTime();
154 if (PrintGC) {
155 gclog_or_tty->date_stamp(PrintGCDateStamps);
156 gclog_or_tty->stamp(PrintGCTimeStamps);
157 gclog_or_tty->print_cr("[GC concurrent-count-start]");
158 }
160 _sts.join();
161 _cm->calcDesiredRegions();
162 _sts.leave();
164 if (!cm()->has_aborted()) {
165 double count_end_sec = os::elapsedTime();
166 if (PrintGC) {
167 gclog_or_tty->date_stamp(PrintGCDateStamps);
168 gclog_or_tty->stamp(PrintGCTimeStamps);
169 gclog_or_tty->print_cr("[GC concurrent-count-end, %1.7lf]",
170 count_end_sec - count_start_sec);
171 }
172 }
173 }
175 double end_time = os::elapsedVTime();
176 _vtime_count_accum += (end_time - counting_start_time);
177 // Update the total virtual time before doing this, since it will try
178 // to measure it to get the vtime for this marking. We purposely
179 // neglect the presumably-short "completeCleanup" phase here.
180 _vtime_accum = (end_time - _vtime_start);
181 if (!cm()->has_aborted()) {
182 if (g1_policy->adaptive_young_list_length()) {
183 double now = os::elapsedTime();
184 double cleanup_prediction_ms = g1_policy->predict_cleanup_time_ms();
185 jlong sleep_time_ms = mmu_tracker->when_ms(now, cleanup_prediction_ms);
186 os::sleep(current_thread, sleep_time_ms, false);
187 }
189 CMCleanUp cl_cl(_cm);
190 sprintf(verbose_str, "GC cleanup");
191 VM_CGC_Operation op(&cl_cl, verbose_str);
192 VMThread::execute(&op);
193 } else {
194 g1h->set_marking_complete();
195 }
197 // Check if cleanup set the free_regions_coming flag. If it
198 // hasn't, we can just skip the next step.
199 if (g1h->free_regions_coming()) {
200 // The following will finish freeing up any regions that we
201 // found to be empty during cleanup. We'll do this part
202 // without joining the suspendible set. If an evacuation pause
203 // takes place, then we would carry on freeing regions in
204 // case they are needed by the pause. If a Full GC takes
205 // place, it would wait for us to process the regions
206 // reclaimed by cleanup.
208 double cleanup_start_sec = os::elapsedTime();
209 if (PrintGC) {
210 gclog_or_tty->date_stamp(PrintGCDateStamps);
211 gclog_or_tty->stamp(PrintGCTimeStamps);
212 gclog_or_tty->print_cr("[GC concurrent-cleanup-start]");
213 }
215 // Now do the concurrent cleanup operation.
216 _cm->completeCleanup();
218 // Notify anyone who's waiting that there are no more free
219 // regions coming. We have to do this before we join the STS
220 // (in fact, we should not attempt to join the STS in the
221 // interval between finishing the cleanup pause and clearing
222 // the free_regions_coming flag) otherwise we might deadlock:
223 // a GC worker could be blocked waiting for the notification
224 // whereas this thread will be blocked for the pause to finish
225 // while it's trying to join the STS, which is conditional on
226 // the GC workers finishing.
227 g1h->reset_free_regions_coming();
229 double cleanup_end_sec = os::elapsedTime();
230 if (PrintGC) {
231 gclog_or_tty->date_stamp(PrintGCDateStamps);
232 gclog_or_tty->stamp(PrintGCTimeStamps);
233 gclog_or_tty->print_cr("[GC concurrent-cleanup-end, %1.7lf]",
234 cleanup_end_sec - cleanup_start_sec);
235 }
236 }
237 guarantee(cm()->cleanup_list_is_empty(),
238 "at this point there should be no regions on the cleanup list");
240 // There is a tricky race before recording that the concurrent
241 // cleanup has completed and a potential Full GC starting around
242 // the same time. We want to make sure that the Full GC calls
243 // abort() on concurrent mark after
244 // record_concurrent_mark_cleanup_completed(), since abort() is
245 // the method that will reset the concurrent mark state. If we
246 // end up calling record_concurrent_mark_cleanup_completed()
247 // after abort() then we might incorrectly undo some of the work
248 // abort() did. Checking the has_aborted() flag after joining
249 // the STS allows the correct ordering of the two methods. There
250 // are two scenarios:
251 //
252 // a) If we reach here before the Full GC, the fact that we have
253 // joined the STS means that the Full GC cannot start until we
254 // leave the STS, so record_concurrent_mark_cleanup_completed()
255 // will complete before abort() is called.
256 //
257 // b) If we reach here during the Full GC, we'll be held up from
258 // joining the STS until the Full GC is done, which means that
259 // abort() will have completed and has_aborted() will return
260 // true to prevent us from calling
261 // record_concurrent_mark_cleanup_completed() (and, in fact, it's
262 // not needed any more as the concurrent mark state has been
263 // already reset).
264 _sts.join();
265 if (!cm()->has_aborted()) {
266 g1_policy->record_concurrent_mark_cleanup_completed();
267 }
268 _sts.leave();
270 if (cm()->has_aborted()) {
271 if (PrintGC) {
272 gclog_or_tty->date_stamp(PrintGCDateStamps);
273 gclog_or_tty->stamp(PrintGCTimeStamps);
274 gclog_or_tty->print_cr("[GC concurrent-mark-abort]");
275 }
276 }
278 // We now want to allow clearing of the marking bitmap to be
279 // suspended by a collection pause.
280 _sts.join();
281 _cm->clearNextBitmap();
282 _sts.leave();
283 }
285 // Update the number of full collections that have been
286 // completed. This will also notify the FullGCCount_lock in case a
287 // Java thread is waiting for a full GC to happen (e.g., it
288 // called System.gc() with +ExplicitGCInvokesConcurrent).
289 _sts.join();
290 g1h->increment_full_collections_completed(true /* concurrent */);
291 _sts.leave();
292 }
293 assert(_should_terminate, "just checking");
295 terminate();
296 }
299 void ConcurrentMarkThread::yield() {
300 _sts.yield("Concurrent Mark");
301 }
303 void ConcurrentMarkThread::stop() {
304 // it is ok to take late safepoints here, if needed
305 MutexLockerEx mu(Terminator_lock);
306 _should_terminate = true;
307 while (!_has_terminated) {
308 Terminator_lock->wait();
309 }
310 }
312 void ConcurrentMarkThread::print() const {
313 print_on(tty);
314 }
316 void ConcurrentMarkThread::print_on(outputStream* st) const {
317 st->print("\"G1 Main Concurrent Mark GC Thread\" ");
318 Thread::print_on(st);
319 st->cr();
320 }
322 void ConcurrentMarkThread::sleepBeforeNextCycle() {
323 // We join here because we don't want to do the "shouldConcurrentMark()"
324 // below while the world is otherwise stopped.
325 assert(!in_progress(), "should have been cleared");
327 MutexLockerEx x(CGC_lock, Mutex::_no_safepoint_check_flag);
328 while (!started()) {
329 CGC_lock->wait(Mutex::_no_safepoint_check_flag);
330 }
331 set_in_progress();
332 clear_started();
333 }
335 // Note: As is the case with CMS - this method, although exported
336 // by the ConcurrentMarkThread, which is a non-JavaThread, can only
337 // be called by a JavaThread. Currently this is done at vm creation
338 // time (post-vm-init) by the main/Primordial (Java)Thread.
339 // XXX Consider changing this in the future to allow the CM thread
340 // itself to create this thread?
341 void ConcurrentMarkThread::makeSurrogateLockerThread(TRAPS) {
342 assert(UseG1GC, "SLT thread needed only for concurrent GC");
343 assert(THREAD->is_Java_thread(), "must be a Java thread");
344 assert(_slt == NULL, "SLT already created");
345 _slt = SurrogateLockerThread::make(THREAD);
346 }