src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp

Fri, 10 Oct 2014 15:51:58 +0200

author
tschatzl
date
Fri, 10 Oct 2014 15:51:58 +0200
changeset 7257
e7d0505c8a30
parent 7218
6948da6d7c13
child 7535
7ae4e26cb1e0
permissions
-rw-r--r--

8059758: Footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zero out) virtual memory used for auxiliary data structures. This causes a footprint regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: jwilhelm, brutisso

     1 /*
     2  * Copyright (c) 2001, 2012, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #ifndef SHARE_VM_GC_IMPLEMENTATION_G1_G1REMSET_INLINE_HPP
    26 #define SHARE_VM_GC_IMPLEMENTATION_G1_G1REMSET_INLINE_HPP
    28 #include "gc_implementation/g1/g1RemSet.hpp"
    29 #include "gc_implementation/g1/heapRegion.hpp"
    30 #include "gc_implementation/g1/heapRegionRemSet.hpp"
    31 #include "oops/oop.inline.hpp"
    33 inline uint G1RemSet::n_workers() {
    34   if (_g1->workers() != NULL) {
    35     return _g1->workers()->total_workers();
    36   } else {
    37     return 1;
    38   }
    39 }
    41 template <class T>
    42 inline void G1RemSet::write_ref(HeapRegion* from, T* p) {
    43   par_write_ref(from, p, 0);
    44 }
    46 template <class T>
    47 inline void G1RemSet::par_write_ref(HeapRegion* from, T* p, int tid) {
    48   oop obj = oopDesc::load_decode_heap_oop(p);
    49   if (obj == NULL) {
    50     return;
    51   }
    53 #ifdef ASSERT
    54   // can't do because of races
    55   // assert(obj == NULL || obj->is_oop(), "expected an oop");
    57   // Do the safe subset of is_oop
    58 #ifdef CHECK_UNHANDLED_OOPS
    59   oopDesc* o = obj.obj();
    60 #else
    61   oopDesc* o = obj;
    62 #endif // CHECK_UNHANDLED_OOPS
    63   assert((intptr_t)o % MinObjAlignmentInBytes == 0, "not oop aligned");
    64   assert(Universe::heap()->is_in_reserved(obj), "must be in heap");
    65 #endif // ASSERT
    67   assert(from == NULL || from->is_in_reserved(p), "p is not in from");
    69   HeapRegion* to = _g1->heap_region_containing(obj);
    70   if (from != to) {
    71     assert(to->rem_set() != NULL, "Need per-region 'into' remsets.");
    72     to->rem_set()->add_reference(p, tid);
    73   }
    74 }
    76 template <class T>
    77 inline void UpdateRSOopClosure::do_oop_work(T* p) {
    78   assert(_from != NULL, "from region must be non-NULL");
    79   _rs->par_write_ref(_from, p, _worker_i);
    80 }
    82 #endif // SHARE_VM_GC_IMPLEMENTATION_G1_G1REMSET_INLINE_HPP

mercurial