src/share/vm/gc_implementation/g1/g1Log.cpp

Fri, 10 Oct 2014 15:51:58 +0200

author
tschatzl
date
Fri, 10 Oct 2014 15:51:58 +0200
changeset 7257
e7d0505c8a30
parent 0
f90c822e73f8
permissions
-rw-r--r--

8059758: Footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zero out) virtual memory used for auxiliary data structures. This causes a footprint regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: jwilhelm, brutisso

     1 /*
     2  * Copyright (c) 2012, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #include "precompiled.hpp"
    26 #include "gc_implementation/g1/g1_globals.hpp"
    27 #include "gc_implementation/g1/g1Log.hpp"
    28 #include "runtime/globals.hpp"
    30 G1Log::LogLevel G1Log::_level = G1Log::LevelNone;
    32 // If G1LogLevel has not been set up we will use the values of PrintGC
    33 // and PrintGCDetails for the logging level.
    34 // - PrintGC maps to "fine".
    35 // - PrintGCDetails maps to "finer".
    36 void G1Log::init() {
    37   if (G1LogLevel != NULL && G1LogLevel[0] != '\0') {
    38     if (strncmp("none", G1LogLevel, 4) == 0 && G1LogLevel[4] == '\0') {
    39       _level = LevelNone;
    40     } else if (strncmp("fine", G1LogLevel, 4) == 0 && G1LogLevel[4] == '\0') {
    41       _level = LevelFine;
    42     } else if (strncmp("finer", G1LogLevel, 5) == 0 && G1LogLevel[5] == '\0') {
    43       _level = LevelFiner;
    44     } else if (strncmp("finest", G1LogLevel, 6) == 0 && G1LogLevel[6] == '\0') {
    45       _level = LevelFinest;
    46     } else {
    47       warning("Unknown logging level '%s', should be one of 'fine', 'finer' or 'finest'.", G1LogLevel);
    48     }
    49   } else {
    50     if (PrintGCDetails) {
    51       _level = LevelFiner;
    52     } else if (PrintGC) {
    53       _level = LevelFine;
    54     }
    55   }
    56 }

mercurial