src/share/vm/gc_implementation/g1/g1CardCounts.cpp

Fri, 10 Oct 2014 15:51:58 +0200

author
tschatzl
date
Fri, 10 Oct 2014 15:51:58 +0200
changeset 7257
e7d0505c8a30
parent 7051
1f1d373cd044
child 7535
7ae4e26cb1e0
child 9327
f96fcd9e1e1b
permissions
-rw-r--r--

8059758: Footprint regressions with JDK-8038423
Summary: Changes in JDK-8038423 always initialize (zero out) virtual memory used for auxiliary data structures. This causes a footprint regression for G1 in startup benchmarks. This is because they do not touch that memory at all, so the operating system does not actually commit these pages. The fix is to, if the initialization value of the data structures matches the default value of just committed memory (=0), do not do anything.
Reviewed-by: jwilhelm, brutisso

     1 /*
     2  * Copyright (c) 2013, 2014, Oracle and/or its affiliates. All rights reserved.
     3  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
     4  *
     5  * This code is free software; you can redistribute it and/or modify it
     6  * under the terms of the GNU General Public License version 2 only, as
     7  * published by the Free Software Foundation.
     8  *
     9  * This code is distributed in the hope that it will be useful, but WITHOUT
    10  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
    11  * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
    12  * version 2 for more details (a copy is included in the LICENSE file that
    13  * accompanied this code).
    14  *
    15  * You should have received a copy of the GNU General Public License version
    16  * 2 along with this work; if not, write to the Free Software Foundation,
    17  * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
    18  *
    19  * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
    20  * or visit www.oracle.com if you need additional information or have any
    21  * questions.
    22  *
    23  */
    25 #include "precompiled.hpp"
    26 #include "gc_implementation/g1/g1CardCounts.hpp"
    27 #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
    28 #include "gc_implementation/g1/g1CollectorPolicy.hpp"
    29 #include "gc_implementation/g1/g1GCPhaseTimes.hpp"
    30 #include "memory/cardTableModRefBS.hpp"
    31 #include "services/memTracker.hpp"
    32 #include "utilities/copy.hpp"
    34 PRAGMA_FORMAT_MUTE_WARNINGS_FOR_GCC
    36 void G1CardCountsMappingChangedListener::on_commit(uint start_idx, size_t num_regions, bool zero_filled) {
    37   if (zero_filled) {
    38     return;
    39   }
    40   MemRegion mr(G1CollectedHeap::heap()->bottom_addr_for_region(start_idx), num_regions * HeapRegion::GrainWords);
    41   _counts->clear_range(mr);
    42 }
    44 void G1CardCounts::clear_range(size_t from_card_num, size_t to_card_num) {
    45   if (has_count_table()) {
    46     assert(from_card_num < to_card_num,
    47            err_msg("Wrong order? from: " SIZE_FORMAT ", to: "SIZE_FORMAT,
    48                    from_card_num, to_card_num));
    49     Copy::fill_to_bytes(&_card_counts[from_card_num], (to_card_num - from_card_num));
    50   }
    51 }
    53 G1CardCounts::G1CardCounts(G1CollectedHeap *g1h):
    54   _listener(), _g1h(g1h), _card_counts(NULL), _reserved_max_card_num(0) {
    55   _listener.set_cardcounts(this);
    56 }
    58 void G1CardCounts::initialize(G1RegionToSpaceMapper* mapper) {
    59   assert(_g1h->max_capacity() > 0, "initialization order");
    60   assert(_g1h->capacity() == 0, "initialization order");
    62   if (G1ConcRSHotCardLimit > 0) {
    63     // The max value we can store in the counts table is
    64     // max_jubyte. Guarantee the value of the hot
    65     // threshold limit is no more than this.
    66     guarantee(G1ConcRSHotCardLimit <= max_jubyte, "sanity");
    68     _ct_bs = _g1h->g1_barrier_set();
    69     _ct_bot = _ct_bs->byte_for_const(_g1h->reserved_region().start());
    71     _card_counts = (jubyte*) mapper->reserved().start();
    72     _reserved_max_card_num = mapper->reserved().byte_size();
    73     mapper->set_mapping_changed_listener(&_listener);
    74   }
    75 }
    77 uint G1CardCounts::add_card_count(jbyte* card_ptr) {
    78   // Returns the number of times the card has been refined.
    79   // If we failed to reserve/commit the counts table, return 0.
    80   // If card_ptr is beyond the committed end of the counts table,
    81   // return 0.
    82   // Otherwise return the actual count.
    83   // Unless G1ConcRSHotCardLimit has been set appropriately,
    84   // returning 0 will result in the card being considered
    85   // cold and will be refined immediately.
    86   uint count = 0;
    87   if (has_count_table()) {
    88     size_t card_num = ptr_2_card_num(card_ptr);
    89     assert(card_num < _reserved_max_card_num,
    90            err_msg("Card "SIZE_FORMAT" outside of card counts table (max size "SIZE_FORMAT")",
    91                    card_num, _reserved_max_card_num));
    92     count = (uint) _card_counts[card_num];
    93     if (count < G1ConcRSHotCardLimit) {
    94       _card_counts[card_num] =
    95         (jubyte)(MIN2((uintx)(_card_counts[card_num] + 1), G1ConcRSHotCardLimit));
    96     }
    97   }
    98   return count;
    99 }
   101 bool G1CardCounts::is_hot(uint count) {
   102   return (count >= G1ConcRSHotCardLimit);
   103 }
   105 void G1CardCounts::clear_region(HeapRegion* hr) {
   106   MemRegion mr(hr->bottom(), hr->end());
   107   clear_range(mr);
   108 }
   110 void G1CardCounts::clear_range(MemRegion mr) {
   111   if (has_count_table()) {
   112     const jbyte* from_card_ptr = _ct_bs->byte_for_const(mr.start());
   113     // We use the last address in the range as the range could represent the
   114     // last region in the heap. In which case trying to find the card will be an
   115     // OOB access to the card table.
   116     const jbyte* last_card_ptr = _ct_bs->byte_for_const(mr.last());
   118 #ifdef ASSERT
   119     HeapWord* start_addr = _ct_bs->addr_for(from_card_ptr);
   120     assert(start_addr == mr.start(), "MemRegion start must be aligned to a card.");
   121     HeapWord* last_addr = _ct_bs->addr_for(last_card_ptr);
   122     assert((last_addr + CardTableModRefBS::card_size_in_words) == mr.end(), "MemRegion end must be aligned to a card.");
   123 #endif // ASSERT
   125     // Clear the counts for the (exclusive) card range.
   126     size_t from_card_num = ptr_2_card_num(from_card_ptr);
   127     size_t to_card_num = ptr_2_card_num(last_card_ptr) + 1;
   128     clear_range(from_card_num, to_card_num);
   129   }
   130 }
   132 class G1CardCountsClearClosure : public HeapRegionClosure {
   133  private:
   134   G1CardCounts* _card_counts;
   135  public:
   136   G1CardCountsClearClosure(G1CardCounts* card_counts) :
   137     HeapRegionClosure(), _card_counts(card_counts) { }
   140   virtual bool doHeapRegion(HeapRegion* r) {
   141     _card_counts->clear_region(r);
   142     return false;
   143   }
   144 };
   146 void G1CardCounts::clear_all() {
   147   assert(SafepointSynchronize::is_at_safepoint(), "don't call this otherwise");
   148   G1CardCountsClearClosure cl(this);
   149   _g1h->heap_region_iterate(&cl);
   150 }

mercurial